mirror of https://github.com/facebook/rocksdb.git
4cb7068c1e
Summary: There are two issues with `VisibleToActiveSnapshot`: 1. If there are no snapshots, `oldest_snapshot` will be 0 and `VisibleToActiveSnapshot` will always return true. Since the method is used to decide whether it is safe to delete obsolete files, obsolete file won't be able to delete in this case. 2. The `auto` keyword of `auto snapshots = db_impl_->snapshots()` translate to a copy of `const SnapshotList` instead of a reference. Since copy constructor of `SnapshotList` is not defined, using the copy may yield unexpected result. Issue 2 actually hide issue 1 from being catch by tests. During test `snapshots.empty()` can return false while it should actually be empty, and `snapshots.oldest()` return an invalid address, making `oldest_snapshot` being some random large number. The issue was originally reported by BlobDB early adopter at Kuaishou. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4236 Differential Revision: D9188706 Pulled By: yiwu-arbug fbshipit-source-id: a0f2624b927cf9bf28c1bb534784fee5d106f5ea |
||
|---|---|---|
| .. | ||
| backupable | ||
| blob_db | ||
| cassandra | ||
| checkpoint | ||
| compaction_filters | ||
| convenience | ||
| date_tiered | ||
| document | ||
| geodb | ||
| leveldb_options | ||
| lua | ||
| memory | ||
| merge_operators | ||
| option_change_migration | ||
| options | ||
| persistent_cache | ||
| redis | ||
| simulator_cache | ||
| spatialdb | ||
| table_properties_collectors | ||
| trace | ||
| transactions | ||
| ttl | ||
| write_batch_with_index | ||
| col_buf_decoder.cc | ||
| col_buf_decoder.h | ||
| col_buf_encoder.cc | ||
| col_buf_encoder.h | ||
| column_aware_encoding_exp.cc | ||
| column_aware_encoding_test.cc | ||
| column_aware_encoding_util.cc | ||
| column_aware_encoding_util.h | ||
| debug.cc | ||
| env_librados.cc | ||
| env_librados.md | ||
| env_librados_test.cc | ||
| env_mirror.cc | ||
| env_mirror_test.cc | ||
| env_timed.cc | ||
| env_timed_test.cc | ||
| merge_operators.h | ||
| object_registry_test.cc | ||
| util_merge_operators_test.cc | ||