mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
e230e4d248
Summary: As mentioned in https://github.com/facebook/rocksdb/issues/11893, we are going to use the offpeak time information to pre-process TTL-based compactions. To do so, we need to access `daily_offpeak_time_utc` in `VersionStorageInfo::ComputeCompactionScore()` where we pick the files to compact. This PR is to make the offpeak time information available at the time of compaction-scoring. We are not changing any compaction scoring logic just yet. Will follow up in a separate PR. There were two ways to achieve what we want. 1. Make `MutableDBOptions` available in `ColumnFamilyData` and `ComputeCompactionScore()` take `MutableDBOptions` along with `ImmutableOptions` and `MutableCFOptions`. 2. Make `daily_offpeak_time_utc` and `IsNowOffpeak()` available in `VersionStorageInfo`. We chose the latter as it involves smaller changes. This change includes the following - Introduction of `OffpeakTimeInfo` and `IsNowOffpeak()` has been moved from `MutableDBOptions` - `OffpeakTimeInfo` added to `VersionSet` and it can be set during construction and by `ChangeOffpeakTimeInfo()` - During `SetDBOptions()`, if offpeak time info needs to change, it calls `MaybeScheduleFlushOrCompaction()` to re-compute compaction scores and process compactions as needed Pull Request resolved: https://github.com/facebook/rocksdb/pull/12018 Test Plan: - `DBOptionsTest::OffpeakTimes` changed to include checks for `MaybeScheduleFlushOrCompaction()` calls and `VersionSet`'s OffpeakTimeInfo value change during `SetDBOptions()`. - `VersionSetTest::OffpeakTimeInfoTest` added to test `ChangeOffpeakTimeInfo()`. `IsNowOffpeak()` tests moved from `DBOptionsTest::OffpeakTimes` Reviewed By: pdillinger Differential Revision: D50723881 Pulled By: jaykorean fbshipit-source-id: 3cff0291936f3729c0e9c7750834b9378fb435f6
49 lines
1.7 KiB
C++
49 lines
1.7 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "options/offpeak_time_info.h"
|
|
|
|
#include "rocksdb/system_clock.h"
|
|
#include "util/string_util.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
OffpeakTimeInfo::OffpeakTimeInfo() : daily_offpeak_time_utc("") {}
|
|
OffpeakTimeInfo::OffpeakTimeInfo(const std::string& offpeak_time)
|
|
: daily_offpeak_time_utc(offpeak_time) {}
|
|
|
|
bool OffpeakTimeInfo::IsNowOffpeak(SystemClock* clock) const {
|
|
if (daily_offpeak_time_utc.empty()) {
|
|
return false;
|
|
}
|
|
int64_t now;
|
|
if (clock->GetCurrentTime(&now).ok()) {
|
|
constexpr int kSecondsPerDay = 86400;
|
|
constexpr int kSecondsPerMinute = 60;
|
|
int seconds_since_midnight_to_nearest_minute =
|
|
(static_cast<int>(now % kSecondsPerDay) / kSecondsPerMinute) *
|
|
kSecondsPerMinute;
|
|
int start_time = 0, end_time = 0;
|
|
bool success =
|
|
TryParseTimeRangeString(daily_offpeak_time_utc, start_time, end_time);
|
|
assert(success);
|
|
assert(start_time != end_time);
|
|
if (!success) {
|
|
// If the validation was done properly, we should never reach here
|
|
return false;
|
|
}
|
|
// if the offpeak duration spans overnight (i.e. 23:30 - 4:30 next day)
|
|
if (start_time > end_time) {
|
|
return start_time <= seconds_since_midnight_to_nearest_minute ||
|
|
seconds_since_midnight_to_nearest_minute <= end_time;
|
|
} else {
|
|
return start_time <= seconds_since_midnight_to_nearest_minute &&
|
|
seconds_since_midnight_to_nearest_minute <= end_time;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|