mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
269478ee46
Summary: This PR implements support for a three tier cache - primary block cache, compressed secondary cache, and a nvm (local flash) secondary cache. This allows more effective utilization of the nvm cache, and minimizes the number of reads from local flash by caching compressed blocks in the compressed secondary cache. The basic design is as follows - 1. A new secondary cache implementation, ```TieredSecondaryCache```, is introduced. It keeps the compressed and nvm secondary caches and manages the movement of blocks between them and the primary block cache. To setup a three tier cache, we allocate a ```CacheWithSecondaryAdapter```, with a ```TieredSecondaryCache``` instance as the secondary cache. 2. The table reader passes both the uncompressed and compressed block to ```FullTypedCacheInterface::InsertFull```, allowing the block cache to optionally store the compressed block. 3. When there's a miss, the block object is constructed and inserted in the primary cache, and the compressed block is inserted into the nvm cache by calling ```InsertSaved```. This avoids the overhead of recompressing the block, as well as avoiding putting more memory pressure on the compressed secondary cache. 4. When there's a hit in the nvm cache, we attempt to insert the block in the compressed secondary cache and the primary cache, subject to the admission policy of those caches (i.e admit on second access). Blocks/items evicted from any tier are simply discarded. We can easily implement additional admission policies if desired. Todo (In a subsequent PR): 1. Add to db_bench and run benchmarks 2. Add to db_stress Pull Request resolved: https://github.com/facebook/rocksdb/pull/11812 Reviewed By: pdillinger Differential Revision: D49461842 Pulled By: anand1976 fbshipit-source-id: b40ac1330ef7cd8c12efa0a3ca75128e602e3a0b
156 lines
5.4 KiB
C++
156 lines
5.4 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/cache.h"
|
|
#include "rocksdb/secondary_cache.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// A SecondaryCache that implements stacking of a compressed secondary cache
|
|
// and a non-volatile (local flash) cache. It implements an admission
|
|
// policy of warming the bottommost tier (local flash) with compressed
|
|
// blocks from the SST on misses, and on hits in the bottommost tier,
|
|
// promoting to the compressed and/or primary block cache. The admission
|
|
// policies of the primary block cache and compressed secondary cache remain
|
|
// unchanged - promote on second access. There is no demotion ofablocks
|
|
// evicted from a tier. They are just discarded.
|
|
//
|
|
// In order to properly handle compressed blocks directly read from SSTs, and
|
|
// to allow writeback of blocks compressed by the compressed secondary
|
|
// cache in the future, we make use of the compression type and source
|
|
// cache tier arguments in InsertSaved.
|
|
class TieredSecondaryCache : public SecondaryCacheWrapper {
|
|
public:
|
|
TieredSecondaryCache(std::shared_ptr<SecondaryCache> comp_sec_cache,
|
|
std::shared_ptr<SecondaryCache> nvm_sec_cache,
|
|
TieredAdmissionPolicy adm_policy)
|
|
: SecondaryCacheWrapper(comp_sec_cache), nvm_sec_cache_(nvm_sec_cache) {
|
|
#ifndef NDEBUG
|
|
assert(adm_policy == TieredAdmissionPolicy::kAdmPolicyThreeQueue);
|
|
#else
|
|
(void)adm_policy;
|
|
#endif
|
|
}
|
|
|
|
~TieredSecondaryCache() override {}
|
|
|
|
const char* Name() const override { return "TieredSecondaryCache"; }
|
|
|
|
// This is a no-op as we currently don't allow demotion (i.e
|
|
// insertion by the upper layer) of evicted blocks.
|
|
virtual Status Insert(const Slice& /*key*/, Cache::ObjectPtr /*obj*/,
|
|
const Cache::CacheItemHelper* /*helper*/,
|
|
bool /*force_insert*/) override {
|
|
return Status::OK();
|
|
}
|
|
|
|
// Warm up the nvm tier directly
|
|
virtual Status InsertSaved(
|
|
const Slice& key, const Slice& saved,
|
|
CompressionType type = CompressionType::kNoCompression,
|
|
CacheTier source = CacheTier::kVolatileTier) override {
|
|
return nvm_sec_cache_->InsertSaved(key, saved, type, source);
|
|
}
|
|
|
|
virtual std::unique_ptr<SecondaryCacheResultHandle> Lookup(
|
|
const Slice& key, const Cache::CacheItemHelper* helper,
|
|
Cache::CreateContext* create_context, bool wait, bool advise_erase,
|
|
bool& kept_in_sec_cache) override;
|
|
|
|
virtual void WaitAll(
|
|
std::vector<SecondaryCacheResultHandle*> handles) override;
|
|
|
|
private:
|
|
struct CreateContext : public Cache::CreateContext {
|
|
const Slice* key;
|
|
bool advise_erase;
|
|
const Cache::CacheItemHelper* helper;
|
|
Cache::CreateContext* inner_ctx;
|
|
std::shared_ptr<SecondaryCacheResultHandle> inner_handle;
|
|
SecondaryCache* comp_sec_cache;
|
|
};
|
|
|
|
class ResultHandle : public SecondaryCacheResultHandle {
|
|
public:
|
|
~ResultHandle() override {}
|
|
|
|
bool IsReady() override {
|
|
return !inner_handle_ || inner_handle_->IsReady();
|
|
}
|
|
|
|
void Wait() override {
|
|
inner_handle_->Wait();
|
|
Complete();
|
|
}
|
|
|
|
size_t Size() override { return size_; }
|
|
|
|
Cache::ObjectPtr Value() override { return value_; }
|
|
|
|
void Complete() {
|
|
assert(IsReady());
|
|
size_ = inner_handle_->Size();
|
|
value_ = inner_handle_->Value();
|
|
inner_handle_.reset();
|
|
}
|
|
|
|
void SetInnerHandle(std::unique_ptr<SecondaryCacheResultHandle>&& handle) {
|
|
inner_handle_ = std::move(handle);
|
|
}
|
|
|
|
void SetSize(size_t size) { size_ = size; }
|
|
|
|
void SetValue(Cache::ObjectPtr val) { value_ = val; }
|
|
|
|
CreateContext* ctx() { return &ctx_; }
|
|
|
|
SecondaryCacheResultHandle* inner_handle() { return inner_handle_.get(); }
|
|
|
|
private:
|
|
std::unique_ptr<SecondaryCacheResultHandle> inner_handle_;
|
|
CreateContext ctx_;
|
|
size_t size_;
|
|
Cache::ObjectPtr value_;
|
|
};
|
|
|
|
static void NoopDelete(Cache::ObjectPtr /*obj*/,
|
|
MemoryAllocator* /*allocator*/) {
|
|
assert(false);
|
|
}
|
|
static size_t ZeroSize(Cache::ObjectPtr /*obj*/) {
|
|
assert(false);
|
|
return 0;
|
|
}
|
|
static Status NoopSaveTo(Cache::ObjectPtr /*from_obj*/,
|
|
size_t /*from_offset*/, size_t /*length*/,
|
|
char* /*out_buf*/) {
|
|
assert(false);
|
|
return Status::OK();
|
|
}
|
|
static Status MaybeInsertAndCreate(const Slice& data, CompressionType type,
|
|
CacheTier source,
|
|
Cache::CreateContext* ctx,
|
|
MemoryAllocator* allocator,
|
|
Cache::ObjectPtr* out_obj,
|
|
size_t* out_charge);
|
|
|
|
static const Cache::CacheItemHelper* GetHelper() {
|
|
const static Cache::CacheItemHelper basic_helper(CacheEntryRole::kMisc,
|
|
&NoopDelete);
|
|
const static Cache::CacheItemHelper maybe_insert_and_create_helper{
|
|
CacheEntryRole::kMisc, &NoopDelete, &ZeroSize,
|
|
&NoopSaveTo, &MaybeInsertAndCreate, &basic_helper,
|
|
};
|
|
return &maybe_insert_and_create_helper;
|
|
}
|
|
|
|
std::shared_ptr<SecondaryCache> comp_sec_cache_;
|
|
std::shared_ptr<SecondaryCache> nvm_sec_cache_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|