mrambacher 3dff28cf9b Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033) ... Summary: For performance purposes, the lower level routines were changed to use a SystemClock* instead of a std::shared_ptr<SystemClock>. The shared ptr has some performance degradation on certain hardware classes. For most of the system, there is no risk of the pointer being deleted/invalid because the shared_ptr will be stored elsewhere. For example, the ImmutableDBOptions stores the Env which has a std::shared_ptr<SystemClock> in it. The SystemClock* within the ImmutableDBOptions is essentially a "short cut" to gain access to this constant resource. There were a few classes (PeriodicWorkScheduler?) where the "short cut" property did not hold. In those cases, the shared pointer was preserved. Using db_bench readrandom perf_level=3 on my EC2 box, this change performed as well or better than 6.17: 6.17: readrandom : 28.046 micros/op 854902 ops/sec; 61.3 MB/s (355999 of 355999 found) 6.18: readrandom : 32.615 micros/op 735306 ops/sec; 52.7 MB/s (290999 of 290999 found) PR: readrandom : 27.500 micros/op 871909 ops/sec; 62.5 MB/s (367999 of 367999 found) (Note that the times for 6.18 are prior to revert of the SystemClock). Pull Request resolved: https://github.com/facebook/rocksdb/pull/8033 Reviewed By: pdillinger Differential Revision: D27014563 Pulled By: mrambacher fbshipit-source-id: ad0459eba03182e454391b5926bf5cdd45657b67		2021-03-15 04:34:11 -07:00
..
aligned_buffer.h	Fix wrong comments about function TruncateToPageBoundary. (#6975)	2020-10-07 12:34:34 -07:00
autovector.h
autovector_test.cc
bloom_impl.h	Ribbon: InterleavedSolutionStorage (#7598)	2020-11-03 12:46:36 -08:00
bloom_test.cc	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
build_version.cc.in	Make builds reproducible (#7866)	2021-01-28 17:42:16 -08:00
cast_util.h	Replace reinterpret_cast with static_cast_with_check (#7067)	2020-07-02 19:25:41 -07:00
channel.h
coding.cc
coding.h	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
coding_lean.h	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
coding_test.cc
compaction_job_stats_impl.cc	Update compaction statistics to include the amount of data read from blob files (#8022)	2021-03-04 00:43:48 -08:00
comparator.cc	Enable backward iterator for keys with user-defined timestamp (#8035)	2021-03-10 11:15:46 -08:00
compression.h	Limit buffering for collecting samples for compression dictionary (#7970)	2021-02-19 14:09:54 -08:00
compression_context_cache.cc
compression_context_cache.h
concurrent_task_limiter_impl.cc
concurrent_task_limiter_impl.h
core_local.h
crc32c.cc	Fix build on FreeBSD/powerpc64(le) (#7732)	2020-12-08 15:31:56 -08:00
crc32c.h
crc32c_arm64.cc	Mac M1 crc32 intrinsics ARM64 check support proposal (#7893)	2021-03-10 09:05:56 -08:00
crc32c_arm64.h	Fix compilation on Apple Silicon (#7714)	2020-12-04 15:22:33 -08:00
crc32c_ppc.c	Fix Compilation on ppc64le using Clang 11 (#7713)	2020-12-01 11:21:44 -08:00
crc32c_ppc.h	Fix Compilation on ppc64le using Clang 11 (#7713)	2020-12-01 11:21:44 -08:00
crc32c_ppc_asm.S	Fix Compilation on ppc64le using Clang 11 (#7713)	2020-12-01 11:21:44 -08:00
crc32c_ppc_constants.h
crc32c_test.cc
defer.h
defer_test.cc
duplicate_detector.h
dynamic_bloom.cc
dynamic_bloom.h	Genericize and clean up FastRange (#7436)	2020-09-28 11:35:00 -07:00
dynamic_bloom_test.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
fastrange.h	Genericize and clean up FastRange (#7436)	2020-09-28 11:35:00 -07:00
file_checksum_helper.cc	Refactor with VersionEditHandler (#6581)	2020-11-11 08:00:14 -08:00
file_checksum_helper.h	Real fix for race in backup custom checksum checking (#7309)	2020-08-26 10:39:20 -07:00
file_reader_writer_test.cc	Refactor: add LineFileReader and Status::MustCheck (#8026)	2021-03-09 20:12:38 -08:00
filelock_test.cc	Fix MSVC-related build issues (#7439)	2020-10-01 09:23:04 -07:00
filter_bench.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
gflags_compat.h	Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)	2020-10-27 10:33:09 -07:00
hash.cc	Integrity protection for live updates to WriteBatch (#7748)	2021-01-29 12:18:58 -08:00
hash.h	Integrity protection for live updates to WriteBatch (#7748)	2021-01-29 12:18:58 -08:00
hash_map.h
hash_test.cc	Use NPHash64 in more places (#7632)	2020-11-10 23:42:13 -08:00
heap.h	Avoid self-move-assign in pop operation of binary heap. (#7942)	2021-02-19 13:47:25 -08:00
heap_test.cc
kv_map.h
log_write_bench.cc	Add a SystemClock class to capture the time functions of an Env (#7858)	2021-01-25 22:09:11 -08:00
math.h	Fix MSVC-related build issues (#7439)	2020-10-01 09:23:04 -07:00
math128.h	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
murmurhash.cc
murmurhash.h
mutexlock.h
ppc-opcode.h
random.cc	More Makefile Cleanup (#7097)	2020-07-09 14:35:17 -07:00
random.h	More Makefile Cleanup (#7097)	2020-07-09 14:35:17 -07:00
random_test.cc
rate_limiter.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
rate_limiter.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
rate_limiter_test.cc	Add a SystemClock class to capture the time functions of an Env (#7858)	2021-01-25 22:09:11 -08:00
repeatable_thread.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
repeatable_thread_test.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
ribbon_alg.h	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
ribbon_config.cc	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
ribbon_config.h	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
ribbon_impl.h	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
ribbon_test.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
set_comparator.h
slice.cc
slice_test.cc	Handoff checksum Implementation (#7523)	2021-02-10 22:20:32 -08:00
slice_transform_test.cc
status.cc	add string separation while composing error message (#7919)	2021-02-18 12:25:35 -08:00
stderr_logger.h
stop_watch.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
string_util.cc	Remove unused includes (#7604)	2020-10-28 23:22:27 -07:00
string_util.h
thread_list_test.cc	fix thread status synchronization in thread_list_test (#7825)	2021-01-04 10:46:24 -08:00
thread_local.cc	Fix typo in ThreadData comment (#7131)	2020-07-15 09:23:23 -07:00
thread_local.h
thread_local_test.cc
thread_operation.h
threadpool_imp.cc	Make it able to lower cpu priority to specific level in threadpool (#6969)	2020-06-13 13:25:20 -07:00
threadpool_imp.h	Make it able to lower cpu priority to specific level in threadpool (#6969)	2020-06-13 13:25:20 -07:00
timer.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
timer_queue.h
timer_queue_test.cc
timer_test.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
user_comparator_wrapper.h	Enable backward iterator for keys with user-defined timestamp (#8035)	2021-03-10 11:15:46 -08:00
vector_iterator.h
work_queue.h
work_queue_test.cc
xxh3p.h	Fix MSVC-related build issues (#7439)	2020-10-01 09:23:04 -07:00
xxhash.cc	Remove unused includes (#7604)	2020-10-28 23:22:27 -07:00
xxhash.h