Go to file
Kosie van der Merwe 3c3df7402f Fixed issues Valgrind found.
Summary:
Found issues with `db_test` and `db_stress` when running valgrind.

`DBImpl` had an issue where if an compaction failed then it will use the uninitialised file size of an output file is used. This manifested as the final call to output to the log in `DoCompactionWork()` branching on uninitialized memory (all the way down in printf's innards).

Test Plan:
Ran `valgrind --track_origins=yes ./db_test` and `valgrind ./db_stress` to see if issues disappeared.

Ran `make check` to see if there were no regressions.

Reviewers: vamsi, dhruba

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D8001
2013-01-17 10:04:45 -08:00
db Fixed issues Valgrind found. 2013-01-17 10:04:45 -08:00
doc merge 1.5 2012-08-28 11:43:33 -07:00
hdfs Added clearer error message for failure to create db directory in DBImpl::Recover() 2013-01-07 10:11:18 -08:00
helpers/memenv Move WAL files to archive directory, instead of deleting. 2012-11-28 17:28:08 -08:00
include/leveldb Added an API in rocksdb for checking for "invalid argument" and "not supported" for leveldb::Status 2013-01-16 14:30:45 -08:00
java Pom changes to make relase 1.5.7 for java. 2013-01-10 10:43:43 -08:00
linters/src fixing linters. 2012-12-14 14:05:27 -08:00
port Make compression options configurable. These include window-bits, level and strategy for ZlibCompression 2012-11-02 11:26:39 -07:00
scribe fix db_test error with scribe logger turned on 2012-08-28 11:22:58 -07:00
snappy Build with gcc-4.7.1-glibc-2.14.1. 2012-09-17 10:56:26 -07:00
table Add optional clang compile mode 2013-01-15 18:48:37 -08:00
thrift Implement RowLocks for assoc schema 2012-10-03 23:19:01 -07:00
tools Fixed issues Valgrind found. 2013-01-17 10:04:45 -08:00
util rollover manifest file. 2013-01-16 12:09:44 -08:00
.arcconfig Enhancements to rocksdb for better support for replication. 2012-12-17 11:40:19 -08:00
.gitignore Various build cleanups/improvements 2013-01-14 18:40:22 -08:00
AUTHORS reverting disastrous MOE commit, returning to r21 2011-04-19 23:11:15 +00:00
LICENSE reverting disastrous MOE commit, returning to r21 2011-04-19 23:11:15 +00:00
Makefile Various build cleanups/improvements 2013-01-14 18:40:22 -08:00
NEWS sync with upstream @ 21409451 2011-05-21 02:17:43 +00:00
README rocksdb README file. 2012-11-29 22:39:08 -08:00
README.fb Release 1.5.7.fb 2013-01-09 10:26:03 -08:00
TODO A number of smaller fixes and performance improvements: 2011-06-22 02:36:45 +00:00
build_detect_platform Add optional clang compile mode 2013-01-15 18:48:37 -08:00
build_detect_version Various build cleanups/improvements 2013-01-14 18:40:22 -08:00
build_java.sh Release 1.5.6 for Java code + Script to automate it. 2012-12-17 12:11:11 -08:00
fbcode.clang31.sh Add optional clang compile mode 2013-01-15 18:48:37 -08:00
fbcode.gcc471.sh Add optional clang compile mode 2013-01-15 18:48:37 -08:00
regression_build_test.sh Minor improvements to the regression testing 2013-01-16 14:47:20 -08:00

README

rocksdb: A persistent key-value store for flash storage
Authors: The Facebook Database Engineering Team

This code is a library that forms the core building block for a fast 
key value server, especially suited for storing data on flash drives.
It has an Log-Stuctured-Merge-Database (LSM) design with flexible tradeoffs
between Write-Amplification-Factor(WAF), Read-Amplification-Factor (RAF)
and Space-Amplification-Factor(SAF). It has multi-threaded compactions,
making it specially suitable for storing multiple terabytes of data in a
single database.

The core of this code has been derived from open-source leveldb.

leveldb: A key-value store
Authors: Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

The code under this directory implements a system for maintaining a
persistent key/value store.

See doc/index.html for more explanation.
See doc/impl.html for a brief overview of the implementation.

The public interface is in include/*.h.  Callers should not include or
rely on the details of any other header files in this package.  Those
internal APIs may be changed without warning.

Guide to header files:

include/db.h
    Main interface to the DB: Start here

include/options.h
    Control over the behavior of an entire database, and also
    control over the behavior of individual reads and writes.

include/comparator.h
    Abstraction for user-specified comparison function.  If you want
    just bytewise comparison of keys, you can use the default comparator,
    but clients can write their own comparator implementations if they
    want custom ordering (e.g. to handle different character
    encodings, etc.)

include/iterator.h
    Interface for iterating over data. You can get an iterator
    from a DB object.

include/write_batch.h
    Interface for atomically applying multiple updates to a database.

include/slice.h
    A simple module for maintaining a pointer and a length into some
    other byte array.

include/status.h
    Status is returned from many of the public interfaces and is used
    to report success and various kinds of errors.

include/env.h
    Abstraction of the OS environment.  A posix implementation of
    this interface is in util/env_posix.cc

include/table.h
include/table_builder.h
    Lower-level modules that most clients probably won't use directly