Zhongyi Xie 3a18bb3e15 BaseDeltaIterator: always check valid() before accessing key() (#4702) ... Summary: Current implementation of `current_over_upper_bound_` fails to take into consideration that keys might be invalid in either base iterator or delta iterator. Calling key() in such scenario will lead to assertion failure and runtime errors. This PR addresses the bug by adding check for valid keys before calling `IsOverUpperBound()`, also added test coverage for iterate_upper_bound usage in BaseDeltaIterator Also recommit https://github.com/facebook/rocksdb/pull/4656 (It was reverted earlier due to bugs) Pull Request resolved: https://github.com/facebook/rocksdb/pull/4702 Differential Revision: D13146643 Pulled By: miasantreble fbshipit-source-id: 6d136929da12d0f2e2a5cea474a8038ec5cdf1d0		2018-11-30 15:35:13 -08:00
..
write_batch_with_index.cc	BaseDeltaIterator: always check valid() before accessing key() (#4702)	2018-11-30 15:35:13 -08:00
write_batch_with_index_internal.cc	Fix WriteBatchWithIndex's SeekForPrev() (#4559)	2018-10-19 14:40:50 -07:00
write_batch_with_index_internal.h	Fix WriteBatchWithIndex's SeekForPrev() (#4559)	2018-10-19 14:40:50 -07:00
write_batch_with_index_test.cc	BaseDeltaIterator: always check valid() before accessing key() (#4702)	2018-11-30 15:35:13 -08:00