mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 13:41:46 +00:00
d247230aec
Summary: As title. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9383 Test Plan: manually add `using namespace` to a file, and run `make check-sources`. Then, remove `using namespace`, and run `make check-sources` Reviewed By: ajkr Differential Revision: D33551706 Pulled By: riversand963 fbshipit-source-id: 1bb8304f38434da7de0656882e62e77673155725
37 lines
907 B
Bash
Executable file
37 lines
907 B
Bash
Executable file
#!/usr/bin/env bash
|
|
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
|
#
|
|
# Check for some simple mistakes that should prevent commit or push
|
|
|
|
BAD=""
|
|
|
|
git grep 'namespace rocksdb' -- '*.[ch]*'
|
|
if [ "$?" != "1" ]; then
|
|
echo "^^^^^ Do not hardcode namespace rocksdb. Use ROCKSDB_NAMESPACE"
|
|
BAD=1
|
|
fi
|
|
|
|
git grep -i 'nocommit' -- ':!build_tools/check-sources.sh'
|
|
if [ "$?" != "1" ]; then
|
|
echo "^^^^^ Code was not intended to be committed"
|
|
BAD=1
|
|
fi
|
|
|
|
git grep '<rocksdb/' -- ':!build_tools/check-sources.sh'
|
|
if [ "$?" != "1" ]; then
|
|
echo '^^^^^ Use double-quotes as in #include "rocksdb/something.h"'
|
|
BAD=1
|
|
fi
|
|
|
|
git grep 'using namespace' -- ':!build_tools' ':!docs' \
|
|
':!third-party/folly/folly/lang/Align.h' \
|
|
':!third-party/gtest-1.8.1/fused-src/gtest/gtest.h'
|
|
if [ "$?" != "1" ]; then
|
|
echo '^^^^ Do not use "using namespace"'
|
|
BAD=1
|
|
fi
|
|
|
|
if [ "$BAD" ]; then
|
|
exit 1
|
|
fi
|