mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
9a034801ce
Summary:
**Context/Summary:**
- Similar to https://github.com/facebook/rocksdb/pull/11288 but for user read such as `Get(), MultiGet(), DBIterator::XXX(), Verify(File)Checksum()`.
- For this, I refactored some user-facing `MultiGet` calls in `TransactionBase` and various types of `DB` so that it does not call a user-facing `Get()` but `GetImpl()` for passing the `ReadOptions::io_activity` check (see PR conversation)
- New user read stats breakdown are guarded by `kExceptDetailedTimers` since measurement shows they have 4-5% regression to the upstream/main.
- Misc
- More refactoring: with https://github.com/facebook/rocksdb/pull/11288, we complete passing `ReadOptions/IOOptions` to FS level. So we can now replace the previously [added](https://github.com/facebook/rocksdb/pull/9424) `rate_limiter_priority` parameter in `RandomAccessFileReader`'s `Read/MultiRead/Prefetch()` with `IOOptions::rate_limiter_priority`
- Also, `ReadAsync()` call time is measured in `SST_READ_MICRO` now
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11444
Test Plan:
- CI fake db crash/stress test
- Microbenchmarking
**Build** `make clean && ROCKSDB_NO_FBCODE=1 DEBUG_LEVEL=0 make -jN db_basic_bench`
- google benchmark version:
|
||
|---|---|---|
| .. | ||
| backup_engine_options.cc | ||
| backupenginejni.cc | ||
| cache.cc | ||
| cassandra_compactionfilterjni.cc | ||
| cassandra_value_operator.cc | ||
| checkpoint.cc | ||
| clock_cache.cc | ||
| columnfamilyhandle.cc | ||
| compact_range_options.cc | ||
| compaction_filter.cc | ||
| compaction_filter_factory.cc | ||
| compaction_filter_factory_jnicallback.cc | ||
| compaction_filter_factory_jnicallback.h | ||
| compaction_job_info.cc | ||
| compaction_job_stats.cc | ||
| compaction_options.cc | ||
| compaction_options_fifo.cc | ||
| compaction_options_universal.cc | ||
| comparator.cc | ||
| comparatorjnicallback.cc | ||
| comparatorjnicallback.h | ||
| compression_options.cc | ||
| concurrent_task_limiter.cc | ||
| config_options.cc | ||
| cplusplus_to_java_convert.h | ||
| env.cc | ||
| env_options.cc | ||
| event_listener.cc | ||
| event_listener_jnicallback.cc | ||
| event_listener_jnicallback.h | ||
| filter.cc | ||
| ingest_external_file_options.cc | ||
| iterator.cc | ||
| jnicallback.cc | ||
| jnicallback.h | ||
| loggerjnicallback.cc | ||
| loggerjnicallback.h | ||
| lru_cache.cc | ||
| memory_util.cc | ||
| memtablejni.cc | ||
| merge_operator.cc | ||
| native_comparator_wrapper_test.cc | ||
| optimistic_transaction_db.cc | ||
| optimistic_transaction_options.cc | ||
| options.cc | ||
| options_util.cc | ||
| persistent_cache.cc | ||
| portal.h | ||
| ratelimiterjni.cc | ||
| remove_emptyvalue_compactionfilterjni.cc | ||
| restorejni.cc | ||
| rocks_callback_object.cc | ||
| rocksdb_exception_test.cc | ||
| rocksjni.cc | ||
| slice.cc | ||
| snapshot.cc | ||
| sst_file_manager.cc | ||
| sst_file_reader_iterator.cc | ||
| sst_file_readerjni.cc | ||
| sst_file_writerjni.cc | ||
| sst_partitioner.cc | ||
| statistics.cc | ||
| statisticsjni.cc | ||
| statisticsjni.h | ||
| table.cc | ||
| table_filter.cc | ||
| table_filter_jnicallback.cc | ||
| table_filter_jnicallback.h | ||
| testable_event_listener.cc | ||
| thread_status.cc | ||
| trace_writer.cc | ||
| trace_writer_jnicallback.cc | ||
| trace_writer_jnicallback.h | ||
| transaction.cc | ||
| transaction_db.cc | ||
| transaction_db_options.cc | ||
| transaction_log.cc | ||
| transaction_notifier.cc | ||
| transaction_notifier_jnicallback.cc | ||
| transaction_notifier_jnicallback.h | ||
| transaction_options.cc | ||
| ttl.cc | ||
| wal_filter.cc | ||
| wal_filter_jnicallback.cc | ||
| wal_filter_jnicallback.h | ||
| write_batch.cc | ||
| write_batch_test.cc | ||
| write_batch_with_index.cc | ||
| write_buffer_manager.cc | ||
| writebatchhandlerjnicallback.cc | ||
| writebatchhandlerjnicallback.h | ||