rocksdb/utilities/write_batch_with_index
Levi Tamasi ef38d99edc Sanity check the keys parameter in MultiGetEntityFromBatchAndDB (#12564)
Summary:
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12564

Similarly to how `db`, `column_family`, and `results` are handled, bail out early from `WriteBatchWithIndex::MultiGetEntityFromBatchAndDB` if `keys` is `nullptr`. Note that these checks are best effort in the sense that with the current method signature, the callee has no way of reporting an error if `statuses` is `nullptr` or catching other types of invalid pointers (e.g. when `keys` and/or `results` is non-`nullptr` but do not point to a contiguous range of `num_keys` objects). We can improve this (and many similar RocksDB APIs) using `std::span` in a major release once we move to C++20.

Reviewed By: jaykorean

Differential Revision: D56318179

fbshipit-source-id: bc7a258eda82b5f6c839f212ab824130e773a4f0
2024-04-18 14:26:58 -07:00
..
write_batch_with_index.cc Sanity check the keys parameter in MultiGetEntityFromBatchAndDB (#12564) 2024-04-18 14:26:58 -07:00
write_batch_with_index_internal.cc Reset user-facing wide-column stuctures upon deserialization failures (#12562) 2024-04-18 13:08:34 -07:00
write_batch_with_index_internal.h Deduplicate WriteBatchWithIndex::{Get,GetEntity}FromBatch (#12442) 2024-03-18 12:04:54 -07:00
write_batch_with_index_test.cc Add MultiGetEntityFromBatchAndDB to WriteBatchWithIndex (#12539) 2024-04-16 08:58:04 -07:00