mirror of https://github.com/facebook/rocksdb.git
afa2420c2b
Summary: The current Env API encompasses both storage/file operations, as well as OS related operations. Most of the APIs return a Status, which does not have enough metadata about an error, such as whether its retry-able or not, scope (i.e fault domain) of the error etc., that may be required in order to properly handle a storage error. The file APIs also do not provide enough control over the IO SLA, such as timeout, prioritization, hinting about placement and redundancy etc. This PR separates out the file/storage APIs from Env into a new FileSystem class. The APIs are updated to return an IOStatus with metadata about the error, as well as to take an IOOptions structure as input in order to allow more control over the IO. The user can set both ```options.env``` and ```options.file_system``` to specify that RocksDB should use the former for OS related operations and the latter for storage operations. Internally, a ```CompositeEnvWrapper``` has been introduced that inherits from ```Env``` and redirects individual methods to either an ```Env``` implementation or the ```FileSystem``` as appropriate. When options are sanitized during ```DB::Open```, ```options.env``` is replaced with a newly allocated ```CompositeEnvWrapper``` instance if both env and file_system have been specified. This way, the rest of the RocksDB code can continue to function as before. This PR also ports PosixEnv to the new API by splitting it into two - PosixEnv and PosixFileSystem. PosixEnv is defined as a sub-class of CompositeEnvWrapper, and threading/time functions are overridden with Posix specific implementations in order to avoid an extra level of indirection. The ```CompositeEnvWrapper``` translates ```IOStatus``` return code to ```Status```, and sets the severity to ```kSoftError``` if the io_status is retryable. The error handling code in RocksDB can then recover the DB automatically. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5761 Differential Revision: D18868376 Pulled By: anand1976 fbshipit-source-id: 39efe18a162ea746fabac6360ff529baba48486f |
||
|---|---|---|
| .. | ||
| block_cache_tier.cc | ||
| block_cache_tier.h | ||
| block_cache_tier_file.cc | ||
| block_cache_tier_file.h | ||
| block_cache_tier_file_buffer.h | ||
| block_cache_tier_metadata.cc | ||
| block_cache_tier_metadata.h | ||
| hash_table.h | ||
| hash_table_bench.cc | ||
| hash_table_evictable.h | ||
| hash_table_test.cc | ||
| lrulist.h | ||
| persistent_cache_bench.cc | ||
| persistent_cache_test.cc | ||
| persistent_cache_test.h | ||
| persistent_cache_tier.cc | ||
| persistent_cache_tier.h | ||
| persistent_cache_util.h | ||
| volatile_tier_impl.cc | ||
| volatile_tier_impl.h | ||