dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-27 02:44:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
rocksdb/arcanist_util
History
Islam AbdelRahman 3cd9ed1c31 Show sandcastle URL in phabricator 
Summary:
We are passing a string as diff_id which make conduit call fail

```
$ echo '{"diff_id": "20982117", "name":"click here for sandcastle tests for D20982117", "link":"https://our.intern.facebook.com/intern/sandcastle/1984718793/"}' | arc call-conduit differential.updateunitresults
{"error":"ERR-CONDUIT-CORE","errorMessage":"ERR-CONDUIT-CORE: Argument 1 passed to EntDiffPropertiesUpdateMutationBuilder::setDiffNumber() must be an instance of int, string given","response":null}
```

fix it by removing double quotes
Closes https://github.com/facebook/rocksdb/pull/1700

Differential Revision: D4350227

Pulled By: IslamAbdelRahman

fbshipit-source-id: b4504af
2016-12-20 11:09:12 -08:00
..
config Show sandcastle URL in phabricator 2016-12-20 11:09:12 -08:00
cpp_linter Allow arcanist_util to work with both new and old arc versions 2016-06-17 04:36:52 -07:00
lint_engine Allow arcanist_util to work with both new and old arc versions 2016-06-17 04:36:52 -07:00
unit_engine Fixes for arcanist config (#1271) 2016-08-11 10:09:43 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Fixes for arcanist config (#1271) 2016-08-11 10:09:43 -07:00