mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 13:41:46 +00:00
6d06be22c0
Summary: db_stress was already capable running transactions by setting use_txn. Running it under stress showed a couple of problems fixed in this patch. - The uncommitted transaction must be either rolled back or commit after recovery. - Current implementation of WritePrepared transaction cannot handle cf drop before crash. Clarified that in the comments and added safety checks. When running with use_txn, clear_column_family_one_in must be set to 0. Closes https://github.com/facebook/rocksdb/pull/3733 Differential Revision: D7654419 Pulled By: maysamyabandeh fbshipit-source-id: a024bad80a9dc99677398c00d29ff17d4436b7f3
73 lines
2.3 KiB
C++
73 lines
2.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#ifndef __STDC_FORMAT_MACROS
|
|
#define __STDC_FORMAT_MACROS
|
|
#endif
|
|
|
|
#include <inttypes.h>
|
|
|
|
#include "util/set_comparator.h"
|
|
|
|
namespace rocksdb {
|
|
// During recovery if the memtable is flushed we cannot rely on its help on
|
|
// duplicate key detection and as key insert will not be attempted. This class
|
|
// will be used as a emulator of memtable to tell if insertion of a key/seq
|
|
// would have resulted in duplication.
|
|
class DuplicateDetector {
|
|
public:
|
|
explicit DuplicateDetector(DBImpl* db) : db_(db) {}
|
|
bool IsDuplicateKeySeq(uint32_t cf, const Slice& key, SequenceNumber seq) {
|
|
assert(seq >= batch_seq_);
|
|
if (batch_seq_ != seq) { // it is a new batch
|
|
keys_.clear();
|
|
}
|
|
batch_seq_ = seq;
|
|
CFKeys& cf_keys = keys_[cf];
|
|
if (cf_keys.size() == 0) { // just inserted
|
|
InitWithComp(cf);
|
|
}
|
|
auto it = cf_keys.insert(key);
|
|
if (it.second == false) { // second is false if a element already existed.
|
|
keys_.clear();
|
|
InitWithComp(cf);
|
|
keys_[cf].insert(key);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
private:
|
|
SequenceNumber batch_seq_ = 0;
|
|
DBImpl* db_;
|
|
using CFKeys = std::set<Slice, SetComparator>;
|
|
std::map<uint32_t, CFKeys> keys_;
|
|
void InitWithComp(const uint32_t cf) {
|
|
auto h = db_->GetColumnFamilyHandle(cf);
|
|
if (!h) {
|
|
// TODO(myabandeh): This is not a concern in MyRocks as drop cf is not
|
|
// implemented yet. When it does, we should return proper error instead
|
|
// of throwing exception.
|
|
ROCKS_LOG_FATAL(
|
|
db_->immutable_db_options().info_log,
|
|
"Recovering an entry from the dropped column family %" PRIu32
|
|
". WAL must must have been emptied before dropping the column "
|
|
"family");
|
|
#ifndef ROCKSDB_LITE
|
|
throw std::runtime_error(
|
|
"Recovering an entry from the dropped column family %" PRIu32
|
|
". WAL must must have been flushed before dropping the column "
|
|
"family");
|
|
#endif
|
|
return;
|
|
}
|
|
auto cmp = h->GetComparator();
|
|
keys_[cf] = CFKeys(SetComparator(cmp));
|
|
}
|
|
};
|
|
} // namespace rocksdb
|