rocksdb/db
Manuel Ung 908b1ee64e WriteUnPrepared: Fix assertion during recovery (#6419)
Summary:
During recovery, multiple (un)prepared batches could exist in the same WAL record due to group commit. This breaks an assertion in `MemTableInserter::MarkBeginPrepare`.

To fix, reset unprepared_batch_ to false after `MarkEndPrepare`.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6419

Differential Revision: D19896148

Pulled By: lth

fbshipit-source-id: b1a32ef88f775a0881264a18bd1a4a5b8c85eee3
2020-02-13 18:52:05 -08:00
..
compaction Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
db_impl Should flush and sync WAL when writing it in DB::Open() (#6417) 2020-02-13 18:41:04 -08:00
arena_wrapped_db_iter.cc delete superversions in BackgroundCallPurge (#6146) 2019-12-17 13:22:57 -08:00
arena_wrapped_db_iter.h
blob_index.h Mark BlobIndex::DebugString const 2019-12-11 17:19:43 -08:00
builder.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
builder.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
c.cc Add an option to prevent DB::Open() from querying sizes of all sst files (#6353) 2020-02-04 01:27:26 -08:00
c_test.c Fix error message (#6264) 2020-01-07 12:32:20 -08:00
column_family.cc Avoid create directory for every column families (#6358) 2020-02-03 14:13:39 -08:00
column_family.h Avoid create directory for every column families (#6358) 2020-02-03 14:13:39 -08:00
column_family_test.cc Add unit tests for concurrent CF iteration and drop (#6180) 2019-12-18 11:54:35 -08:00
compact_files_test.cc Use aggregate initialization for FlushJobInfo/CompactionJobInfo (#5997) 2019-11-01 11:46:19 -07:00
compacted_db_impl.cc
compacted_db_impl.h
comparator_db_test.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
convenience.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
corruption_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
cuckoo_table_db_test.cc Fix memory leak on error opening PlainTable (#5951) 2019-10-21 16:53:06 -07:00
db_basic_test.cc Ensure all MultiGet IO errors are propagated to user (#6403) 2020-02-11 17:27:22 -08:00
db_blob_index_test.cc Disable blob iterator test with max_sequential_skip_in_iterations==0 in LITE mode (#6052) 2019-11-19 15:02:41 -08:00
db_block_cache_test.cc Small tidy and speed up of the travis build (#6181) 2019-12-17 13:56:45 -08:00
db_bloom_filter_test.cc Fix db_bloom_filter_test clang LITE build (#6340) 2020-01-29 12:57:48 -08:00
db_compaction_filter_test.cc Shorten certain test names to avoid infra failure (#6352) 2020-01-30 23:10:24 -08:00
db_compaction_test.cc Make DBCompactionTest.SkipStatsUpdateTest more robust (#6306) 2020-01-21 12:55:55 -08:00
db_dynamic_level_test.cc
db_encryption_test.cc
db_filesnapshot.cc Support concurrent CF iteration and drop (#6147) 2019-12-12 19:04:48 -08:00
db_flush_test.cc Atomic flush rollback once on failure (#6385) 2020-02-07 10:52:10 -08:00
db_info_dumper.cc Apply formatter to recent 200+ commits. (#5830) 2019-09-20 12:04:26 -07:00
db_info_dumper.h
db_inplace_update_test.cc
db_io_failure_test.cc
db_iter.cc Add ReadOptions.auto_prefix_mode (#6314) 2020-01-28 14:44:05 -08:00
db_iter.h Add ReadOptions.auto_prefix_mode (#6314) 2020-01-28 14:44:05 -08:00
db_iter_stress_test.cc
db_iter_test.cc
db_iterator_test.cc Add unit tests for concurrent CF iteration and drop (#6180) 2019-12-18 11:54:35 -08:00
db_log_iter_test.cc
db_memtable_test.cc
db_merge_operand_test.cc
db_merge_operator_test.cc unordered_write incompatible with max_successive_merges (#6284) 2020-01-10 16:53:19 -08:00
db_options_test.cc Adjust thread pool sizes when setting max_background_jobs dynamically (#6300) 2020-01-16 14:35:10 -08:00
db_properties_test.cc
db_range_del_test.cc Fix RangeDeletion bug (#6062) 2019-12-12 15:18:02 -08:00
db_sst_test.cc Be able to read compatible leveldb sst files (#6370) 2020-02-06 10:15:44 -08:00
db_statistics_test.cc
db_table_properties_test.cc
db_tailing_iter_test.cc
db_test.cc Avoid to get manifest file size when recovering from it. (#6369) 2020-02-04 11:39:23 -08:00
db_test2.cc Fix DBTest2.ChangePrefixExtractor LITE build (#6356) 2020-01-31 15:44:14 -08:00
db_test_util.cc Add oldest snapshot sequence property (#6228) 2020-01-07 08:36:44 -08:00
db_test_util.h Add oldest snapshot sequence property (#6228) 2020-01-07 08:36:44 -08:00
db_universal_compaction_test.cc Shorten certain test names to avoid infra failure (#6352) 2020-01-30 23:10:24 -08:00
db_wal_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
db_write_test.cc Fix queue manipulation in WriteThread::BeginWriteStall() (#6322) 2020-01-23 14:01:28 -08:00
dbformat.cc Apply formatter to recent 200+ commits. (#5830) 2019-09-20 12:04:26 -07:00
dbformat.h
dbformat_test.cc
deletefile_test.cc Refactor deletefile_test.cc (#5822) 2019-09-18 16:58:21 -07:00
error_handler.cc Force a new manifest file if append to current one fails (#6331) 2020-01-30 10:56:29 -08:00
error_handler.h
error_handler_test.cc Fix a test failure in error_handler_test (#6367) 2020-02-03 18:16:52 -08:00
event_helpers.cc BlobDB GC: add SST <-> oldest blob file referenced mapping (#5903) 2019-10-14 15:21:01 -07:00
event_helpers.h BlobDB GC: add SST <-> oldest blob file referenced mapping (#5903) 2019-10-14 15:21:01 -07:00
experimental.cc
external_sst_file_basic_test.cc
external_sst_file_ingestion_job.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
external_sst_file_ingestion_job.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
external_sst_file_test.cc wait pending memtable writes on file ingestion or compact range (#6113) 2019-12-12 14:08:02 -08:00
fault_injection_test.cc
file_indexer.cc Bug when multiple files at one level contains the same smallest key (#6285) 2020-01-13 16:27:42 -08:00
file_indexer.h
file_indexer_test.cc
filename_test.cc
flush_job.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
flush_job.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
flush_job_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
flush_scheduler.cc Support concurrent CF iteration and drop (#6147) 2019-12-12 19:04:48 -08:00
flush_scheduler.h
forward_iterator.cc delete superversions in BackgroundCallPurge (#6146) 2019-12-17 13:22:57 -08:00
forward_iterator.h
forward_iterator_bench.cc
import_column_family_job.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
import_column_family_job.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
import_column_family_test.cc Apply formatter to recent 200+ commits. (#5830) 2019-09-20 12:04:26 -07:00
internal_stats.cc Remove inaccurate code comment (#6274) 2020-01-08 17:51:42 -08:00
internal_stats.h Add oldest snapshot sequence property (#6228) 2020-01-07 08:36:44 -08:00
job_context.h
listener_test.cc Propagate SST and blob file numbers through the EventListener interface (#5962) 2019-10-24 14:44:15 -07:00
log_format.h
log_reader.cc
log_reader.h Avoid to get manifest file size when recovering from it. (#6369) 2020-02-04 11:39:23 -08:00
log_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
log_writer.cc
log_writer.h
logs_with_prep_tracker.cc
logs_with_prep_tracker.h
lookup_key.h
malloc_stats.cc
malloc_stats.h
manual_compaction_test.cc
memtable.cc Add ReadOptions.auto_prefix_mode (#6314) 2020-01-28 14:44:05 -08:00
memtable.h Do not schedule memtable trimming if there is no history (#6177) 2019-12-13 19:11:19 -08:00
memtable_list.cc Fix a data race related to memtable trimming (#6187) 2019-12-16 13:16:31 -08:00
memtable_list.h Fix a data race related to memtable trimming (#6187) 2019-12-16 13:16:31 -08:00
memtable_list_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
merge_context.h
merge_helper.cc
merge_helper.h
merge_helper_test.cc
merge_operator.cc
merge_test.cc unordered_write incompatible with max_successive_merges (#6284) 2020-01-10 16:53:19 -08:00
obsolete_files_test.cc Refactor ObsoleteFilesTest to inherit from DBTestBase (#5820) 2019-09-18 11:52:17 -07:00
options_file_test.cc
perf_context_test.cc
pinned_iterators_manager.h
plain_table_db_test.cc Fix memory leak on error opening PlainTable (#5951) 2019-10-21 16:53:06 -07:00
pre_release_callback.h
prefix_test.cc
range_del_aggregator.cc Correct pragma once problem with Bazel on Windows (#6321) 2020-01-21 16:12:43 -08:00
range_del_aggregator.h Correct pragma once problem with Bazel on Windows (#6321) 2020-01-21 16:12:43 -08:00
range_del_aggregator_bench.cc
range_del_aggregator_test.cc
range_tombstone_fragmenter.cc Apply formatter to recent 200+ commits. (#5830) 2019-09-20 12:04:26 -07:00
range_tombstone_fragmenter.h
range_tombstone_fragmenter_test.cc
read_callback.h
repair.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
repair_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
snapshot_checker.h
snapshot_impl.cc
snapshot_impl.h Add oldest snapshot sequence property (#6228) 2020-01-07 08:36:44 -08:00
table_cache.cc Ensure all MultiGet IO errors are propagated to user (#6403) 2020-02-11 17:27:22 -08:00
table_cache.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
table_properties_collector.cc
table_properties_collector.h
table_properties_collector_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
transaction_log_impl.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
transaction_log_impl.h
trim_history_scheduler.cc Support concurrent CF iteration and drop (#6147) 2019-12-12 19:04:48 -08:00
trim_history_scheduler.h
version_builder.cc Clean up VersionEdit a bit (#6383) 2020-02-07 13:27:06 -08:00
version_builder.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
version_builder_test.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
version_edit.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
version_edit.h Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
version_edit_test.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
version_set.cc Revert usage of Defer. (#6410) 2020-02-13 10:31:32 -08:00
version_set.h Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
version_set_test.cc Checksum for each SST file and stores in MANIFEST (#6216) 2020-02-10 15:52:52 -08:00
wal_manager.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
wal_manager.h Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
wal_manager_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
write_batch.cc WriteUnPrepared: Fix assertion during recovery (#6419) 2020-02-13 18:52:05 -08:00
write_batch_base.cc
write_batch_internal.h
write_batch_test.cc
write_callback.h
write_callback_test.cc
write_controller.cc
write_controller.h
write_controller_test.cc
write_thread.cc db/write_thread.cc: Initialize state (#6275) 2020-02-07 15:20:38 -08:00
write_thread.h