mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 20:43:57 +00:00
501543573a
Summary: include "include/rocksdb/blah.h" is messing up some internal builds vs. include "rocksdb/blah." This fixes the bad case and adds a check for future instances. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10213 Test Plan: back-port to 7.4 release candidate and watch internal build Reviewed By: hx235 Differential Revision: D37296202 Pulled By: pdillinger fbshipit-source-id: d7cc6b2c57d858dff0444f19320d83c8b4f9b185
49 lines
1.3 KiB
Bash
Executable file
49 lines
1.3 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
|
#
|
|
# Check for some simple mistakes that should prevent commit or push
|
|
|
|
BAD=""
|
|
|
|
git grep -n 'namespace rocksdb' -- '*.[ch]*'
|
|
if [ "$?" != "1" ]; then
|
|
echo "^^^^^ Do not hardcode namespace rocksdb. Use ROCKSDB_NAMESPACE"
|
|
BAD=1
|
|
fi
|
|
|
|
git grep -n -i 'nocommit' -- ':!build_tools/check-sources.sh'
|
|
if [ "$?" != "1" ]; then
|
|
echo "^^^^^ Code was not intended to be committed"
|
|
BAD=1
|
|
fi
|
|
|
|
git grep -n 'include <rocksdb/' -- ':!build_tools/check-sources.sh'
|
|
if [ "$?" != "1" ]; then
|
|
echo '^^^^^ Use double-quotes as in #include "rocksdb/something.h"'
|
|
BAD=1
|
|
fi
|
|
|
|
git grep -n 'include "include/rocksdb/' -- ':!build_tools/check-sources.sh'
|
|
if [ "$?" != "1" ]; then
|
|
echo '^^^^^ Use #include "rocksdb/something.h" instead of #include "include/rocksdb/something.h"'
|
|
BAD=1
|
|
fi
|
|
|
|
git grep -n 'using namespace' -- ':!build_tools' ':!docs' \
|
|
':!third-party/folly/folly/lang/Align.h' \
|
|
':!third-party/gtest-1.8.1/fused-src/gtest/gtest.h'
|
|
if [ "$?" != "1" ]; then
|
|
echo '^^^^ Do not use "using namespace"'
|
|
BAD=1
|
|
fi
|
|
|
|
git grep -n -P "[\x80-\xFF]" -- ':!docs' ':!*.md'
|
|
if [ "$?" != "1" ]; then
|
|
echo '^^^^ Use only ASCII characters in source files'
|
|
BAD=1
|
|
fi
|
|
|
|
if [ "$BAD" ]; then
|
|
exit 1
|
|
fi
|