mirror of https://github.com/facebook/rocksdb.git
b00761eea6
Summary: Since we do not evict a file's blocks from block cache before that file is deleted, we require a file's cache ID prefix is both unique and non-reusable. However, the Windows functionality we were relying on only guaranteed uniqueness. That meant a newly created file could be assigned the same cache ID prefix as a deleted file. If the newly created file had block offsets matching the deleted file, full cache keys could be exactly the same, resulting in obsolete data blocks returned from cache when trying to read from the new file. We noticed this when running on FAT32 where compaction was writing out of order keys due to reading obsolete blocks from its input files. The functionality is documented as behaving the same on NTFS, although I wasn't able to repro it there. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5844 Test Plan: we had a reliable repro of out-of-order keys on FAT32 that was fixed by this change Differential Revision: D17752442 fbshipit-source-id: 95d983f9196cf415f269e19293b97341edbf7e00 |
||
|---|---|---|
| .. | ||
| block_cache_tier.cc | ||
| block_cache_tier.h | ||
| block_cache_tier_file.cc | ||
| block_cache_tier_file.h | ||
| block_cache_tier_file_buffer.h | ||
| block_cache_tier_metadata.cc | ||
| block_cache_tier_metadata.h | ||
| hash_table.h | ||
| hash_table_bench.cc | ||
| hash_table_evictable.h | ||
| hash_table_test.cc | ||
| lrulist.h | ||
| persistent_cache_bench.cc | ||
| persistent_cache_test.cc | ||
| persistent_cache_test.h | ||
| persistent_cache_tier.cc | ||
| persistent_cache_tier.h | ||
| persistent_cache_util.h | ||
| volatile_tier_impl.cc | ||
| volatile_tier_impl.h | ||