mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
06e593376c
Summary: ## Context/Summary Similar to https://github.com/facebook/rocksdb/pull/11288, https://github.com/facebook/rocksdb/pull/11444, categorizing SST/blob file write according to different io activities allows more insight into the activity. For that, this PR does the following: - Tag different write IOs by passing down and converting WriteOptions to IOOptions - Add new SST_WRITE_MICROS histogram in WritableFileWriter::Append() and breakdown FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS Some related code refactory to make implementation cleaner: - Blob stats - Replace high-level write measurement with low-level WritableFileWriter::Append() measurement for BLOB_DB_BLOB_FILE_WRITE_MICROS. This is to make FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS include blob file. As a consequence, this introduces some behavioral changes on it, see HISTORY and db bench test plan below for more info. - Fix bugs where BLOB_DB_BLOB_FILE_SYNCED/BLOB_DB_BLOB_FILE_BYTES_WRITTEN include file failed to sync and bytes failed to write. - Refactor WriteOptions constructor for easier construction with io_activity and rate_limiter_priority - Refactor DBImpl::~DBImpl()/BlobDBImpl::Close() to bypass thread op verification - Build table - TableBuilderOptions now includes Read/WriteOpitons so BuildTable() do not need to take these two variables - Replace the io_priority passed into BuildTable() with TableBuilderOptions::WriteOpitons::rate_limiter_priority. Similar for BlobFileBuilder. This parameter is used for dynamically changing file io priority for flush, see https://github.com/facebook/rocksdb/pull/9988?fbclid=IwAR1DtKel6c-bRJAdesGo0jsbztRtciByNlvokbxkV6h_L-AE9MACzqRTT5s for more - Update ThreadStatus::FLUSH_BYTES_WRITTEN to use io_activity to track flush IO in flush job and db open instead of io_priority ## Test ### db bench Flush ``` ./db_bench --statistics=1 --benchmarks=fillseq --num=100000 --write_buffer_size=100 rocksdb.sst.write.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377 rocksdb.file.write.flush.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377 rocksdb.file.write.compaction.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 rocksdb.file.write.db.open.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 ``` compaction, db oopen ``` Setup: ./db_bench --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench Run:./db_bench --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1 rocksdb.sst.write.micros P50 : 2.675325 P95 : 9.578788 P99 : 18.780000 P100 : 314.000000 COUNT : 638 SUM : 3279 rocksdb.file.write.flush.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 rocksdb.file.write.compaction.micros P50 : 2.757353 P95 : 9.610687 P99 : 19.316667 P100 : 314.000000 COUNT : 615 SUM : 3213 rocksdb.file.write.db.open.micros P50 : 2.055556 P95 : 3.925000 P99 : 9.000000 P100 : 9.000000 COUNT : 23 SUM : 66 ``` blob stats - just to make sure they aren't broken by this PR ``` Integrated Blob DB Setup: ./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench Run:./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1 pre-PR: rocksdb.blobdb.blob.file.write.micros P50 : 7.298246 P95 : 9.771930 P99 : 9.991813 P100 : 16.000000 COUNT : 235 SUM : 1600 rocksdb.blobdb.blob.file.synced COUNT : 1 rocksdb.blobdb.blob.file.bytes.written COUNT : 34842 post-PR: rocksdb.blobdb.blob.file.write.micros P50 : 2.000000 P95 : 2.829360 P99 : 2.993779 P100 : 9.000000 COUNT : 707 SUM : 1614 - COUNT is higher and values are smaller as it includes header and footer write - COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164 rocksdb.blobdb.blob.file.synced COUNT : 1 (stay the same) rocksdb.blobdb.blob.file.bytes.written COUNT : 34842 (stay the same) ``` ``` Stacked Blob DB Run: ./db_bench --use_blob_db=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench pre-PR: rocksdb.blobdb.blob.file.write.micros P50 : 12.808042 P95 : 19.674497 P99 : 28.539683 P100 : 51.000000 COUNT : 10000 SUM : 140876 rocksdb.blobdb.blob.file.synced COUNT : 8 rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445 post-PR: rocksdb.blobdb.blob.file.write.micros P50 : 1.657370 P95 : 2.952175 P99 : 3.877519 P100 : 24.000000 COUNT : 30001 SUM : 67924 - COUNT is higher and values are smaller as it includes header and footer write - COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164 rocksdb.blobdb.blob.file.synced COUNT : 8 (stay the same) rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445 (stay the same) ``` ### Rehearsal CI stress test Trigger 3 full runs of all our CI stress tests ### Performance Flush ``` TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=ManualFlush/key_num:524288/per_key_size:256 --benchmark_repetitions=1000 -- default: 1 thread is used to run benchmark; enable_statistics = true Pre-pr: avg 507515519.3 ns 497686074,499444327,500862543,501389862,502994471,503744435,504142123,504224056,505724198,506610393,506837742,506955122,507695561,507929036,508307733,508312691,508999120,509963561,510142147,510698091,510743096,510769317,510957074,511053311,511371367,511409911,511432960,511642385,511691964,511730908, Post-pr: avg 511971266.5 ns, regressed 0.88% 502744835,506502498,507735420,507929724,508313335,509548582,509994942,510107257,510715603,511046955,511352639,511458478,512117521,512317380,512766303,512972652,513059586,513804934,513808980,514059409,514187369,514389494,514447762,514616464,514622882,514641763,514666265,514716377,514990179,515502408, ``` Compaction ``` TEST_TMPDIR=/dev/shm ./db_basic_bench_{pre|post}_pr --benchmark_filter=ManualCompaction/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1 --benchmark_repetitions=1000 -- default: 1 thread is used to run benchmark Pre-pr: avg 495346098.30 ns 492118301,493203526,494201411,494336607,495269217,495404950,496402598,497012157,497358370,498153846 Post-pr: avg 504528077.20, regressed 1.85%. "ManualCompaction" include flush so the isolated regression for compaction should be around 1.85-0.88 = 0.97% 502465338,502485945,502541789,502909283,503438601,504143885,506113087,506629423,507160414,507393007 ``` Put with WAL (in case passing WriteOptions slows down this path even without collecting SST write stats) ``` TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1 --benchmark_repetitions=1000 -- default: 1 thread is used to run benchmark Pre-pr: avg 3848.10 ns 3814,3838,3839,3848,3854,3854,3854,3860,3860,3860 Post-pr: avg 3874.20 ns, regressed 0.68% 3863,3867,3871,3874,3875,3877,3877,3877,3880,3881 ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/11910 Reviewed By: ajkr Differential Revision: D49788060 Pulled By: hx235 fbshipit-source-id: 79e73699cda5be3b66461687e5147c2484fc5eff
338 lines
13 KiB
C++
338 lines
13 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
#include <atomic>
|
|
#include <string>
|
|
|
|
#include "db/version_edit.h"
|
|
#include "env/file_system_tracer.h"
|
|
#include "monitoring/thread_status_util.h"
|
|
#include "port/port.h"
|
|
#include "rocksdb/file_checksum.h"
|
|
#include "rocksdb/file_system.h"
|
|
#include "rocksdb/io_status.h"
|
|
#include "rocksdb/listener.h"
|
|
#include "rocksdb/rate_limiter.h"
|
|
#include "test_util/sync_point.h"
|
|
#include "util/aligned_buffer.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
class Statistics;
|
|
class SystemClock;
|
|
|
|
// WritableFileWriter is a wrapper on top of Env::WritableFile. It provides
|
|
// facilities to:
|
|
// - Handle Buffered and Direct writes.
|
|
// - Rate limit writes.
|
|
// - Flush and Sync the data to the underlying filesystem.
|
|
// - Notify any interested listeners on the completion of a write.
|
|
// - Update IO stats.
|
|
class WritableFileWriter {
|
|
private:
|
|
void NotifyOnFileWriteFinish(
|
|
uint64_t offset, size_t length,
|
|
const FileOperationInfo::StartTimePoint& start_ts,
|
|
const FileOperationInfo::FinishTimePoint& finish_ts,
|
|
const IOStatus& io_status) {
|
|
FileOperationInfo info(FileOperationType::kWrite, file_name_, start_ts,
|
|
finish_ts, io_status, temperature_);
|
|
info.offset = offset;
|
|
info.length = length;
|
|
|
|
for (auto& listener : listeners_) {
|
|
listener->OnFileWriteFinish(info);
|
|
}
|
|
info.status.PermitUncheckedError();
|
|
}
|
|
void NotifyOnFileFlushFinish(
|
|
const FileOperationInfo::StartTimePoint& start_ts,
|
|
const FileOperationInfo::FinishTimePoint& finish_ts,
|
|
const IOStatus& io_status) {
|
|
FileOperationInfo info(FileOperationType::kFlush, file_name_, start_ts,
|
|
finish_ts, io_status, temperature_);
|
|
|
|
for (auto& listener : listeners_) {
|
|
listener->OnFileFlushFinish(info);
|
|
}
|
|
info.status.PermitUncheckedError();
|
|
}
|
|
void NotifyOnFileSyncFinish(
|
|
const FileOperationInfo::StartTimePoint& start_ts,
|
|
const FileOperationInfo::FinishTimePoint& finish_ts,
|
|
const IOStatus& io_status,
|
|
FileOperationType type = FileOperationType::kSync) {
|
|
FileOperationInfo info(type, file_name_, start_ts, finish_ts, io_status,
|
|
temperature_);
|
|
|
|
for (auto& listener : listeners_) {
|
|
listener->OnFileSyncFinish(info);
|
|
}
|
|
info.status.PermitUncheckedError();
|
|
}
|
|
void NotifyOnFileRangeSyncFinish(
|
|
uint64_t offset, size_t length,
|
|
const FileOperationInfo::StartTimePoint& start_ts,
|
|
const FileOperationInfo::FinishTimePoint& finish_ts,
|
|
const IOStatus& io_status) {
|
|
FileOperationInfo info(FileOperationType::kRangeSync, file_name_, start_ts,
|
|
finish_ts, io_status, temperature_);
|
|
info.offset = offset;
|
|
info.length = length;
|
|
|
|
for (auto& listener : listeners_) {
|
|
listener->OnFileRangeSyncFinish(info);
|
|
}
|
|
info.status.PermitUncheckedError();
|
|
}
|
|
void NotifyOnFileTruncateFinish(
|
|
const FileOperationInfo::StartTimePoint& start_ts,
|
|
const FileOperationInfo::FinishTimePoint& finish_ts,
|
|
const IOStatus& io_status) {
|
|
FileOperationInfo info(FileOperationType::kTruncate, file_name_, start_ts,
|
|
finish_ts, io_status, temperature_);
|
|
|
|
for (auto& listener : listeners_) {
|
|
listener->OnFileTruncateFinish(info);
|
|
}
|
|
info.status.PermitUncheckedError();
|
|
}
|
|
void NotifyOnFileCloseFinish(
|
|
const FileOperationInfo::StartTimePoint& start_ts,
|
|
const FileOperationInfo::FinishTimePoint& finish_ts,
|
|
const IOStatus& io_status) {
|
|
FileOperationInfo info(FileOperationType::kClose, file_name_, start_ts,
|
|
finish_ts, io_status, temperature_);
|
|
|
|
for (auto& listener : listeners_) {
|
|
listener->OnFileCloseFinish(info);
|
|
}
|
|
info.status.PermitUncheckedError();
|
|
}
|
|
|
|
void NotifyOnIOError(const IOStatus& io_status, FileOperationType operation,
|
|
const std::string& file_path, size_t length = 0,
|
|
uint64_t offset = 0) {
|
|
if (listeners_.empty()) {
|
|
return;
|
|
}
|
|
IOErrorInfo io_error_info(io_status, operation, file_path, length, offset);
|
|
for (auto& listener : listeners_) {
|
|
listener->OnIOError(io_error_info);
|
|
}
|
|
io_error_info.io_status.PermitUncheckedError();
|
|
}
|
|
|
|
bool ShouldNotifyListeners() const { return !listeners_.empty(); }
|
|
void UpdateFileChecksum(const Slice& data);
|
|
void Crc32cHandoffChecksumCalculation(const char* data, size_t size,
|
|
char* buf);
|
|
|
|
std::string file_name_;
|
|
FSWritableFilePtr writable_file_;
|
|
SystemClock* clock_;
|
|
AlignedBuffer buf_;
|
|
size_t max_buffer_size_;
|
|
// Actually written data size can be used for truncate
|
|
// not counting padding data
|
|
std::atomic<uint64_t> filesize_;
|
|
std::atomic<uint64_t> flushed_size_;
|
|
// This is necessary when we use unbuffered access
|
|
// and writes must happen on aligned offsets
|
|
// so we need to go back and write that page again
|
|
uint64_t next_write_offset_;
|
|
bool pending_sync_;
|
|
std::atomic<bool> seen_error_;
|
|
#ifndef NDEBUG
|
|
// SyncWithoutFlush() is the function that is allowed to be called
|
|
// concurrently with other function. One of the concurrent call
|
|
// could set seen_error_, and the other one would hit assertion
|
|
// in debug mode.
|
|
std::atomic<bool> sync_without_flush_called_ = false;
|
|
#endif // NDEBUG
|
|
uint64_t last_sync_size_;
|
|
uint64_t bytes_per_sync_;
|
|
RateLimiter* rate_limiter_;
|
|
Statistics* stats_;
|
|
Histograms hist_type_;
|
|
std::vector<std::shared_ptr<EventListener>> listeners_;
|
|
std::unique_ptr<FileChecksumGenerator> checksum_generator_;
|
|
bool checksum_finalized_;
|
|
bool perform_data_verification_;
|
|
uint32_t buffered_data_crc32c_checksum_;
|
|
bool buffered_data_with_checksum_;
|
|
Temperature temperature_;
|
|
|
|
public:
|
|
WritableFileWriter(
|
|
std::unique_ptr<FSWritableFile>&& file, const std::string& _file_name,
|
|
const FileOptions& options, SystemClock* clock = nullptr,
|
|
const std::shared_ptr<IOTracer>& io_tracer = nullptr,
|
|
Statistics* stats = nullptr,
|
|
Histograms hist_type = Histograms::HISTOGRAM_ENUM_MAX,
|
|
const std::vector<std::shared_ptr<EventListener>>& listeners = {},
|
|
FileChecksumGenFactory* file_checksum_gen_factory = nullptr,
|
|
bool perform_data_verification = false,
|
|
bool buffered_data_with_checksum = false)
|
|
: file_name_(_file_name),
|
|
writable_file_(std::move(file), io_tracer, _file_name),
|
|
clock_(clock),
|
|
buf_(),
|
|
max_buffer_size_(options.writable_file_max_buffer_size),
|
|
filesize_(0),
|
|
flushed_size_(0),
|
|
next_write_offset_(0),
|
|
pending_sync_(false),
|
|
seen_error_(false),
|
|
last_sync_size_(0),
|
|
bytes_per_sync_(options.bytes_per_sync),
|
|
rate_limiter_(options.rate_limiter),
|
|
stats_(stats),
|
|
hist_type_(hist_type),
|
|
listeners_(),
|
|
checksum_generator_(nullptr),
|
|
checksum_finalized_(false),
|
|
perform_data_verification_(perform_data_verification),
|
|
buffered_data_crc32c_checksum_(0),
|
|
buffered_data_with_checksum_(buffered_data_with_checksum) {
|
|
temperature_ = options.temperature;
|
|
assert(!use_direct_io() || max_buffer_size_ > 0);
|
|
TEST_SYNC_POINT_CALLBACK("WritableFileWriter::WritableFileWriter:0",
|
|
reinterpret_cast<void*>(max_buffer_size_));
|
|
buf_.Alignment(writable_file_->GetRequiredBufferAlignment());
|
|
buf_.AllocateNewBuffer(std::min((size_t)65536, max_buffer_size_));
|
|
std::for_each(listeners.begin(), listeners.end(),
|
|
[this](const std::shared_ptr<EventListener>& e) {
|
|
if (e->ShouldBeNotifiedOnFileIO()) {
|
|
listeners_.emplace_back(e);
|
|
}
|
|
});
|
|
if (file_checksum_gen_factory != nullptr) {
|
|
FileChecksumGenContext checksum_gen_context;
|
|
checksum_gen_context.file_name = _file_name;
|
|
checksum_generator_ =
|
|
file_checksum_gen_factory->CreateFileChecksumGenerator(
|
|
checksum_gen_context);
|
|
}
|
|
}
|
|
|
|
static IOStatus Create(const std::shared_ptr<FileSystem>& fs,
|
|
const std::string& fname, const FileOptions& file_opts,
|
|
std::unique_ptr<WritableFileWriter>* writer,
|
|
IODebugContext* dbg);
|
|
|
|
static IOStatus PrepareIOOptions(const WriteOptions& wo, IOOptions& opts);
|
|
|
|
WritableFileWriter(const WritableFileWriter&) = delete;
|
|
|
|
WritableFileWriter& operator=(const WritableFileWriter&) = delete;
|
|
|
|
~WritableFileWriter() {
|
|
ThreadStatus::OperationType cur_op_type =
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
ThreadStatusUtil::SetThreadOperation(
|
|
ThreadStatus::OperationType::OP_UNKNOWN);
|
|
auto s = Close(IOOptions());
|
|
s.PermitUncheckedError();
|
|
ThreadStatusUtil::SetThreadOperation(cur_op_type);
|
|
}
|
|
|
|
std::string file_name() const { return file_name_; }
|
|
|
|
// When this Append API is called, if the crc32c_checksum is not provided, we
|
|
// will calculate the checksum internally.
|
|
IOStatus Append(const IOOptions& opts, const Slice& data,
|
|
uint32_t crc32c_checksum = 0);
|
|
|
|
IOStatus Pad(const IOOptions& opts, const size_t pad_bytes);
|
|
|
|
IOStatus Flush(const IOOptions& opts);
|
|
|
|
IOStatus Close(const IOOptions& opts);
|
|
|
|
IOStatus Sync(const IOOptions& opts, bool use_fsync);
|
|
|
|
// Sync only the data that was already Flush()ed. Safe to call concurrently
|
|
// with Append() and Flush(). If !writable_file_->IsSyncThreadSafe(),
|
|
// returns NotSupported status.
|
|
IOStatus SyncWithoutFlush(const IOOptions& opts, bool use_fsync);
|
|
|
|
uint64_t GetFileSize() const {
|
|
return filesize_.load(std::memory_order_acquire);
|
|
}
|
|
|
|
// Returns the size of data flushed to the underlying `FSWritableFile`.
|
|
// Expected to match `writable_file()->GetFileSize()`.
|
|
// The return value can serve as a lower-bound for the amount of data synced
|
|
// by a future call to `SyncWithoutFlush()`.
|
|
uint64_t GetFlushedSize() const {
|
|
return flushed_size_.load(std::memory_order_acquire);
|
|
}
|
|
|
|
IOStatus InvalidateCache(size_t offset, size_t length) {
|
|
return writable_file_->InvalidateCache(offset, length);
|
|
}
|
|
|
|
FSWritableFile* writable_file() const { return writable_file_.get(); }
|
|
|
|
bool use_direct_io() { return writable_file_->use_direct_io(); }
|
|
|
|
bool BufferIsEmpty() { return buf_.CurrentSize() == 0; }
|
|
|
|
void TEST_SetFileChecksumGenerator(
|
|
FileChecksumGenerator* checksum_generator) {
|
|
checksum_generator_.reset(checksum_generator);
|
|
}
|
|
|
|
std::string GetFileChecksum();
|
|
|
|
const char* GetFileChecksumFuncName() const;
|
|
|
|
bool seen_error() const {
|
|
return seen_error_.load(std::memory_order_relaxed);
|
|
}
|
|
// For options of relaxed consistency, users might hope to continue
|
|
// operating on the file after an error happens.
|
|
void reset_seen_error() {
|
|
seen_error_.store(false, std::memory_order_relaxed);
|
|
}
|
|
void set_seen_error() { seen_error_.store(true, std::memory_order_relaxed); }
|
|
|
|
IOStatus AssertFalseAndGetStatusForPrevError() {
|
|
// This should only happen if SyncWithoutFlush() was called.
|
|
assert(sync_without_flush_called_);
|
|
return IOStatus::IOError("Writer has previous error.");
|
|
}
|
|
|
|
private:
|
|
// Decide the Rate Limiter priority.
|
|
static Env::IOPriority DecideRateLimiterPriority(
|
|
Env::IOPriority writable_file_io_priority,
|
|
Env::IOPriority op_rate_limiter_priority);
|
|
|
|
// Used when os buffering is OFF and we are writing
|
|
// DMA such as in Direct I/O mode
|
|
// `opts` should've been called with `FinalizeIOOptions()` before passing in
|
|
IOStatus WriteDirect(const IOOptions& opts);
|
|
// `opts` should've been called with `FinalizeIOOptions()` before passing in
|
|
IOStatus WriteDirectWithChecksum(const IOOptions& opts);
|
|
// Normal write.
|
|
// `opts` should've been called with `FinalizeIOOptions()` before passing in
|
|
IOStatus WriteBuffered(const IOOptions& opts, const char* data, size_t size);
|
|
// `opts` should've been called with `FinalizeIOOptions()` before passing in
|
|
IOStatus WriteBufferedWithChecksum(const IOOptions& opts, const char* data,
|
|
size_t size);
|
|
// `opts` should've been called with `FinalizeIOOptions()` before passing in
|
|
IOStatus RangeSync(const IOOptions& opts, uint64_t offset, uint64_t nbytes);
|
|
// `opts` should've been called with `FinalizeIOOptions()` before passing in
|
|
IOStatus SyncInternal(const IOOptions& opts, bool use_fsync);
|
|
IOOptions FinalizeIOOptions(const IOOptions& opts) const;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|