mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 20:43:57 +00:00
9a034801ce
Summary:
**Context/Summary:**
- Similar to https://github.com/facebook/rocksdb/pull/11288 but for user read such as `Get(), MultiGet(), DBIterator::XXX(), Verify(File)Checksum()`.
- For this, I refactored some user-facing `MultiGet` calls in `TransactionBase` and various types of `DB` so that it does not call a user-facing `Get()` but `GetImpl()` for passing the `ReadOptions::io_activity` check (see PR conversation)
- New user read stats breakdown are guarded by `kExceptDetailedTimers` since measurement shows they have 4-5% regression to the upstream/main.
- Misc
- More refactoring: with https://github.com/facebook/rocksdb/pull/11288, we complete passing `ReadOptions/IOOptions` to FS level. So we can now replace the previously [added](https://github.com/facebook/rocksdb/pull/9424) `rate_limiter_priority` parameter in `RandomAccessFileReader`'s `Read/MultiRead/Prefetch()` with `IOOptions::rate_limiter_priority`
- Also, `ReadAsync()` call time is measured in `SST_READ_MICRO` now
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11444
Test Plan:
- CI fake db crash/stress test
- Microbenchmarking
**Build** `make clean && ROCKSDB_NO_FBCODE=1 DEBUG_LEVEL=0 make -jN db_basic_bench`
- google benchmark version: 604f6fd3f4
- db_basic_bench_base: upstream
- db_basic_bench_pr: db_basic_bench_base + this PR
- asyncread_db_basic_bench_base: upstream + [db basic bench patch for IteratorNext](https://github.com/facebook/rocksdb/compare/main...hx235:rocksdb:micro_bench_async_read)
- asyncread_db_basic_bench_pr: asyncread_db_basic_bench_base + this PR
**Test**
Get
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_{null_stat|base|pr} --benchmark_filter=DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/negative_query:0/enable_filter:0/mmap:1/threads:1 --benchmark_repetitions=1000
```
Result
```
Coming soon
```
AsyncRead
```
TEST_TMPDIR=/dev/shm ./asyncread_db_basic_bench_{base|pr} --benchmark_filter=IteratorNext/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/async_io:1/include_detailed_timers:0 --benchmark_repetitions=1000 > syncread_db_basic_bench_{base|pr}.out
```
Result
```
Base:
1956,1956,1968,1977,1979,1986,1988,1988,1988,1990,1991,1991,1993,1993,1993,1993,1994,1996,1997,1997,1997,1998,1999,2001,2001,2002,2004,2007,2007,2008,
PR (2.3% regression, due to measuring `SST_READ_MICRO` that wasn't measured before):
1993,2014,2016,2022,2024,2027,2027,2028,2028,2030,2031,2031,2032,2032,2038,2039,2042,2044,2044,2047,2047,2047,2048,2049,2050,2052,2052,2052,2053,2053,
```
Reviewed By: ajkr
Differential Revision: D45918925
Pulled By: hx235
fbshipit-source-id: 58a54560d9ebeb3a59b6d807639692614dad058a
112 lines
4.3 KiB
C++
112 lines
4.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cinttypes>
|
|
#include <memory>
|
|
|
|
#include "db/blob/blob_read_request.h"
|
|
#include "file/random_access_file_reader.h"
|
|
#include "rocksdb/compression_type.h"
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
#include "util/autovector.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class Status;
|
|
struct ImmutableOptions;
|
|
struct FileOptions;
|
|
class HistogramImpl;
|
|
struct ReadOptions;
|
|
class Slice;
|
|
class FilePrefetchBuffer;
|
|
class BlobContents;
|
|
class Statistics;
|
|
|
|
class BlobFileReader {
|
|
public:
|
|
static Status Create(const ImmutableOptions& immutable_options,
|
|
const ReadOptions& read_options,
|
|
const FileOptions& file_options,
|
|
uint32_t column_family_id,
|
|
HistogramImpl* blob_file_read_hist,
|
|
uint64_t blob_file_number,
|
|
const std::shared_ptr<IOTracer>& io_tracer,
|
|
std::unique_ptr<BlobFileReader>* reader);
|
|
|
|
BlobFileReader(const BlobFileReader&) = delete;
|
|
BlobFileReader& operator=(const BlobFileReader&) = delete;
|
|
|
|
~BlobFileReader();
|
|
|
|
Status GetBlob(const ReadOptions& read_options, const Slice& user_key,
|
|
uint64_t offset, uint64_t value_size,
|
|
CompressionType compression_type,
|
|
FilePrefetchBuffer* prefetch_buffer,
|
|
MemoryAllocator* allocator,
|
|
std::unique_ptr<BlobContents>* result,
|
|
uint64_t* bytes_read) const;
|
|
|
|
// offsets must be sorted in ascending order by caller.
|
|
void MultiGetBlob(
|
|
const ReadOptions& read_options, MemoryAllocator* allocator,
|
|
autovector<std::pair<BlobReadRequest*, std::unique_ptr<BlobContents>>>&
|
|
blob_reqs,
|
|
uint64_t* bytes_read) const;
|
|
|
|
CompressionType GetCompressionType() const { return compression_type_; }
|
|
|
|
uint64_t GetFileSize() const { return file_size_; }
|
|
|
|
private:
|
|
BlobFileReader(std::unique_ptr<RandomAccessFileReader>&& file_reader,
|
|
uint64_t file_size, CompressionType compression_type,
|
|
SystemClock* clock, Statistics* statistics);
|
|
|
|
static Status OpenFile(const ImmutableOptions& immutable_options,
|
|
const FileOptions& file_opts,
|
|
HistogramImpl* blob_file_read_hist,
|
|
uint64_t blob_file_number,
|
|
const std::shared_ptr<IOTracer>& io_tracer,
|
|
uint64_t* file_size,
|
|
std::unique_ptr<RandomAccessFileReader>* file_reader);
|
|
|
|
static Status ReadHeader(const RandomAccessFileReader* file_reader,
|
|
const ReadOptions& read_options,
|
|
uint32_t column_family_id, Statistics* statistics,
|
|
CompressionType* compression_type);
|
|
|
|
static Status ReadFooter(const RandomAccessFileReader* file_reader,
|
|
const ReadOptions& read_options, uint64_t file_size,
|
|
Statistics* statistics);
|
|
|
|
using Buffer = std::unique_ptr<char[]>;
|
|
|
|
static Status ReadFromFile(const RandomAccessFileReader* file_reader,
|
|
const ReadOptions& read_options,
|
|
uint64_t read_offset, size_t read_size,
|
|
Statistics* statistics, Slice* slice, Buffer* buf,
|
|
AlignedBuf* aligned_buf);
|
|
|
|
static Status VerifyBlob(const Slice& record_slice, const Slice& user_key,
|
|
uint64_t value_size);
|
|
|
|
static Status UncompressBlobIfNeeded(const Slice& value_slice,
|
|
CompressionType compression_type,
|
|
MemoryAllocator* allocator,
|
|
SystemClock* clock,
|
|
Statistics* statistics,
|
|
std::unique_ptr<BlobContents>* result);
|
|
|
|
std::unique_ptr<RandomAccessFileReader> file_reader_;
|
|
uint64_t file_size_;
|
|
CompressionType compression_type_;
|
|
SystemClock* clock_;
|
|
Statistics* statistics_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|