mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 13:41:46 +00:00
21db55f816
Summary: **Context/Summary:** WAL sync currently happens after memtable write. This causes inconvenience in stress test as we can't simply rollback the ExpectedState when write fails due to injected WAL sync error so something complicated like https://github.com/facebook/rocksdb/pull/12838 might be needed. After moving WAL sync before memtable insertion, there should not be injected IO error after memtable insertion so we can keep the current simple way of handling failed write in stress test with ExpectedState rollback. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12869 Test Plan: 1. Below command failed with `iterator has key 0000000000000207000000000000012B0000000000000013, but expected state does not.` before this PR and passes after ``` ./db_stress --WAL_size_limit_MB=0 --WAL_ttl_seconds=0 --acquire_snapshot_one_in=10000 --adaptive_readahead=1 --adm_policy=1 --advise_random_on_open=0 --allow_concurrent_memtable_write=0 --allow_data_in_errors=True --allow_fallocate=0 --async_io=0 --auto_readahead_size=0 --avoid_flush_during_recovery=0 --avoid_flush_during_shutdown=0 --avoid_unnecessary_blocking_io=0 --backup_max_size=104857600 --backup_one_in=0 --batch_protection_bytes_per_key=0 --bgerror_resume_retry_interval=1000000 --block_align=1 --block_protection_bytes_per_key=4 --block_size=16384 --bloom_before_level=4 --bloom_bits=56.810257702625165 --bottommost_compression_type=none --bottommost_file_compaction_delay=0 --bytes_per_sync=262144 --cache_index_and_filter_blocks=1 --cache_index_and_filter_blocks_with_high_priority=1 --cache_size=8388608 --cache_type=auto_hyper_clock_cache --charge_compression_dictionary_building_buffer=1 --charge_file_metadata=1 --charge_filter_construction=1 --charge_table_reader=0 --check_multiget_consistency=0 --check_multiget_entity_consistency=1 --checkpoint_one_in=10000 --checksum_type=kxxHash --clear_column_family_one_in=0 --column_families=1 --compact_files_one_in=1000 --compact_range_one_in=1000 --compaction_pri=4 --compaction_readahead_size=1048576 --compaction_ttl=10 --compress_format_version=1 --compressed_secondary_cache_ratio=0.0 --compressed_secondary_cache_size=0 --compression_checksum=0 --compression_max_dict_buffer_bytes=0 --compression_max_dict_bytes=0 --compression_parallel_threads=1 --compression_type=none --compression_use_zstd_dict_trainer=0 --compression_zstd_max_train_bytes=0 --continuous_verification_interval=0 --daily_offpeak_time_utc=04:00-08:00 --data_block_index_type=1 --db=/dev/shm/rocksdb_test/rocksdb_crashtest_blackbox --db_write_buffer_size=0 --default_temperature=kWarm --default_write_temperature=kCold --delete_obsolete_files_period_micros=30000000 --delpercent=0 --delrangepercent=0 --destroy_db_initially=0 --detect_filter_construct_corruption=0 --disable_file_deletions_one_in=10000 --disable_manual_compaction_one_in=1000000 --disable_wal=0 --dump_malloc_stats=0 --enable_checksum_handoff=1 --enable_compaction_filter=0 --enable_custom_split_merge=0 --enable_do_not_compress_roles=0 --enable_index_compression=1 --enable_memtable_insert_with_hint_prefix_extractor=0 --enable_pipelined_write=0 --enable_sst_partitioner_factory=0 --enable_thread_tracking=0 --enable_write_thread_adaptive_yield=0 --error_recovery_with_no_fault_injection=1 --exclude_wal_from_write_fault_injection=1 --expected_values_dir=/dev/shm/rocksdb_test/rocksdb_crashtest_expected --fail_if_options_file_error=1 --fifo_allow_compaction=0 --file_checksum_impl=crc32c --fill_cache=1 --flush_one_in=1000000 --format_version=3 --get_all_column_family_metadata_one_in=1000000 --get_current_wal_file_one_in=0 --get_live_files_apis_one_in=1000000 --get_properties_of_all_tables_one_in=1000000 --get_property_one_in=100000 --get_sorted_wal_files_one_in=0 --hard_pending_compaction_bytes_limit=274877906944 --high_pri_pool_ratio=0.5 --index_block_restart_interval=4 --index_shortening=2 --index_type=0 --ingest_external_file_one_in=0 --initial_auto_readahead_size=16384 --inplace_update_support=0 --iterpercent=50 --key_len_percent_dist=1,30,69 --key_may_exist_one_in=100 --last_level_temperature=kWarm --level_compaction_dynamic_level_bytes=1 --lock_wal_one_in=10000 --log_file_time_to_roll=60 --log_readahead_size=16777216 --long_running_snapshots=1 --low_pri_pool_ratio=0 --lowest_used_cache_tier=0 --manifest_preallocation_size=0 --manual_wal_flush_one_in=0 --mark_for_compaction_one_file_in=10 --max_auto_readahead_size=16384 --max_background_compactions=1 --max_bytes_for_level_base=67108864 --max_key=100000 --max_key_len=3 --max_log_file_size=1048576 --max_manifest_file_size=32768 --max_sequential_skip_in_iterations=1 --max_total_wal_size=0 --max_write_batch_group_size_bytes=16 --max_write_buffer_number=10 --max_write_buffer_size_to_maintain=8388608 --memtable_insert_hint_per_batch=1 --memtable_max_range_deletions=0 --memtable_prefix_bloom_size_ratio=0.01 --memtable_protection_bytes_per_key=1 --memtable_whole_key_filtering=1 --memtablerep=skip_list --metadata_charge_policy=1 --metadata_read_fault_one_in=32 --metadata_write_fault_one_in=0 --min_write_buffer_number_to_merge=1 --mmap_read=1 --mock_direct_io=False --nooverwritepercent=1 --num_file_reads_for_auto_readahead=1 --open_files=-1 --open_metadata_read_fault_one_in=0 --open_metadata_write_fault_one_in=0 --open_read_fault_one_in=0 --open_write_fault_one_in=0 --ops_per_thread=100000000 --optimize_filters_for_hits=1 --optimize_filters_for_memory=1 --optimize_multiget_for_io=1 --paranoid_file_checks=0 --partition_filters=0 --partition_pinning=3 --pause_background_one_in=1000000 --periodic_compaction_seconds=2 --prefix_size=7 --prefixpercent=0 --prepopulate_block_cache=0 --preserve_internal_time_seconds=0 --progress_reports=0 --promote_l0_one_in=0 --read_amp_bytes_per_bit=0 --read_fault_one_in=1000 --readahead_size=524288 --readpercent=0 --recycle_log_file_num=1 --reopen=0 --report_bg_io_stats=0 --reset_stats_one_in=1000000 --sample_for_compression=0 --secondary_cache_fault_one_in=0 --set_options_one_in=0 --skip_stats_update_on_db_open=1 --snapshot_hold_ops=100000 --soft_pending_compaction_bytes_limit=68719476736 --sqfc_name=foo --sqfc_version=0 --sst_file_manager_bytes_per_sec=104857600 --sst_file_manager_bytes_per_truncate=0 --stats_dump_period_sec=10 --stats_history_buffer_size=0 --strict_bytes_per_sync=1 --subcompactions=4 --sync=1 --sync_fault_injection=0 --table_cache_numshardbits=6 --target_file_size_base=16777216 --target_file_size_multiplier=1 --test_batches_snapshots=0 --top_level_index_pinning=2 --uncache_aggressiveness=239 --universal_max_read_amp=-1 --unpartitioned_pinning=1 --use_adaptive_mutex=1 --use_adaptive_mutex_lru=1 --use_attribute_group=0 --use_delta_encoding=0 --use_direct_io_for_flush_and_compaction=0 --use_direct_reads=0 --use_full_merge_v1=0 --use_get_entity=0 --use_merge=0 --use_multi_cf_iterator=0 --use_multi_get_entity=0 --use_multiget=0 --use_put_entity_one_in=0 --use_sqfc_for_range_queries=1 --use_timed_put_one_in=0 --use_write_buffer_manager=0 --user_timestamp_size=0 --value_size_mult=32 --verification_only=0 --verify_checksum=1 --verify_checksum_one_in=1000000 --verify_compression=0 --verify_db_one_in=100000 --verify_file_checksums_one_in=1000000 --verify_iterator_with_expected_state_one_in=5 --verify_sst_unique_id_in_manifest=1 --wal_bytes_per_sync=0 --wal_compression=none --write_buffer_size=33554432 --write_dbid_to_manifest=0 --write_fault_one_in=128 --writepercent=50 Reviewed By: jowlyzhang Differential Revision: D59825730 Pulled By: hx235 fbshipit-source-id: 7d77aaf177ded2f99bf1ce19f5a4bd0783b9ca92 |
||
|---|---|---|
| .. | ||
| blob | ||
| compaction | ||
| db_impl | ||
| wide | ||
| arena_wrapped_db_iter.cc | ||
| arena_wrapped_db_iter.h | ||
| attribute_group_iterator_impl.cc | ||
| attribute_group_iterator_impl.h | ||
| builder.cc | ||
| builder.h | ||
| c.cc | ||
| c_test.c | ||
| coalescing_iterator.cc | ||
| coalescing_iterator.h | ||
| column_family.cc | ||
| column_family.h | ||
| column_family_test.cc | ||
| compact_files_test.cc | ||
| comparator_db_test.cc | ||
| convenience.cc | ||
| convenience_impl.h | ||
| corruption_test.cc | ||
| cuckoo_table_db_test.cc | ||
| db_basic_test.cc | ||
| db_block_cache_test.cc | ||
| db_bloom_filter_test.cc | ||
| db_clip_test.cc | ||
| db_compaction_filter_test.cc | ||
| db_compaction_test.cc | ||
| db_dynamic_level_test.cc | ||
| db_encryption_test.cc | ||
| db_filesnapshot.cc | ||
| db_flush_test.cc | ||
| db_follower_test.cc | ||
| db_info_dumper.cc | ||
| db_info_dumper.h | ||
| db_inplace_update_test.cc | ||
| db_io_failure_test.cc | ||
| db_iter.cc | ||
| db_iter.h | ||
| db_iter_stress_test.cc | ||
| db_iter_test.cc | ||
| db_iterator_test.cc | ||
| db_kv_checksum_test.cc | ||
| db_log_iter_test.cc | ||
| db_logical_block_size_cache_test.cc | ||
| db_memtable_test.cc | ||
| db_merge_operand_test.cc | ||
| db_merge_operator_test.cc | ||
| db_options_test.cc | ||
| db_properties_test.cc | ||
| db_range_del_test.cc | ||
| db_rate_limiter_test.cc | ||
| db_readonly_with_timestamp_test.cc | ||
| db_secondary_test.cc | ||
| db_sst_test.cc | ||
| db_statistics_test.cc | ||
| db_table_properties_test.cc | ||
| db_tailing_iter_test.cc | ||
| db_test.cc | ||
| db_test2.cc | ||
| db_test_util.cc | ||
| db_test_util.h | ||
| db_universal_compaction_test.cc | ||
| db_wal_test.cc | ||
| db_with_timestamp_basic_test.cc | ||
| db_with_timestamp_compaction_test.cc | ||
| db_with_timestamp_test_util.cc | ||
| db_with_timestamp_test_util.h | ||
| db_write_buffer_manager_test.cc | ||
| db_write_test.cc | ||
| dbformat.cc | ||
| dbformat.h | ||
| dbformat_test.cc | ||
| deletefile_test.cc | ||
| error_handler.cc | ||
| error_handler.h | ||
| error_handler_fs_test.cc | ||
| event_helpers.cc | ||
| event_helpers.h | ||
| experimental.cc | ||
| external_sst_file_basic_test.cc | ||
| external_sst_file_ingestion_job.cc | ||
| external_sst_file_ingestion_job.h | ||
| external_sst_file_test.cc | ||
| fault_injection_test.cc | ||
| file_indexer.cc | ||
| file_indexer.h | ||
| file_indexer_test.cc | ||
| filename_test.cc | ||
| flush_job.cc | ||
| flush_job.h | ||
| flush_job_test.cc | ||
| flush_scheduler.cc | ||
| flush_scheduler.h | ||
| forward_iterator.cc | ||
| forward_iterator.h | ||
| forward_iterator_bench.cc | ||
| history_trimming_iterator.h | ||
| import_column_family_job.cc | ||
| import_column_family_job.h | ||
| import_column_family_test.cc | ||
| internal_stats.cc | ||
| internal_stats.h | ||
| job_context.h | ||
| kv_checksum.h | ||
| listener_test.cc | ||
| log_format.h | ||
| log_reader.cc | ||
| log_reader.h | ||
| log_test.cc | ||
| log_writer.cc | ||
| log_writer.h | ||
| logs_with_prep_tracker.cc | ||
| logs_with_prep_tracker.h | ||
| lookup_key.h | ||
| malloc_stats.cc | ||
| malloc_stats.h | ||
| manual_compaction_test.cc | ||
| memtable.cc | ||
| memtable.h | ||
| memtable_list.cc | ||
| memtable_list.h | ||
| memtable_list_test.cc | ||
| merge_context.h | ||
| merge_helper.cc | ||
| merge_helper.h | ||
| merge_helper_test.cc | ||
| merge_operator.cc | ||
| merge_test.cc | ||
| multi_cf_iterator_impl.h | ||
| multi_cf_iterator_test.cc | ||
| obsolete_files_test.cc | ||
| options_file_test.cc | ||
| output_validator.cc | ||
| output_validator.h | ||
| perf_context_test.cc | ||
| periodic_task_scheduler.cc | ||
| periodic_task_scheduler.h | ||
| periodic_task_scheduler_test.cc | ||
| pinned_iterators_manager.h | ||
| plain_table_db_test.cc | ||
| post_memtable_callback.h | ||
| pre_release_callback.h | ||
| prefix_test.cc | ||
| range_del_aggregator.cc | ||
| range_del_aggregator.h | ||
| range_del_aggregator_bench.cc | ||
| range_del_aggregator_test.cc | ||
| range_tombstone_fragmenter.cc | ||
| range_tombstone_fragmenter.h | ||
| range_tombstone_fragmenter_test.cc | ||
| read_callback.h | ||
| repair.cc | ||
| repair_test.cc | ||
| seqno_time_test.cc | ||
| seqno_to_time_mapping.cc | ||
| seqno_to_time_mapping.h | ||
| snapshot_checker.h | ||
| snapshot_impl.cc | ||
| snapshot_impl.h | ||
| table_cache.cc | ||
| table_cache.h | ||
| table_cache_sync_and_async.h | ||
| table_properties_collector.cc | ||
| table_properties_collector.h | ||
| table_properties_collector_test.cc | ||
| transaction_log_impl.cc | ||
| transaction_log_impl.h | ||
| trim_history_scheduler.cc | ||
| trim_history_scheduler.h | ||
| version_builder.cc | ||
| version_builder.h | ||
| version_builder_test.cc | ||
| version_edit.cc | ||
| version_edit.h | ||
| version_edit_handler.cc | ||
| version_edit_handler.h | ||
| version_edit_test.cc | ||
| version_set.cc | ||
| version_set.h | ||
| version_set_sync_and_async.h | ||
| version_set_test.cc | ||
| version_util.h | ||
| wal_edit.cc | ||
| wal_edit.h | ||
| wal_edit_test.cc | ||
| wal_manager.cc | ||
| wal_manager.h | ||
| wal_manager_test.cc | ||
| write_batch.cc | ||
| write_batch_base.cc | ||
| write_batch_internal.h | ||
| write_batch_test.cc | ||
| write_callback.h | ||
| write_callback_test.cc | ||
| write_controller.cc | ||
| write_controller.h | ||
| write_controller_test.cc | ||
| write_stall_stats.cc | ||
| write_stall_stats.h | ||
| write_thread.cc | ||
| write_thread.h | ||