mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
1cfdece85d
Summary: When internal cpp modernizer attempts to format rocksdb code, it will replace macro `ROCKSDB_NAMESPACE` with its default definition `rocksdb` when collapsing nested namespace. We filed a feedback for the tool T180254030 and the team filed a bug for this: https://github.com/llvm/llvm-project/issues/83452. At the same time, they suggested us to run the modernizer tool ourselves so future auto codemod attempts will be smaller. This diff contains: Running `xplat/scripts/codemod_service/cpp_modernizer.sh` in fbcode/internal_repo_rocksdb/repo (excluding some directories in utilities/transactions/lock/range/range_tree/lib that has a non meta copyright comment) without swapping out the namespace macro `ROCKSDB_NAMESPACE` Followed by RocksDB's own `make format` Pull Request resolved: https://github.com/facebook/rocksdb/pull/12398 Test Plan: Auto tests Reviewed By: hx235 Differential Revision: D54382532 Pulled By: jowlyzhang fbshipit-source-id: e7d5b40f9b113b60e5a503558c181f080b9d02fa
209 lines
6.9 KiB
C++
209 lines
6.9 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
|
|
#include "utilities/transactions/optimistic_transaction.h"
|
|
|
|
#include <cstdint>
|
|
#include <string>
|
|
|
|
#include "db/column_family.h"
|
|
#include "db/db_impl/db_impl.h"
|
|
#include "rocksdb/comparator.h"
|
|
#include "rocksdb/db.h"
|
|
#include "rocksdb/status.h"
|
|
#include "rocksdb/utilities/optimistic_transaction_db.h"
|
|
#include "util/cast_util.h"
|
|
#include "util/defer.h"
|
|
#include "util/string_util.h"
|
|
#include "utilities/transactions/lock/point/point_lock_tracker.h"
|
|
#include "utilities/transactions/optimistic_transaction_db_impl.h"
|
|
#include "utilities/transactions/transaction_util.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
struct WriteOptions;
|
|
|
|
OptimisticTransaction::OptimisticTransaction(
|
|
OptimisticTransactionDB* txn_db, const WriteOptions& write_options,
|
|
const OptimisticTransactionOptions& txn_options)
|
|
: TransactionBaseImpl(txn_db->GetBaseDB(), write_options,
|
|
PointLockTrackerFactory::Get()),
|
|
txn_db_(txn_db) {
|
|
Initialize(txn_options);
|
|
}
|
|
|
|
void OptimisticTransaction::Initialize(
|
|
const OptimisticTransactionOptions& txn_options) {
|
|
if (txn_options.set_snapshot) {
|
|
SetSnapshot();
|
|
}
|
|
}
|
|
|
|
void OptimisticTransaction::Reinitialize(
|
|
OptimisticTransactionDB* txn_db, const WriteOptions& write_options,
|
|
const OptimisticTransactionOptions& txn_options) {
|
|
TransactionBaseImpl::Reinitialize(txn_db->GetBaseDB(), write_options);
|
|
Initialize(txn_options);
|
|
}
|
|
|
|
OptimisticTransaction::~OptimisticTransaction() = default;
|
|
|
|
void OptimisticTransaction::Clear() { TransactionBaseImpl::Clear(); }
|
|
|
|
Status OptimisticTransaction::Prepare() {
|
|
return Status::InvalidArgument(
|
|
"Two phase commit not supported for optimistic transactions.");
|
|
}
|
|
|
|
Status OptimisticTransaction::Commit() {
|
|
auto txn_db_impl = static_cast_with_check<OptimisticTransactionDBImpl,
|
|
OptimisticTransactionDB>(txn_db_);
|
|
assert(txn_db_impl);
|
|
switch (txn_db_impl->GetValidatePolicy()) {
|
|
case OccValidationPolicy::kValidateParallel:
|
|
return CommitWithParallelValidate();
|
|
case OccValidationPolicy::kValidateSerial:
|
|
return CommitWithSerialValidate();
|
|
default:
|
|
assert(0);
|
|
}
|
|
// unreachable, just void compiler complain
|
|
return Status::OK();
|
|
}
|
|
|
|
Status OptimisticTransaction::CommitWithSerialValidate() {
|
|
// Set up callback which will call CheckTransactionForConflicts() to
|
|
// check whether this transaction is safe to be committed.
|
|
OptimisticTransactionCallback callback(this);
|
|
|
|
DBImpl* db_impl = static_cast_with_check<DBImpl>(db_->GetRootDB());
|
|
|
|
Status s = db_impl->WriteWithCallback(
|
|
write_options_, GetWriteBatch()->GetWriteBatch(), &callback);
|
|
|
|
if (s.ok()) {
|
|
Clear();
|
|
}
|
|
|
|
return s;
|
|
}
|
|
|
|
Status OptimisticTransaction::CommitWithParallelValidate() {
|
|
auto txn_db_impl = static_cast_with_check<OptimisticTransactionDBImpl,
|
|
OptimisticTransactionDB>(txn_db_);
|
|
assert(txn_db_impl);
|
|
DBImpl* db_impl = static_cast_with_check<DBImpl>(db_->GetRootDB());
|
|
assert(db_impl);
|
|
std::set<port::Mutex*> lk_ptrs;
|
|
std::unique_ptr<LockTracker::ColumnFamilyIterator> cf_it(
|
|
tracked_locks_->GetColumnFamilyIterator());
|
|
assert(cf_it != nullptr);
|
|
while (cf_it->HasNext()) {
|
|
ColumnFamilyId cf = cf_it->Next();
|
|
|
|
// To avoid the same key(s) contending across CFs or DBs, seed the
|
|
// hash independently.
|
|
uint64_t seed = reinterpret_cast<uintptr_t>(db_impl) +
|
|
uint64_t{0xb83c07fbc6ced699} /*random prime*/ * cf;
|
|
|
|
std::unique_ptr<LockTracker::KeyIterator> key_it(
|
|
tracked_locks_->GetKeyIterator(cf));
|
|
assert(key_it != nullptr);
|
|
while (key_it->HasNext()) {
|
|
auto lock_bucket_ptr = &txn_db_impl->GetLockBucket(key_it->Next(), seed);
|
|
TEST_SYNC_POINT_CALLBACK(
|
|
"OptimisticTransaction::CommitWithParallelValidate::lock_bucket_ptr",
|
|
lock_bucket_ptr);
|
|
lk_ptrs.insert(lock_bucket_ptr);
|
|
}
|
|
}
|
|
// NOTE: in a single txn, all bucket-locks are taken in ascending order.
|
|
// In this way, txns from different threads all obey this rule so that
|
|
// deadlock can be avoided.
|
|
for (auto v : lk_ptrs) {
|
|
// WART: if an exception is thrown during a Lock(), previously locked will
|
|
// not be Unlock()ed. But a vector of MutexLock is likely inefficient.
|
|
v->Lock();
|
|
}
|
|
Defer unlocks([&]() {
|
|
for (auto v : lk_ptrs) {
|
|
v->Unlock();
|
|
}
|
|
});
|
|
|
|
Status s = TransactionUtil::CheckKeysForConflicts(db_impl, *tracked_locks_,
|
|
true /* cache_only */);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
|
|
s = db_impl->Write(write_options_, GetWriteBatch()->GetWriteBatch());
|
|
if (s.ok()) {
|
|
Clear();
|
|
}
|
|
|
|
return s;
|
|
}
|
|
|
|
Status OptimisticTransaction::Rollback() {
|
|
Clear();
|
|
return Status::OK();
|
|
}
|
|
|
|
// Record this key so that we can check it for conflicts at commit time.
|
|
//
|
|
// 'exclusive' is unused for OptimisticTransaction.
|
|
Status OptimisticTransaction::TryLock(ColumnFamilyHandle* column_family,
|
|
const Slice& key, bool read_only,
|
|
bool exclusive, const bool do_validate,
|
|
const bool assume_tracked) {
|
|
assert(!assume_tracked); // not supported
|
|
(void)assume_tracked;
|
|
if (!do_validate) {
|
|
return Status::OK();
|
|
}
|
|
uint32_t cfh_id = GetColumnFamilyID(column_family);
|
|
|
|
SetSnapshotIfNeeded();
|
|
|
|
SequenceNumber seq;
|
|
if (snapshot_) {
|
|
seq = snapshot_->GetSequenceNumber();
|
|
} else {
|
|
seq = db_->GetLatestSequenceNumber();
|
|
}
|
|
|
|
std::string key_str = key.ToString();
|
|
|
|
TrackKey(cfh_id, key_str, seq, read_only, exclusive);
|
|
|
|
// Always return OK. Confilct checking will happen at commit time.
|
|
return Status::OK();
|
|
}
|
|
|
|
// Returns OK if it is safe to commit this transaction. Returns Status::Busy
|
|
// if there are read or write conflicts that would prevent us from committing OR
|
|
// if we can not determine whether there would be any such conflicts.
|
|
//
|
|
// Should only be called on writer thread in order to avoid any race conditions
|
|
// in detecting write conflicts.
|
|
Status OptimisticTransaction::CheckTransactionForConflicts(DB* db) {
|
|
auto db_impl = static_cast_with_check<DBImpl>(db);
|
|
|
|
// Since we are on the write thread and do not want to block other writers,
|
|
// we will do a cache-only conflict check. This can result in TryAgain
|
|
// getting returned if there is not sufficient memtable history to check
|
|
// for conflicts.
|
|
return TransactionUtil::CheckKeysForConflicts(db_impl, *tracked_locks_,
|
|
true /* cache_only */);
|
|
}
|
|
|
|
Status OptimisticTransaction::SetName(const TransactionName& /* unused */) {
|
|
return Status::InvalidArgument("Optimistic transactions cannot be named.");
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|