akankshamahajan 97f6f475bc Fix various failures in auto_readahead_size (#11884) ... Summary: 1. **Error** in TestIterateAgainstExpected API - `Assertion index < pre_read_expected_values.size() && index < post_read_expected_values.size() failed.` **Fix** - `Prev` op is not supported with `auto_readahead_size`. So added support to Reseek in db_iter, if Prev is called. In BlockBasedTableIterator, index_iter_ already moves forward. So there is no way to do Prev from BlockBasedTableIterator. 2. **Error** - `void rocksdb::BlockBasedTableIterator::BlockCacheLookupForReadAheadSize(uint64_t, size_t, size_t&): Assertion index_iter_->value().handle.offset() == offset` **Fix** - Remove prefetch_buffer to be used when uncompressed dict is read. 3. ** Error in TestPrefixScan API - `db_stress: db/db_iter.cc:369: bool rocksdb::DBIter::FindNextUserEntryInternal(bool, const rocksdb::Slice*): Assertion !skipping_saved_key || CompareKeyForSkip(ikey_.user_key, saved_key_.GetUserKey()) > 0 failed. Received signal 6 (Aborted) Invoking GDB for stack trace... db_stress: table/merging_iterator.cc:1036: bool rocksdb::MergingIterator::SkipNextDeleted(): Assertion comparator_->Compare(range_tombstone_iters_[i]->start_key(), pik) <= 0 failed` **Fix** - SeekPrev also calls 1) SeekPrev , 2)Seek and then 3)Prev in some cases in db_iter.cc leading to failure of Prev operation. These backward operations also call Seek. Added direction to disable lookup once direction is backwards in BlockBasedTableIterator.cc Pull Request resolved: https://github.com/facebook/rocksdb/pull/11884 Test Plan: Ran various flavors of crash tests locally for the whole duration Reviewed By: anand1976 Differential Revision: D49834201 Pulled By: akankshamahajan15 fbshipit-source-id: 9a007b4d46a48002c43dc4623a400ecf47d997fe		2023-10-02 17:47:24 -07:00
..
delete_scheduler.cc	Add a ticker to track number of trash files deleted in background thread (#11540)	2023-06-16 10:05:25 -07:00
delete_scheduler.h
delete_scheduler_test.cc	Add missing status check when compiling with ASSERT_STATUS_CHECKED=1 (#11686)	2023-08-09 15:46:44 -07:00
file_prefetch_buffer.cc	Lookup ahead in block cache ahead to tune Readaheadsize (#11860)	2023-09-22 18:12:08 -07:00
file_prefetch_buffer.h	Lookup ahead in block cache ahead to tune Readaheadsize (#11860)	2023-09-22 18:12:08 -07:00
file_util.cc	Fix a bug of rocksdb.file.read.verify.file.checksums.micros not being populated (#11836)	2023-09-15 10:36:14 -07:00
file_util.h	Fix a bug of rocksdb.file.read.verify.file.checksums.micros not being populated (#11836)	2023-09-15 10:36:14 -07:00
filename.cc
filename.h
line_file_reader.cc
line_file_reader.h
prefetch_test.cc	Fix various failures in auto_readahead_size (#11884)	2023-10-02 17:47:24 -07:00
random_access_file_reader.cc	Add some unit tests when file read returns error during compaction/scanning (#11788)	2023-09-06 10:23:41 -07:00
random_access_file_reader.h	Group rocksdb.sst.read.micros stat by different user read IOActivity + misc (#11444)	2023-08-08 17:26:50 -07:00
random_access_file_reader_test.cc	Group rocksdb.sst.read.micros stat by different user read IOActivity + misc (#11444)	2023-08-08 17:26:50 -07:00
read_write_util.cc
read_write_util.h
readahead_file_info.h
readahead_raf.cc
readahead_raf.h
sequence_file_reader.cc
sequence_file_reader.h	Group rocksdb.sst.read.micros stat by different user read IOActivity + misc (#11444)	2023-08-08 17:26:50 -07:00
sst_file_manager_impl.cc
sst_file_manager_impl.h
writable_file_writer.cc
writable_file_writer.h