mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 13:41:46 +00:00
4d897e51df
Summary: This disables Linux/amd64 builds in Travis for PRs, and adds a gcc-10+c++20 build in CircleCI, which should fill out sufficient coverage vs. what we had in Travis Fixed a use of std::is_pod, which is deprecated in c++20 Fixed ++ on a volatile in db_repl_stress.cc, with bigger refactoring. Although ++ on this volatile was probably ok with one thread writer and one thread reader, the code was still overly complex. There was a deadcode check for error `if (replThread.no_read < dataPump.no_records)` which can be proven never to happen based on the structure of the code. It infinite loops instead for the case intended to be checked. I just simplified the code for what should be the same checking power. Also most configurations seem to be using make parallelism = 2 * vcores, so fixing / using that. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7791 Test Plan: CI and `while ./db_repl_stress; do echo again; done` for a while Reviewed By: siying Differential Revision: D25669834 Pulled By: pdillinger fbshipit-source-id: b2c688053d0b1d52c989903449d3cd27a04130d6
131 lines
3.8 KiB
C++
131 lines
3.8 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
#ifndef GFLAGS
|
|
#include <cstdio>
|
|
int main() {
|
|
fprintf(stderr, "Please install gflags to run rocksdb tools\n");
|
|
return 1;
|
|
}
|
|
#else
|
|
|
|
#include <atomic>
|
|
#include <cstdio>
|
|
|
|
#include "db/write_batch_internal.h"
|
|
#include "rocksdb/db.h"
|
|
#include "rocksdb/types.h"
|
|
#include "test_util/testutil.h"
|
|
#include "util/gflags_compat.h"
|
|
|
|
// Run a thread to perform Put's.
|
|
// Another thread uses GetUpdatesSince API to keep getting the updates.
|
|
// options :
|
|
// --num_inserts = the num of inserts the first thread should perform.
|
|
// --wal_ttl = the wal ttl for the run.
|
|
|
|
DEFINE_uint64(num_inserts, 1000,
|
|
"the num of inserts the first thread should"
|
|
" perform.");
|
|
DEFINE_uint64(wal_ttl_seconds, 1000, "the wal ttl for the run(in seconds)");
|
|
DEFINE_uint64(wal_size_limit_MB, 10,
|
|
"the wal size limit for the run"
|
|
"(in MB)");
|
|
|
|
using namespace ROCKSDB_NAMESPACE;
|
|
|
|
using GFLAGS_NAMESPACE::ParseCommandLineFlags;
|
|
using GFLAGS_NAMESPACE::SetUsageMessage;
|
|
|
|
struct DataPumpThread {
|
|
DB* db; // Assumption DB is Open'ed already.
|
|
};
|
|
|
|
static void DataPumpThreadBody(void* arg) {
|
|
DataPumpThread* t = reinterpret_cast<DataPumpThread*>(arg);
|
|
DB* db = t->db;
|
|
Random rnd(301);
|
|
uint64_t i = 0;
|
|
while (i++ < FLAGS_num_inserts) {
|
|
if (!db->Put(WriteOptions(), Slice(rnd.RandomString(500)),
|
|
Slice(rnd.RandomString(500)))
|
|
.ok()) {
|
|
fprintf(stderr, "Error in put\n");
|
|
exit(1);
|
|
}
|
|
}
|
|
}
|
|
|
|
int main(int argc, const char** argv) {
|
|
SetUsageMessage(
|
|
std::string("\nUSAGE:\n") + std::string(argv[0]) +
|
|
" --num_inserts=<num_inserts> --wal_ttl_seconds=<WAL_ttl_seconds>" +
|
|
" --wal_size_limit_MB=<WAL_size_limit_MB>");
|
|
ParseCommandLineFlags(&argc, const_cast<char***>(&argv), true);
|
|
|
|
Env* env = Env::Default();
|
|
std::string default_db_path;
|
|
env->GetTestDirectory(&default_db_path);
|
|
default_db_path += "db_repl_stress";
|
|
Options options;
|
|
options.create_if_missing = true;
|
|
options.WAL_ttl_seconds = FLAGS_wal_ttl_seconds;
|
|
options.WAL_size_limit_MB = FLAGS_wal_size_limit_MB;
|
|
DB* db;
|
|
DestroyDB(default_db_path, options);
|
|
|
|
Status s = DB::Open(options, default_db_path, &db);
|
|
|
|
if (!s.ok()) {
|
|
fprintf(stderr, "Could not open DB due to %s\n", s.ToString().c_str());
|
|
exit(1);
|
|
}
|
|
|
|
DataPumpThread dataPump;
|
|
dataPump.db = db;
|
|
env->StartThread(DataPumpThreadBody, &dataPump);
|
|
|
|
std::unique_ptr<TransactionLogIterator> iter;
|
|
SequenceNumber currentSeqNum = 1;
|
|
uint64_t num_read = 0;
|
|
for (;;) {
|
|
iter.reset();
|
|
// Continue to probe a bit more after all received
|
|
size_t probes = 0;
|
|
while (!db->GetUpdatesSince(currentSeqNum, &iter).ok()) {
|
|
probes++;
|
|
if (probes > 100 && num_read >= FLAGS_num_inserts) {
|
|
if (num_read > FLAGS_num_inserts) {
|
|
fprintf(stderr, "Too many updates read: %ld expected: %ld\n",
|
|
(long)num_read, (long)FLAGS_num_inserts);
|
|
exit(1);
|
|
}
|
|
fprintf(stderr, "Successful!\n");
|
|
return 0;
|
|
}
|
|
}
|
|
fprintf(stderr, "Refreshing iterator\n");
|
|
for (; iter->Valid(); iter->Next(), num_read++, currentSeqNum++) {
|
|
BatchResult res = iter->GetBatch();
|
|
if (res.sequence != currentSeqNum) {
|
|
fprintf(stderr, "Missed a seq no. b/w %ld and %ld\n",
|
|
(long)currentSeqNum, (long)res.sequence);
|
|
exit(1);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#endif // GFLAGS
|
|
|
|
#else // ROCKSDB_LITE
|
|
#include <stdio.h>
|
|
int main(int /*argc*/, char** /*argv*/) {
|
|
fprintf(stderr, "Not supported in lite mode.\n");
|
|
return 1;
|
|
}
|
|
#endif // ROCKSDB_LITE
|