rocksdb/unreleased_history/behavior_changes/fifo-ingestion.md at 20213d01a333aca20182e5aab6e4513537d9758c - dolysis/rocksdb - Stateless Git Forge

dolysis/rocksdb

mirror of https://github.com/facebook/rocksdb.git synced 2024-11-30 13:41:46 +00:00

Changyu Bi 5bf2c00a35 Clarify manual compaction and file ingestion behavior with FIFO compaction (#12618 )

Summary:
For manual compaction, FIFO compaction will always skip key range overlapping checking with SST files. If CompactRange() is called with CompactionRangeOptions::change_level=true, a CF with FIFO compaction will now return Status::NotSupported.

For file ingestion, we will always ingest into L0. Previously, it's possible to ingest files into non-L0 levels with FIFO compaction.

These changes also help to fix [this](a178d15baf/db/db_impl/db_impl_compaction_flush.cc (L1269)) assertion failure in crash tests.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12618

Test Plan: added unit tests to verify the new behavior.

Reviewed By: hx235

Differential Revision: D56962401

Pulled By: cbi42

fbshipit-source-id: 19812a1509650b4162b379ca5bee02f2e9d9569d

2024-05-07 12:00:15 -07:00

1 line

72 B

Markdown

Raw Blame History

* External file ingestion with FIFO compaction will always ingest to L0.