mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 11:43:49 +00:00
767777c2bd
Summary: We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details. This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables. Test Plan: compiles Reviewers: ljin, rven, yhchiang, sdong Reviewed By: yhchiang Subscribers: bobbaldwin, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28689
136 lines
5.1 KiB
C++
136 lines
5.1 KiB
C++
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#ifndef __STDC_FORMAT_MACROS
|
|
#define __STDC_FORMAT_MACROS
|
|
#endif
|
|
|
|
#include <inttypes.h>
|
|
#include <limits>
|
|
#include <cassert>
|
|
#include <string>
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/options.h"
|
|
#include "rocksdb/immutable_options.h"
|
|
#include "util/mutable_cf_options.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
namespace {
|
|
// Multiple two operands. If they overflow, return op1.
|
|
uint64_t MultiplyCheckOverflow(uint64_t op1, int op2) {
|
|
if (op1 == 0) {
|
|
return 0;
|
|
}
|
|
if (op2 <= 0) {
|
|
return op1;
|
|
}
|
|
uint64_t casted_op2 = (uint64_t) op2;
|
|
if (std::numeric_limits<uint64_t>::max() / op1 < casted_op2) {
|
|
return op1;
|
|
}
|
|
return op1 * casted_op2;
|
|
}
|
|
} // anonymous namespace
|
|
|
|
void MutableCFOptions::RefreshDerivedOptions(
|
|
const ImmutableCFOptions& ioptions) {
|
|
max_file_size.resize(ioptions.num_levels);
|
|
level_max_bytes.resize(ioptions.num_levels);
|
|
for (int i = 0; i < ioptions.num_levels; ++i) {
|
|
if (i == 0 && ioptions.compaction_style == kCompactionStyleUniversal) {
|
|
max_file_size[i] = ULLONG_MAX;
|
|
level_max_bytes[i] = max_bytes_for_level_base;
|
|
} else if (i > 1) {
|
|
max_file_size[i] = MultiplyCheckOverflow(max_file_size[i - 1],
|
|
target_file_size_multiplier);
|
|
level_max_bytes[i] = MultiplyCheckOverflow(
|
|
MultiplyCheckOverflow(level_max_bytes[i - 1],
|
|
max_bytes_for_level_multiplier),
|
|
max_bytes_for_level_multiplier_additional[i - 1]);
|
|
} else {
|
|
max_file_size[i] = target_file_size_base;
|
|
level_max_bytes[i] = max_bytes_for_level_base;
|
|
}
|
|
}
|
|
}
|
|
|
|
uint64_t MutableCFOptions::MaxFileSizeForLevel(int level) const {
|
|
assert(level >= 0);
|
|
assert(level < (int)max_file_size.size());
|
|
return max_file_size[level];
|
|
}
|
|
uint64_t MutableCFOptions::MaxBytesForLevel(int level) const {
|
|
// Note: the result for level zero is not really used since we set
|
|
// the level-0 compaction threshold based on number of files.
|
|
assert(level >= 0);
|
|
assert(level < (int)level_max_bytes.size());
|
|
return level_max_bytes[level];
|
|
}
|
|
uint64_t MutableCFOptions::MaxGrandParentOverlapBytes(int level) const {
|
|
return MaxFileSizeForLevel(level) * max_grandparent_overlap_factor;
|
|
}
|
|
uint64_t MutableCFOptions::ExpandedCompactionByteSizeLimit(int level) const {
|
|
return MaxFileSizeForLevel(level) * expanded_compaction_factor;
|
|
}
|
|
|
|
void MutableCFOptions::Dump(Logger* log) const {
|
|
// Memtable related options
|
|
Log(log, " write_buffer_size: %zu", write_buffer_size);
|
|
Log(log, " max_write_buffer_number: %d",
|
|
max_write_buffer_number);
|
|
Log(log, " arena_block_size: %zu", arena_block_size);
|
|
Log(log, " memtable_prefix_bloom_bits: %" PRIu32,
|
|
memtable_prefix_bloom_bits);
|
|
Log(log, " memtable_prefix_bloom_probes: %" PRIu32,
|
|
memtable_prefix_bloom_probes);
|
|
Log(log, " memtable_prefix_bloom_huge_page_tlb_size: %zu",
|
|
memtable_prefix_bloom_huge_page_tlb_size);
|
|
Log(log, " max_successive_merges: %zu",
|
|
max_successive_merges);
|
|
Log(log, " filter_deletes: %d",
|
|
filter_deletes);
|
|
Log(log, " disable_auto_compactions: %d",
|
|
disable_auto_compactions);
|
|
Log(log, " soft_rate_limit: %lf",
|
|
soft_rate_limit);
|
|
Log(log, " hard_rate_limit: %lf",
|
|
hard_rate_limit);
|
|
Log(log, " level0_file_num_compaction_trigger: %d",
|
|
level0_file_num_compaction_trigger);
|
|
Log(log, " level0_slowdown_writes_trigger: %d",
|
|
level0_slowdown_writes_trigger);
|
|
Log(log, " level0_stop_writes_trigger: %d",
|
|
level0_stop_writes_trigger);
|
|
Log(log, " max_grandparent_overlap_factor: %d",
|
|
max_grandparent_overlap_factor);
|
|
Log(log, " expanded_compaction_factor: %d",
|
|
expanded_compaction_factor);
|
|
Log(log, " source_compaction_factor: %d",
|
|
source_compaction_factor);
|
|
Log(log, " target_file_size_base: %" PRIu64,
|
|
target_file_size_base);
|
|
Log(log, " target_file_size_multiplier: %d",
|
|
target_file_size_multiplier);
|
|
Log(log, " max_bytes_for_level_base: %" PRIu64,
|
|
max_bytes_for_level_base);
|
|
Log(log, " max_bytes_for_level_multiplier: %d",
|
|
max_bytes_for_level_multiplier);
|
|
std::string result;
|
|
char buf[10];
|
|
for (const auto m : max_bytes_for_level_multiplier_additional) {
|
|
snprintf(buf, sizeof(buf), "%d, ", m);
|
|
result += buf;
|
|
}
|
|
result.resize(result.size() - 2);
|
|
Log(log, "max_bytes_for_level_multiplier_additional: %s", result.c_str());
|
|
Log(log, " max_mem_compaction_level: %d",
|
|
max_mem_compaction_level);
|
|
Log(log, " max_sequential_skip_in_iterations: %" PRIu64,
|
|
max_sequential_skip_in_iterations);
|
|
}
|
|
|
|
} // namespace rocksdb
|