mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 15:33:54 +00:00
4e60663b31
Summary: In C++, `extern` is redundant in a number of cases: * "Global" function declarations and definitions * "Global" variable definitions when already declared `extern` For consistency and simplicity, I've removed these in code that *we own*. In a couple of cases, I removed obsolete declarations, and for MagicNumber constants, I have consolidated the declarations into a header file (format.h) as standard best practice would prescribe. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12300 Test Plan: no functional changes, CI Reviewed By: ajkr Differential Revision: D53148629 Pulled By: pdillinger fbshipit-source-id: fb8d927959892e03af09b0c0d542b0a3b38fd886 |
||
|---|---|---|
| .. | ||
| win | ||
| jemalloc_helper.h | ||
| lang.h | ||
| likely.h | ||
| malloc.h | ||
| mmap.cc | ||
| mmap.h | ||
| port.h | ||
| port_dirent.h | ||
| port_example.h | ||
| port_posix.cc | ||
| port_posix.h | ||
| README | ||
| stack_trace.cc | ||
| stack_trace.h | ||
| sys_time.h | ||
| util_logger.h | ||
| xpress.h | ||
This directory contains interfaces and implementations that isolate the rest of the package from platform details. Code in the rest of the package includes "port.h" from this directory. "port.h" in turn includes a platform specific "port_<platform>.h" file that provides the platform specific implementation. See port_posix.h for an example of what must be provided in a platform specific header file.