Jay Huh 99f8820054 Fix test on IOActivity check for MultiGetEntity (#11850) ... Summary: After https://github.com/facebook/rocksdb/issues/11842 merged, we started to see some crash_test failures. There is a flow inside `TestMultiGetEntity()` that it calls `GetEntity()` to compare the result between `MultiGetEntity()` and `GetEntity()` 1c6faf3587/db_stress_tool/no_batched_ops_stress.cc (L1068-L1072) However, IOActivity check inside DbStressRandomAccessFileWrapper was expecting IOActivity::MultiGet when GetEntity() was called. We are fixing the test by setting expected operation to be GetEntity before calling GetEntity() Pull Request resolved: https://github.com/facebook/rocksdb/pull/11850 Test Plan: Error repro'ed by the following run before fix and no more error after the fix. ``` ./db_stress --acquire_snapshot_one_in=10000 --adaptive_readahead=0 --allow_concurrent_memtable_write=0 --allow_data_in_errors=True --async_io=1 --auto_readahead_size=1 --avoid_flush_during_recovery=0 --avoid_unnecessary_blocking_io=1 --backup_max_size=104857600 --backup_one_in=100000 --batch_protection_bytes_per_key=8 --block_protection_bytes_per_key=0 --block_size=16384 --bloom_before_level=1 --bloom_bits=9.880688060667444 --bottommost_compression_type=zstd --bottommost_file_compaction_delay=86400 --bytes_per_sync=262144 --cache_index_and_filter_blocks=0 --cache_size=8388608 --cache_type=auto_hyper_clock_cache --charge_compression_dictionary_building_buffer=1 --charge_file_metadata=0 --charge_filter_construction=0 --charge_table_reader=1 --checkpoint_one_in=1000000 --checksum_type=kxxHash64 --clear_column_family_one_in=0 --column_families=1 --compact_files_one_in=1000000 --compact_range_one_in=1000000 --compaction_pri=3 --compaction_readahead_size=1048576 --compaction_ttl=0 --compression_checksum=0 --compression_max_dict_buffer_bytes=0 --compression_max_dict_bytes=0 --compression_parallel_threads=1 --compression_type=none --compression_use_zstd_dict_trainer=1 --compression_zstd_max_train_bytes=0 --continuous_verification_interval=0 --data_block_index_type=1 --db=/dev/shm/rocksdb_test/rocksdb_crashtest_blackbox --db_write_buffer_size=0 --delpercent=4 --delrangepercent=1 --destroy_db_initially=0 --detect_filter_construct_corruption=1 --disable_wal=0 --enable_compaction_filter=0 --enable_pipelined_write=0 --enable_thread_tracking=1 --expected_values_dir=/dev/shm/rocksdb_test/rocksdb_crashtest_expected --fail_if_options_file_error=0 --fifo_allow_compaction=1 --file_checksum_impl=big --flush_one_in=1000000 --format_version=6 --get_current_wal_file_one_in=0 --get_live_files_one_in=1000000 --get_property_one_in=1000000 --get_sorted_wal_files_one_in=0 --index_block_restart_interval=4 --index_type=0 --ingest_external_file_one_in=0 --initial_auto_readahead_size=0 --iterpercent=10 --key_len_percent_dist=1,30,69 --level_compaction_dynamic_level_bytes=0 --lock_wal_one_in=1000000 --long_running_snapshots=0 --manual_wal_flush_one_in=0 --mark_for_compaction_one_file_in=0 --max_auto_readahead_size=524288 --max_background_compactions=1 --max_bytes_for_level_base=67108864 --max_key=25000000 --max_key_len=3 --max_manifest_file_size=1073741824 --max_write_batch_group_size_bytes=16777216 --max_write_buffer_number=3 --max_write_buffer_size_to_maintain=2097152 --memtable_max_range_deletions=0 --memtable_prefix_bloom_size_ratio=0 --memtable_protection_bytes_per_key=2 --memtable_whole_key_filtering=0 --memtablerep=skip_list --min_write_buffer_number_to_merge=2 --mmap_read=1 --mock_direct_io=False --nooverwritepercent=1 --num_file_reads_for_auto_readahead=0 --open_files=-1 --open_metadata_write_fault_one_in=0 --open_read_fault_one_in=0 --open_write_fault_one_in=0 --ops_per_thread=100000000 --optimize_filters_for_memory=0 --paranoid_file_checks=1 --partition_filters=0 --partition_pinning=3 --pause_background_one_in=1000000 --periodic_compaction_seconds=1 --prefix_size=-1 --prefixpercent=0 --prepopulate_block_cache=0 --preserve_internal_time_seconds=0 --progress_reports=0 --read_fault_one_in=32 --readahead_size=16384 --readpercent=50 --recycle_log_file_num=1 --reopen=0 --secondary_cache_fault_one_in=0 --secondary_cache_uri=compressed_secondary_cache://capacity=8388608;enable_custom_split_merge=true --set_options_one_in=0 --snapshot_hold_ops=100000 --sst_file_manager_bytes_per_sec=104857600 --sst_file_manager_bytes_per_truncate=0 --stats_dump_period_sec=0 --subcompactions=2 --sync=0 --sync_fault_injection=1 --target_file_size_base=16777216 --target_file_size_multiplier=1 --test_batches_snapshots=0 --top_level_index_pinning=3 --unpartitioned_pinning=0 --use_direct_io_for_flush_and_compaction=0 --use_direct_reads=0 --use_full_merge_v1=0 --use_get_entity=0 --use_merge=1 --use_multi_get_entity=1 --use_multiget=1 --use_put_entity_one_in=0 --user_timestamp_size=0 --value_size_mult=32 --verification_only=0 --verify_checksum=1 --verify_checksum_one_in=1000000 --verify_db_one_in=100000 --verify_file_checksums_one_in=1000000 --verify_iterator_with_expected_state_one_in=5 --verify_sst_unique_id_in_manifest=1 --wal_bytes_per_sync=524288 --wal_compression=none --write_buffer_size=33554432 --write_dbid_to_manifest=0 --writepercent=35 ``` Reviewed By: cbi42 Differential Revision: D49344996 Pulled By: jaykorean fbshipit-source-id: 8059b8127c0e3cb8af96cf222f47398413c92c50		2023-09-15 22:50:49 -07:00
..
batched_ops_stress.cc	Support parallel read and write/delete to same key in NonBatchedOpsStressTest (#11058)	2023-05-15 15:34:22 -07:00
cf_consistency_stress.cc	Extend the stress test coverage of MultiGetEntity (#11336)	2023-03-29 20:35:15 -07:00
CMakeLists.txt	Improve comment of ExpectedValue in db stress (#11456)	2023-05-18 09:44:15 -07:00
db_stress.cc
db_stress_common.cc	Add a helper method WideColumnsHelper::SortColumns (#11823)	2023-09-12 12:36:07 -07:00
db_stress_common.h	Make RibbonFilterPolicy::bloom_before_level mutable (SetOptions()) (#11838)	2023-09-15 15:46:10 -07:00
db_stress_compaction_filter.h
db_stress_driver.cc	Run db_stress for final time to ensure un-interrupted validation (#11592)	2023-08-23 15:24:23 -07:00
db_stress_driver.h
db_stress_env_wrapper.h	Group rocksdb.sst.read.micros stat by different user read IOActivity + misc (#11444)	2023-08-08 17:26:50 -07:00
db_stress_gflags.cc	Make RibbonFilterPolicy::bloom_before_level mutable (SetOptions()) (#11838)	2023-09-15 15:46:10 -07:00
db_stress_listener.cc
db_stress_listener.h	Disable error injection after compaction completion (#11798)	2023-09-06 12:57:10 -07:00
db_stress_shared_state.cc
db_stress_shared_state.h	Added compaction read errors to db_stress (#11789)	2023-09-05 10:41:29 -07:00
db_stress_stat.cc
db_stress_stat.h
db_stress_table_properties_collector.h
db_stress_test_base.cc	Make RibbonFilterPolicy::bloom_before_level mutable (SetOptions()) (#11838)	2023-09-15 15:46:10 -07:00
db_stress_test_base.h	Do not drop unsynced data during reopen in stress test (#11731)	2023-08-22 09:47:04 -07:00
db_stress_tool.cc	Wide Column Ingestion in CrashTest (#11697)	2023-08-15 16:13:13 -07:00
expected_state.cc	Add helper methods WideColumnsHelper::{Has,Get}DefaultColumn (#11813)	2023-09-11 16:32:32 -07:00
expected_state.h	Improve comment of ExpectedValue in db stress (#11456)	2023-05-18 09:44:15 -07:00
expected_value.cc	Improve comment of ExpectedValue in db stress (#11456)	2023-05-18 09:44:15 -07:00
expected_value.h	Refactor WriteUnpreparedStressTest to be a unit test (#11424)	2023-05-22 12:31:52 -07:00
multi_ops_txns_stress.cc	db_stress: Reinstate Transaction::Rollback() calls before destruction (#11656)	2023-07-30 17:30:01 -07:00
multi_ops_txns_stress.h	Group rocksdb.sst.read.micros stat by IOActivity flush and compaction (#11288)	2023-04-21 09:07:18 -07:00
no_batched_ops_stress.cc	Fix test on IOActivity check for MultiGetEntity (#11850)	2023-09-15 22:50:49 -07:00