mirror of https://github.com/facebook/rocksdb.git
db87afbcb3
Summary: Right now all I/O failures under PartitionFilterBlock::CacheDependencies() is swallowed. Return error in case prefetch fails. On returning error in PartitionedFilterBlockReader::CacheDependencies was causing stress test failure because PrefetchBuffer is initialized with enable_ = true, as result when PosixMmapReadableFile::Read is called from Prefetch, scratch is ignored causing buffer to fill with garbage values. Initializing prefetch buffer by CreatePrefetchBuffer that sets enable_ with !ioptions.allow_mmap_reads fixed the problem as it returns without prefetching data if allow_mmap_reads is set. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7543 Test Plan: make check -j64; python -u tools/db_crashtest.py --simple blackbox Reviewed By: anand1976 Differential Revision: D24284596 Pulled By: akankshamahajan15 fbshipit-source-id: f3f0fd44b59dcf60645730436f28564a07884868 |
||
|---|---|---|
| .. | ||
| delete_scheduler.cc | ||
| delete_scheduler.h | ||
| delete_scheduler_test.cc | ||
| file_prefetch_buffer.cc | ||
| file_prefetch_buffer.h | ||
| file_util.cc | ||
| file_util.h | ||
| filename.cc | ||
| filename.h | ||
| prefetch_test.cc | ||
| random_access_file_reader.cc | ||
| random_access_file_reader.h | ||
| random_access_file_reader_test.cc | ||
| read_write_util.cc | ||
| read_write_util.h | ||
| readahead_raf.cc | ||
| readahead_raf.h | ||
| sequence_file_reader.cc | ||
| sequence_file_reader.h | ||
| sst_file_manager_impl.cc | ||
| sst_file_manager_impl.h | ||
| writable_file_writer.cc | ||
| writable_file_writer.h | ||