mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 22:41:48 +00:00
d3ba398bbd
Summary: 1. remove AssertEmpty because calling methods on moved objects is discouraged. 2. add a test to assert that the internal buffer is moved instead of being copied. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6399 Test Plan: make slice_test && ./slice_test USE_CLANG=1 make analyze Differential Revision: D19825372 Pulled By: cheng-chang fbshipit-source-id: 2e26f8ce5ec3edbfce067db045e80bd433e704f4
164 lines
4 KiB
C++
164 lines
4 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "port/port.h"
|
|
#include "port/stack_trace.h"
|
|
#include "rocksdb/slice.h"
|
|
#include "test_util/testharness.h"
|
|
#include "test_util/testutil.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
// Use this to keep track of the cleanups that were actually performed
|
|
void Multiplier(void* arg1, void* arg2) {
|
|
int* res = reinterpret_cast<int*>(arg1);
|
|
int* num = reinterpret_cast<int*>(arg2);
|
|
*res *= *num;
|
|
}
|
|
|
|
class PinnableSliceTest : public testing::Test {
|
|
public:
|
|
void AssertSameData(const std::string& expected,
|
|
const PinnableSlice& slice) {
|
|
std::string got;
|
|
got.assign(slice.data(), slice.size());
|
|
ASSERT_EQ(expected, got);
|
|
}
|
|
};
|
|
|
|
// Test that the external buffer is moved instead of being copied.
|
|
TEST_F(PinnableSliceTest, MoveExternalBuffer) {
|
|
Slice s("123");
|
|
std::string buf;
|
|
PinnableSlice v1(&buf);
|
|
v1.PinSelf(s);
|
|
|
|
PinnableSlice v2(std::move(v1));
|
|
ASSERT_EQ(buf.data(), v2.data());
|
|
ASSERT_EQ(&buf, v2.GetSelf());
|
|
|
|
PinnableSlice v3;
|
|
v3 = std::move(v2);
|
|
ASSERT_EQ(buf.data(), v3.data());
|
|
ASSERT_EQ(&buf, v3.GetSelf());
|
|
}
|
|
|
|
TEST_F(PinnableSliceTest, Move) {
|
|
int n2 = 2;
|
|
int res = 1;
|
|
const std::string const_str1 = "123";
|
|
const std::string const_str2 = "ABC";
|
|
Slice slice1(const_str1);
|
|
Slice slice2(const_str2);
|
|
|
|
{
|
|
// Test move constructor on a pinned slice.
|
|
res = 1;
|
|
PinnableSlice v1;
|
|
v1.PinSlice(slice1, Multiplier, &res, &n2);
|
|
PinnableSlice v2(std::move(v1));
|
|
|
|
// Since v1's Cleanable has been moved to v2,
|
|
// no cleanup should happen in Reset.
|
|
v1.Reset();
|
|
ASSERT_EQ(1, res);
|
|
|
|
AssertSameData(const_str1, v2);
|
|
}
|
|
// v2 is cleaned up.
|
|
ASSERT_EQ(2, res);
|
|
|
|
{
|
|
// Test move constructor on an unpinned slice.
|
|
PinnableSlice v1;
|
|
v1.PinSelf(slice1);
|
|
PinnableSlice v2(std::move(v1));
|
|
|
|
AssertSameData(const_str1, v2);
|
|
}
|
|
|
|
{
|
|
// Test move assignment from a pinned slice to
|
|
// another pinned slice.
|
|
res = 1;
|
|
PinnableSlice v1;
|
|
v1.PinSlice(slice1, Multiplier, &res, &n2);
|
|
PinnableSlice v2;
|
|
v2.PinSlice(slice2, Multiplier, &res, &n2);
|
|
v2 = std::move(v1);
|
|
|
|
// v2's Cleanable will be Reset before moving
|
|
// anything from v1.
|
|
ASSERT_EQ(2, res);
|
|
// Since v1's Cleanable has been moved to v2,
|
|
// no cleanup should happen in Reset.
|
|
v1.Reset();
|
|
ASSERT_EQ(2, res);
|
|
|
|
AssertSameData(const_str1, v2);
|
|
}
|
|
// The Cleanable moved from v1 to v2 will be Reset.
|
|
ASSERT_EQ(4, res);
|
|
|
|
{
|
|
// Test move assignment from a pinned slice to
|
|
// an unpinned slice.
|
|
res = 1;
|
|
PinnableSlice v1;
|
|
v1.PinSlice(slice1, Multiplier, &res, &n2);
|
|
PinnableSlice v2;
|
|
v2.PinSelf(slice2);
|
|
v2 = std::move(v1);
|
|
|
|
// Since v1's Cleanable has been moved to v2,
|
|
// no cleanup should happen in Reset.
|
|
v1.Reset();
|
|
ASSERT_EQ(1, res);
|
|
|
|
AssertSameData(const_str1, v2);
|
|
}
|
|
// The Cleanable moved from v1 to v2 will be Reset.
|
|
ASSERT_EQ(2, res);
|
|
|
|
{
|
|
// Test move assignment from an upinned slice to
|
|
// another unpinned slice.
|
|
PinnableSlice v1;
|
|
v1.PinSelf(slice1);
|
|
PinnableSlice v2;
|
|
v2.PinSelf(slice2);
|
|
v2 = std::move(v1);
|
|
|
|
AssertSameData(const_str1, v2);
|
|
}
|
|
|
|
{
|
|
// Test move assignment from an upinned slice to
|
|
// a pinned slice.
|
|
res = 1;
|
|
PinnableSlice v1;
|
|
v1.PinSelf(slice1);
|
|
PinnableSlice v2;
|
|
v2.PinSlice(slice2, Multiplier, &res, &n2);
|
|
v2 = std::move(v1);
|
|
|
|
// v2's Cleanable will be Reset before moving
|
|
// anything from v1.
|
|
ASSERT_EQ(2, res);
|
|
|
|
AssertSameData(const_str1, v2);
|
|
}
|
|
// No Cleanable is moved from v1 to v2, so no more cleanup.
|
|
ASSERT_EQ(2, res);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
rocksdb::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|