mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 15:33:54 +00:00
35af0433cf
Summary: Forgot to re-test crash test after adding read-only filesystem enforcement to https://github.com/facebook/rocksdb/issues/8142. The problem is ReadOnlyFileSystem would reject CreateDirIfMissing whenever DBOptions::create_if_missing=true. The fix that is better for users is to allow CreateDirIfMissing in ReadOnlyFileSystem if the directory exists, so that they don't cause a failure on using create_if_missing with opening backups as read-only DBs. Added this option test to the unit test (in addition to being in the crash test). Also fixed a couple of lints. And some better messaging from 'make format' so that when you run it with uncommitted changes, it's clear that it's only checking the uncommitted changes. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8161 Test Plan: local blackbox_crash_test with amplified backup_one_in Reviewed By: ajkr Differential Revision: D27614409 Pulled By: pdillinger fbshipit-source-id: 63ccb626c7e34c200d61c6bca2a8f60da9015179 |
||
|---|---|---|
| .. | ||
| amalgamate.py | ||
| build_detect_platform | ||
| dependencies.sh | ||
| dependencies_4.8.1.sh | ||
| dependencies_platform007.sh | ||
| dependencies_platform009.sh | ||
| dockerbuild.sh | ||
| error_filter.py | ||
| fb_compile_mongo.sh | ||
| fbcode_config.sh | ||
| fbcode_config4.8.1.sh | ||
| fbcode_config_platform007.sh | ||
| fbcode_config_platform009.sh | ||
| format-diff.sh | ||
| gnu_parallel | ||
| make_package.sh | ||
| precommit_checker.py | ||
| regression_build_test.sh | ||
| rocksdb-lego-determinator | ||
| run_ci_db_test.ps1 | ||
| setup_centos7.sh | ||
| update_dependencies.sh | ||
| version.sh | ||