mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
151242ce46
Summary: **Context:** The existing stat rocksdb.sst.read.micros does not reflect each of compaction and flush cases but aggregate them, which is not so helpful for us to understand IO read behavior of each of them. **Summary** - Update `StopWatch` and `RandomAccessFileReader` to record `rocksdb.sst.read.micros` and `rocksdb.file.{flush/compaction}.read.micros` - Fixed the default histogram in `RandomAccessFileReader` - New field `ReadOptions/IOOptions::io_activity`; Pass `ReadOptions` through paths under db open, flush and compaction to where we can prepare `IOOptions` and pass it to `RandomAccessFileReader` - Use `thread_status_util` for assertion in `DbStressFSWrapper` for continuous testing on we are passing correct `io_activity` under db open, flush and compaction Pull Request resolved: https://github.com/facebook/rocksdb/pull/11288 Test Plan: - **Stress test** - **Db bench 1: rocksdb.sst.read.micros COUNT ≈ sum of rocksdb.file.read.flush.micros's and rocksdb.file.read.compaction.micros's.** (without blob) - May not be exactly the same due to `HistogramStat::Add` only guarantees atomic not accuracy across threads. ``` ./db_bench -db=/dev/shm/testdb/ -statistics=true -benchmarks="fillseq" -key_size=32 -value_size=512 -num=50000 -write_buffer_size=655 -target_file_size_base=655 -disable_auto_compactions=false -compression_type=none -bloom_bits=3 (-use_plain_table=1 -prefix_size=10) ``` ``` // BlockBasedTable rocksdb.sst.read.micros P50 : 2.009374 P95 : 4.968548 P99 : 8.110362 P100 : 43.000000 COUNT : 40456 SUM : 114805 rocksdb.file.read.flush.micros P50 : 1.871841 P95 : 3.872407 P99 : 5.540541 P100 : 43.000000 COUNT : 2250 SUM : 6116 rocksdb.file.read.compaction.micros P50 : 2.023109 P95 : 5.029149 P99 : 8.196910 P100 : 26.000000 COUNT : 38206 SUM : 108689 // PlainTable Does not apply ``` - **Db bench 2: performance** **Read** SETUP: db with 900 files ``` ./db_bench -db=/dev/shm/testdb/ -benchmarks="fillseq" -key_size=32 -value_size=512 -num=50000 -write_buffer_size=655 -disable_auto_compactions=true -target_file_size_base=655 -compression_type=none ```run till convergence ``` ./db_bench -seed=1678564177044286 -use_existing_db=true -db=/dev/shm/testdb -benchmarks=readrandom[-X60] -statistics=true -num=1000000 -disable_auto_compactions=true -compression_type=none -bloom_bits=3 ``` Pre-change `readrandom [AVG 60 runs] : 21568 (± 248) ops/sec` Post-change (no regression, -0.3%) `readrandom [AVG 60 runs] : 21486 (± 236) ops/sec` **Compaction/Flush**run till convergence ``` ./db_bench -db=/dev/shm/testdb2/ -seed=1678564177044286 -benchmarks="fillseq[-X60]" -key_size=32 -value_size=512 -num=50000 -write_buffer_size=655 -disable_auto_compactions=false -target_file_size_base=655 -compression_type=none rocksdb.sst.read.micros COUNT : 33820 rocksdb.sst.read.flush.micros COUNT : 1800 rocksdb.sst.read.compaction.micros COUNT : 32020 ``` Pre-change `fillseq [AVG 46 runs] : 1391 (± 214) ops/sec; 0.7 (± 0.1) MB/sec` Post-change (no regression, ~-0.4%) `fillseq [AVG 46 runs] : 1385 (± 216) ops/sec; 0.7 (± 0.1) MB/sec` Reviewed By: ajkr Differential Revision: D44007011 Pulled By: hx235 fbshipit-source-id: a54c89e4846dfc9a135389edf3f3eedfea257132
162 lines
6.4 KiB
C++
162 lines
6.4 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cinttypes>
|
|
#include <memory>
|
|
|
|
#include "cache/cache_key.h"
|
|
#include "cache/typed_cache.h"
|
|
#include "db/blob/blob_contents.h"
|
|
#include "db/blob/blob_file_cache.h"
|
|
#include "db/blob/blob_read_request.h"
|
|
#include "rocksdb/cache.h"
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
#include "table/block_based/cachable_entry.h"
|
|
#include "util/autovector.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
struct ImmutableOptions;
|
|
class Status;
|
|
class FilePrefetchBuffer;
|
|
class Slice;
|
|
|
|
// BlobSource is a class that provides universal access to blobs, regardless of
|
|
// whether they are in the blob cache, secondary cache, or (remote) storage.
|
|
// Depending on user settings, it always fetch blobs from multi-tier cache and
|
|
// storage with minimal cost.
|
|
class BlobSource {
|
|
public:
|
|
BlobSource(const ImmutableOptions* immutable_options,
|
|
const std::string& db_id, const std::string& db_session_id,
|
|
BlobFileCache* blob_file_cache);
|
|
|
|
BlobSource(const BlobSource&) = delete;
|
|
BlobSource& operator=(const BlobSource&) = delete;
|
|
|
|
~BlobSource();
|
|
|
|
// Read a blob from the underlying cache or one blob file.
|
|
//
|
|
// If successful, returns ok and sets "*value" to the newly retrieved
|
|
// uncompressed blob. If there was an error while fetching the blob, sets
|
|
// "*value" to empty and returns a non-ok status.
|
|
//
|
|
// Note: For consistency, whether the blob is found in the cache or on disk,
|
|
// sets "*bytes_read" to the size of on-disk (possibly compressed) blob
|
|
// record.
|
|
Status GetBlob(const ReadOptions& read_options, const Slice& user_key,
|
|
uint64_t file_number, uint64_t offset, uint64_t file_size,
|
|
uint64_t value_size, CompressionType compression_type,
|
|
FilePrefetchBuffer* prefetch_buffer, PinnableSlice* value,
|
|
uint64_t* bytes_read);
|
|
|
|
// Read multiple blobs from the underlying cache or blob file(s).
|
|
//
|
|
// If successful, returns ok and sets "result" in the elements of "blob_reqs"
|
|
// to the newly retrieved uncompressed blobs. If there was an error while
|
|
// fetching one of blobs, sets its "result" to empty and sets its
|
|
// corresponding "status" to a non-ok status.
|
|
//
|
|
// Note:
|
|
// - The main difference between this function and MultiGetBlobFromOneFile is
|
|
// that this function can read multiple blobs from multiple blob files.
|
|
//
|
|
// - For consistency, whether the blob is found in the cache or on disk, sets
|
|
// "*bytes_read" to the total size of on-disk (possibly compressed) blob
|
|
// records.
|
|
void MultiGetBlob(const ReadOptions& read_options,
|
|
autovector<BlobFileReadRequests>& blob_reqs,
|
|
uint64_t* bytes_read);
|
|
|
|
// Read multiple blobs from the underlying cache or one blob file.
|
|
//
|
|
// If successful, returns ok and sets "result" in the elements of "blob_reqs"
|
|
// to the newly retrieved uncompressed blobs. If there was an error while
|
|
// fetching one of blobs, sets its "result" to empty and sets its
|
|
// corresponding "status" to a non-ok status.
|
|
//
|
|
// Note:
|
|
// - The main difference between this function and MultiGetBlob is that this
|
|
// function is only used for the case where the demanded blobs are stored in
|
|
// one blob file. MultiGetBlob will call this function multiple times if the
|
|
// demanded blobs are stored in multiple blob files.
|
|
//
|
|
// - For consistency, whether the blob is found in the cache or on disk, sets
|
|
// "*bytes_read" to the total size of on-disk (possibly compressed) blob
|
|
// records.
|
|
void MultiGetBlobFromOneFile(const ReadOptions& read_options,
|
|
uint64_t file_number, uint64_t file_size,
|
|
autovector<BlobReadRequest>& blob_reqs,
|
|
uint64_t* bytes_read);
|
|
|
|
inline Status GetBlobFileReader(
|
|
const ReadOptions& read_options, uint64_t blob_file_number,
|
|
CacheHandleGuard<BlobFileReader>* blob_file_reader) {
|
|
return blob_file_cache_->GetBlobFileReader(read_options, blob_file_number,
|
|
blob_file_reader);
|
|
}
|
|
|
|
inline Cache* GetBlobCache() const { return blob_cache_.get(); }
|
|
|
|
bool TEST_BlobInCache(uint64_t file_number, uint64_t file_size,
|
|
uint64_t offset, size_t* charge = nullptr) const;
|
|
|
|
// For TypedSharedCacheInterface
|
|
void Create(BlobContents** out, const char* buf, size_t size,
|
|
MemoryAllocator* alloc);
|
|
|
|
using SharedCacheInterface =
|
|
FullTypedSharedCacheInterface<BlobContents, BlobContentsCreator>;
|
|
using TypedHandle = SharedCacheInterface::TypedHandle;
|
|
|
|
private:
|
|
Status GetBlobFromCache(const Slice& cache_key,
|
|
CacheHandleGuard<BlobContents>* cached_blob) const;
|
|
|
|
Status PutBlobIntoCache(const Slice& cache_key,
|
|
std::unique_ptr<BlobContents>* blob,
|
|
CacheHandleGuard<BlobContents>* cached_blob) const;
|
|
|
|
static void PinCachedBlob(CacheHandleGuard<BlobContents>* cached_blob,
|
|
PinnableSlice* value);
|
|
|
|
static void PinOwnedBlob(std::unique_ptr<BlobContents>* owned_blob,
|
|
PinnableSlice* value);
|
|
|
|
TypedHandle* GetEntryFromCache(const Slice& key) const;
|
|
|
|
Status InsertEntryIntoCache(const Slice& key, BlobContents* value,
|
|
TypedHandle** cache_handle,
|
|
Cache::Priority priority) const;
|
|
|
|
inline CacheKey GetCacheKey(uint64_t file_number, uint64_t /*file_size*/,
|
|
uint64_t offset) const {
|
|
OffsetableCacheKey base_cache_key(db_id_, db_session_id_, file_number);
|
|
return base_cache_key.WithOffset(offset);
|
|
}
|
|
|
|
const std::string& db_id_;
|
|
const std::string& db_session_id_;
|
|
|
|
Statistics* statistics_;
|
|
|
|
// A cache to store blob file reader.
|
|
BlobFileCache* blob_file_cache_;
|
|
|
|
// A cache to store uncompressed blobs.
|
|
mutable SharedCacheInterface blob_cache_;
|
|
|
|
// The control option of how the cache tiers will be used. Currently rocksdb
|
|
// support block/blob cache (volatile tier) and secondary cache (this tier
|
|
// isn't strictly speaking a non-volatile tier since the compressed cache in
|
|
// this tier is in volatile memory).
|
|
const CacheTier lowest_used_cache_tier_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|