mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 07:30:54 +00:00
11526252cc
Summary:
PinnableSlice
Summary:
Currently the point lookup values are copied to a string provided by the
user. This incures an extra memcpy cost. This patch allows doing point lookup
via a PinnableSlice which pins the source memory location (instead of
copying their content) and releases them after the content is consumed
by the user. The old API of Get(string) is translated to the new API
underneath.
Here is the summary for improvements:
value 100 byte: 1.8% regular, 1.2% merge values
value 1k byte: 11.5% regular, 7.5% merge values
value 10k byte: 26% regular, 29.9% merge values
The improvement for merge could be more if we extend this approach to
pin the merge output and delay the full merge operation until the user
actually needs it. We have put that for future work.
PS:
Sometimes we observe a small decrease in performance when switching from
t5452014 to this patch but with the old Get(string) API. The d
Closes https://github.com/facebook/rocksdb/pull/1756
Differential Revision: D4391738
Pulled By: maysamyabandeh
fbshipit-source-id: 6f3edd3
278 lines
6.4 KiB
C++
278 lines
6.4 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#include <functional>
|
|
|
|
#include "port/port.h"
|
|
#include "port/stack_trace.h"
|
|
#include "rocksdb/iostats_context.h"
|
|
#include "rocksdb/perf_context.h"
|
|
#include "util/testharness.h"
|
|
#include "util/testutil.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class CleanableTest : public testing::Test {};
|
|
|
|
// Use this to keep track of the cleanups that were actually performed
|
|
void Multiplier(void* arg1, void* arg2) {
|
|
int* res = reinterpret_cast<int*>(arg1);
|
|
int* num = reinterpret_cast<int*>(arg2);
|
|
*res *= *num;
|
|
}
|
|
|
|
// the first Cleanup is on stack and the rest on heap, so test with both cases
|
|
TEST_F(CleanableTest, Register) {
|
|
int n2 = 2, n3 = 3;
|
|
int res = 1;
|
|
{ Cleanable c1; }
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(2, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.RegisterCleanup(Multiplier, &res, &n3); // res = 2 * 3;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(6, res);
|
|
|
|
// Test the Reset does cleanup
|
|
res = 1;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.RegisterCleanup(Multiplier, &res, &n3); // res = 2 * 3;
|
|
c1.Reset();
|
|
ASSERT_EQ(6, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(6, res);
|
|
|
|
// Test Clenable is usable after Reset
|
|
res = 1;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.Reset();
|
|
ASSERT_EQ(2, res);
|
|
c1.RegisterCleanup(Multiplier, &res, &n3); // res = 2 * 3;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(6, res);
|
|
}
|
|
|
|
// the first Cleanup is on stack and the rest on heap,
|
|
// so test all the combinations of them
|
|
TEST_F(CleanableTest, Delegation) {
|
|
int n2 = 2, n3 = 3, n5 = 5, n7 = 7;
|
|
int res = 1;
|
|
{
|
|
Cleanable c2;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.DelegateCleanupsTo(&c2);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(2, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
{
|
|
Cleanable c1;
|
|
c1.DelegateCleanupsTo(&c2);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.RegisterCleanup(Multiplier, &res, &n3); // res = 2 * 3;
|
|
c1.DelegateCleanupsTo(&c2);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(6, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
c2.RegisterCleanup(Multiplier, &res, &n5); // res = 5;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.RegisterCleanup(Multiplier, &res, &n3); // res = 2 * 3;
|
|
c1.DelegateCleanupsTo(&c2); // res = 2 * 3 * 5;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(30, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
c2.RegisterCleanup(Multiplier, &res, &n5); // res = 5;
|
|
c2.RegisterCleanup(Multiplier, &res, &n7); // res = 5 * 7;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.RegisterCleanup(Multiplier, &res, &n3); // res = 2 * 3;
|
|
c1.DelegateCleanupsTo(&c2); // res = 2 * 3 * 5 * 7;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(210, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
c2.RegisterCleanup(Multiplier, &res, &n5); // res = 5;
|
|
c2.RegisterCleanup(Multiplier, &res, &n7); // res = 5 * 7;
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
c1.DelegateCleanupsTo(&c2); // res = 2 * 5 * 7;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(70, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
c2.RegisterCleanup(Multiplier, &res, &n5); // res = 5;
|
|
c2.RegisterCleanup(Multiplier, &res, &n7); // res = 5 * 7;
|
|
{
|
|
Cleanable c1;
|
|
c1.DelegateCleanupsTo(&c2); // res = 5 * 7;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(35, res);
|
|
|
|
res = 1;
|
|
{
|
|
Cleanable c2;
|
|
c2.RegisterCleanup(Multiplier, &res, &n5); // res = 5;
|
|
{
|
|
Cleanable c1;
|
|
c1.DelegateCleanupsTo(&c2); // res = 5;
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(5, res);
|
|
}
|
|
|
|
static void ReleaseStringHeap(void* s, void*) {
|
|
delete reinterpret_cast<const std::string*>(s);
|
|
}
|
|
|
|
class PinnableSlice4Test : public PinnableSlice {
|
|
public:
|
|
void TestStringIsRegistered(std::string* s) {
|
|
ASSERT_TRUE(cleanup_.function == ReleaseStringHeap);
|
|
ASSERT_EQ(cleanup_.arg1, s);
|
|
ASSERT_EQ(cleanup_.arg2, nullptr);
|
|
ASSERT_EQ(cleanup_.next, nullptr);
|
|
}
|
|
};
|
|
|
|
// Putting the PinnableSlice tests here due to similarity to Cleanable tests
|
|
TEST_F(CleanableTest, PinnableSlice) {
|
|
int n2 = 2;
|
|
int res = 1;
|
|
const std::string const_str = "123";
|
|
|
|
{
|
|
res = 1;
|
|
PinnableSlice4Test value;
|
|
Slice slice(const_str);
|
|
value.PinSlice(slice, Multiplier, &res, &n2);
|
|
std::string str;
|
|
str.assign(value.data(), value.size());
|
|
ASSERT_EQ(const_str, str);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(2, res);
|
|
|
|
{
|
|
res = 1;
|
|
PinnableSlice4Test value;
|
|
Slice slice(const_str);
|
|
{
|
|
Cleanable c1;
|
|
c1.RegisterCleanup(Multiplier, &res, &n2); // res = 2;
|
|
value.PinSlice(slice, &c1);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(1, res); // cleanups must have be delegated to value
|
|
std::string str;
|
|
str.assign(value.data(), value.size());
|
|
ASSERT_EQ(const_str, str);
|
|
}
|
|
// ~Cleanable
|
|
ASSERT_EQ(2, res);
|
|
|
|
{
|
|
PinnableSlice4Test value;
|
|
Slice slice(const_str);
|
|
value.PinSelf(slice);
|
|
std::string str;
|
|
str.assign(value.data(), value.size());
|
|
ASSERT_EQ(const_str, str);
|
|
}
|
|
|
|
{
|
|
PinnableSlice4Test value;
|
|
std::string* self_str_ptr = value.GetSelf();
|
|
self_str_ptr->assign(const_str);
|
|
value.PinSelf();
|
|
std::string str;
|
|
str.assign(value.data(), value.size());
|
|
ASSERT_EQ(const_str, str);
|
|
}
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
rocksdb::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|