mirror of
https://github.com/facebook/rocksdb.git
synced 2024-12-01 07:15:51 +00:00
d3ed796855
Summary: The old `StackableDB` based BlobDB implementation relies on a DB listener to track the total size of the SST files in the database and to trigger FIFO eviction. Some test cases in `BlobDBTest` assume that the listener is notified by the time `DB::Flush` returns, which is not guaranteed (side note: `TEST_WaitForFlushMemTable` would not guarantee this either). The patch fixes these tests by using `SyncPoint`s to make sure the listener is actually called before verifying the FIFO behavior. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11417 Test Plan: ``` make -j56 COERCE_CONTEXT_SWITCH=1 blob_db_test ./blob_db_test --gtest_filter=BlobDBTest.FIFOEviction_TriggerOnSSTSizeChange ./blob_db_test --gtest_filter=BlobDBTest.FilterForFIFOEviction ./blob_db_test --gtest_filter=BlobDBTest.FIFOEviction_NoEnoughBlobFilesToEvict ``` Reviewed By: ajkr Differential Revision: D45407135 Pulled By: ltamasi fbshipit-source-id: fcd63d76937d2c975f569a6635ce8730772a3d75 |
||
|---|---|---|
| .. | ||
| blob_compaction_filter.cc | ||
| blob_compaction_filter.h | ||
| blob_db.cc | ||
| blob_db.h | ||
| blob_db_gc_stats.h | ||
| blob_db_impl.cc | ||
| blob_db_impl.h | ||
| blob_db_impl_filesnapshot.cc | ||
| blob_db_iterator.h | ||
| blob_db_listener.h | ||
| blob_db_test.cc | ||
| blob_dump_tool.cc | ||
| blob_dump_tool.h | ||
| blob_file.cc | ||
| blob_file.h | ||