mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
ac24f152a1
Summary: This is setting up for a fix to a data race in SetOptions on BlockBasedTableOptions (BBTO), https://github.com/facebook/rocksdb/issues/10079 The race will be fixed by replacing `table_factory` with a modified copy whenever we want to modify a BBTO field. An argument could be made that this change creates more entaglement between features (e.g. BlobSource <-> MutableCFOptions), rather than (conceptually) minimizing the dependencies of each feature, but * Most of these things already depended on ImmutableOptions * Historically there has been a lot of plumbing (and possible small CPU overhead) involved in adding features that need to reach a lot of places, like `block_protection_bytes_per_key`. Keeping those wrapped up in options simplifies that. * SuperVersion management generally takes care of lifetime management of MutableCFOptions, so is not that difficult. (Crash test agrees so far.) There are some FIXME places where it is known to be unsafe to replace `block_cache` unless/until we handle shared_ptr tracking properly. HOWEVER, replacing `block_cache` is generally dubious, at least while existing users of the old block cache (e.g. table readers) can continue indefinitely. The change to cf_options.cc is essentially just moving code (not changing). I'm not concerned about the performance of copying another shared_ptr with MutableCFOptions, but I left a note about considering an improvement if more shared_ptr are added to it. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13077 Test Plan: existing tests, crash test. Unit test DBOptionsTest.GetLatestCFOptions updated with some temporary logic. MemoryTest required some refactoring (simplification) for the change. Reviewed By: cbi42 Differential Revision: D64546903 Pulled By: pdillinger fbshipit-source-id: 69ae97ce5cf4c01b58edc4c5d4687eb1e5bf5855
142 lines
5.8 KiB
C++
142 lines
5.8 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
//
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
|
|
#include "db/version_edit.h"
|
|
#include "rocksdb/file_system.h"
|
|
#include "rocksdb/metadata.h"
|
|
#include "rocksdb/slice_transform.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
struct ImmutableCFOptions;
|
|
class TableCache;
|
|
class VersionStorageInfo;
|
|
class VersionEdit;
|
|
struct FileMetaData;
|
|
class InternalStats;
|
|
class Version;
|
|
class VersionSet;
|
|
class VersionEditHandler;
|
|
class ColumnFamilyData;
|
|
class CacheReservationManager;
|
|
|
|
// A helper class so we can efficiently apply a whole sequence
|
|
// of edits to a particular state without creating intermediate
|
|
// Versions that contain full copies of the intermediate state.
|
|
class VersionBuilder {
|
|
public:
|
|
VersionBuilder(const FileOptions& file_options,
|
|
const ImmutableCFOptions* ioptions, TableCache* table_cache,
|
|
VersionStorageInfo* base_vstorage, VersionSet* version_set,
|
|
std::shared_ptr<CacheReservationManager>
|
|
file_metadata_cache_res_mgr = nullptr,
|
|
ColumnFamilyData* cfd = nullptr,
|
|
VersionEditHandler* version_edit_handler = nullptr,
|
|
bool track_found_and_missing_files = false,
|
|
bool allow_incomplete_valid_version = false);
|
|
~VersionBuilder();
|
|
|
|
bool CheckConsistencyForNumLevels();
|
|
|
|
Status Apply(const VersionEdit* edit);
|
|
|
|
// Save the current Version to the provided `vstorage`.
|
|
Status SaveTo(VersionStorageInfo* vstorage) const;
|
|
|
|
// Load all the table handlers for the current Version in the builder.
|
|
Status LoadTableHandlers(InternalStats* internal_stats, int max_threads,
|
|
bool prefetch_index_and_filter_in_cache,
|
|
bool is_initial_load,
|
|
const MutableCFOptions& mutable_cf_options,
|
|
size_t max_file_size_for_l0_meta_pin,
|
|
const ReadOptions& read_options);
|
|
|
|
//============APIs only used by VersionEditHandlerPointInTime ============//
|
|
|
|
// Creates a save point for the Version that has been built so far. Subsequent
|
|
// VersionEdits applied to the builder will not affect the Version in this
|
|
// save point. VersionBuilder currently only supports creating one save point,
|
|
// so when `CreateOrReplaceSavePoint` is called again, the previous save point
|
|
// is cleared. `ClearSavePoint` can be called explicitly to clear
|
|
// the save point too.
|
|
void CreateOrReplaceSavePoint();
|
|
|
|
// The builder can find all the files to build a `Version`. Or if
|
|
// `allow_incomplete_valid_version_` is true and the version history is never
|
|
// edited in an atomic group, and only a suffix of L0 SST files and their
|
|
// associated blob files are missing.
|
|
// From the users' perspective, missing a suffix of L0 files means missing the
|
|
// user's most recently written data. So the remaining available files still
|
|
// presents a valid point in time view, although for some previous time.
|
|
// This validity check result will be cached and reused if the Version is not
|
|
// updated between two validity checks.
|
|
bool ValidVersionAvailable();
|
|
|
|
bool HasMissingFiles() const;
|
|
|
|
// When applying a sequence of VersionEdit, intermediate files are the ones
|
|
// that are added and then deleted. The caller should clear this intermediate
|
|
// files tracking after calling this API. So that the tracking for subsequent
|
|
// VersionEdits can start over with a clean state.
|
|
std::vector<std::string>& GetAndClearIntermediateFiles();
|
|
|
|
// Clearing all the found files in this Version.
|
|
void ClearFoundFiles();
|
|
|
|
// Save the Version in the save point to the provided `vstorage`.
|
|
// Non-OK status will be returned if there is not a valid save point.
|
|
Status SaveSavePointTo(VersionStorageInfo* vstorage) const;
|
|
|
|
// Load all the table handlers for the Version in the save point.
|
|
// Non-OK status will be returned if there is not a valid save point.
|
|
Status LoadSavePointTableHandlers(InternalStats* internal_stats,
|
|
int max_threads,
|
|
bool prefetch_index_and_filter_in_cache,
|
|
bool is_initial_load,
|
|
const MutableCFOptions& mutable_cf_options,
|
|
size_t max_file_size_for_l0_meta_pin,
|
|
const ReadOptions& read_options);
|
|
|
|
void ClearSavePoint();
|
|
|
|
//======= End of APIs only used by VersionEditPointInTime==========//
|
|
|
|
private:
|
|
class Rep;
|
|
std::unique_ptr<Rep> savepoint_;
|
|
std::unique_ptr<Rep> rep_;
|
|
};
|
|
|
|
// A wrapper of version builder which references the current version in
|
|
// constructor and unref it in the destructor.
|
|
// Both of the constructor and destructor need to be called inside DB Mutex.
|
|
class BaseReferencedVersionBuilder {
|
|
public:
|
|
explicit BaseReferencedVersionBuilder(
|
|
ColumnFamilyData* cfd, VersionEditHandler* version_edit_handler = nullptr,
|
|
bool track_found_and_missing_files = false,
|
|
bool allow_incomplete_valid_version = false);
|
|
BaseReferencedVersionBuilder(
|
|
ColumnFamilyData* cfd, Version* v,
|
|
VersionEditHandler* version_edit_handler = nullptr,
|
|
bool track_found_and_missing_files = false,
|
|
bool allow_incomplete_valid_version = false);
|
|
~BaseReferencedVersionBuilder();
|
|
VersionBuilder* version_builder() const { return version_builder_.get(); }
|
|
|
|
private:
|
|
std::unique_ptr<VersionBuilder> version_builder_;
|
|
Version* version_;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|