mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
917e98ff9e
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/13052 Currently, `MultiCfIteratorImpl` uses `std::function`s for `reset_func_` and `populate_func_`, which uses type erasure and has a performance overhead. The patch turns `MultiCfIteratorImpl` into a template that takes the two function object types as template parameters, and changes `AttributeGroupIteratorImpl` and `CoalescingIterator` so they pass in function objects of named types (as opposed to lambdas). Reviewed By: jaykorean Differential Revision: D63802598 fbshipit-source-id: e202f6d80c9054335e5b2571051a67a9e012c2d0
103 lines
2.8 KiB
C++
103 lines
2.8 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "db/multi_cf_iterator_impl.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// EXPERIMENTAL
|
|
class CoalescingIterator : public Iterator {
|
|
public:
|
|
CoalescingIterator(const Comparator* comparator,
|
|
const std::vector<ColumnFamilyHandle*>& column_families,
|
|
const std::vector<Iterator*>& child_iterators)
|
|
: impl_(comparator, column_families, child_iterators, ResetFunc(this),
|
|
PopulateFunc(this)) {}
|
|
~CoalescingIterator() override {}
|
|
|
|
// No copy allowed
|
|
CoalescingIterator(const CoalescingIterator&) = delete;
|
|
CoalescingIterator& operator=(const CoalescingIterator&) = delete;
|
|
|
|
bool Valid() const override { return impl_.Valid(); }
|
|
void SeekToFirst() override { impl_.SeekToFirst(); }
|
|
void SeekToLast() override { impl_.SeekToLast(); }
|
|
void Seek(const Slice& target) override { impl_.Seek(target); }
|
|
void SeekForPrev(const Slice& target) override { impl_.SeekForPrev(target); }
|
|
void Next() override { impl_.Next(); }
|
|
void Prev() override { impl_.Prev(); }
|
|
Slice key() const override { return impl_.key(); }
|
|
Status status() const override { return impl_.status(); }
|
|
|
|
Slice value() const override {
|
|
assert(Valid());
|
|
return value_;
|
|
}
|
|
const WideColumns& columns() const override {
|
|
assert(Valid());
|
|
return wide_columns_;
|
|
}
|
|
|
|
void Reset() {
|
|
value_.clear();
|
|
wide_columns_.clear();
|
|
}
|
|
|
|
private:
|
|
class ResetFunc {
|
|
public:
|
|
explicit ResetFunc(CoalescingIterator* iter) : iter_(iter) {}
|
|
|
|
void operator()() const {
|
|
assert(iter_);
|
|
iter_->Reset();
|
|
}
|
|
|
|
private:
|
|
CoalescingIterator* iter_;
|
|
};
|
|
|
|
class PopulateFunc {
|
|
public:
|
|
explicit PopulateFunc(CoalescingIterator* iter) : iter_(iter) {}
|
|
|
|
void operator()(const autovector<MultiCfIteratorInfo>& items) const {
|
|
assert(iter_);
|
|
iter_->Coalesce(items);
|
|
}
|
|
|
|
private:
|
|
CoalescingIterator* iter_;
|
|
};
|
|
|
|
MultiCfIteratorImpl<ResetFunc, PopulateFunc> impl_;
|
|
Slice value_;
|
|
WideColumns wide_columns_;
|
|
|
|
struct WideColumnWithOrder {
|
|
const WideColumn* column;
|
|
int order;
|
|
};
|
|
|
|
class WideColumnWithOrderComparator {
|
|
public:
|
|
explicit WideColumnWithOrderComparator() {}
|
|
bool operator()(const WideColumnWithOrder& a,
|
|
const WideColumnWithOrder& b) const {
|
|
int c = a.column->name().compare(b.column->name());
|
|
return c == 0 ? a.order - b.order > 0 : c > 0;
|
|
}
|
|
};
|
|
|
|
using MinHeap =
|
|
BinaryHeap<WideColumnWithOrder, WideColumnWithOrderComparator>;
|
|
|
|
void Coalesce(const autovector<MultiCfIteratorInfo>& items);
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|