Cheng Chang 40497a875a Reduce memory copies when fetching and uncompressing blocks from SST files (#6689) ... Summary: In https://github.com/facebook/rocksdb/pull/6455, we modified the interface of `RandomAccessFileReader::Read` to be able to get rid of memcpy in direct IO mode. This PR applies the new interface to `BlockFetcher` when reading blocks from SST files in direct IO mode. Without this PR, in direct IO mode, when fetching and uncompressing compressed blocks, `BlockFetcher` will first copy the raw compressed block into `BlockFetcher::compressed_buf_` or `BlockFetcher::stack_buf_` inside `RandomAccessFileReader::Read` depending on the block size. then during uncompressing, it will copy the uncompressed block into `BlockFetcher::heap_buf_`. In this PR, we get rid of the first memcpy and directly uncompress the block from `direct_io_buf_` to `heap_buf_`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6689 Test Plan: A new unit test `block_fetcher_test` is added. Reviewed By: anand1976 Differential Revision: D21006729 Pulled By: cheng-chang fbshipit-source-id: 2370b92c24075692423b81277415feb2aed5d980		2020-04-24 15:32:56 -07:00
..
adaptive	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based	Silence false alarms in db_stress fault injection (#6741)	2020-04-24 13:06:12 -07:00
cuckoo	Add a ConfigOptions for use in comparing objects and converting to/from strings (#6389)	2020-04-21 17:38:17 -07:00
plain	Add a ConfigOptions for use in comparing objects and converting to/from strings (#6389)	2020-04-21 17:38:17 -07:00
block_fetcher.cc	Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)	2020-04-24 15:32:56 -07:00
block_fetcher.h	Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)	2020-04-24 15:32:56 -07:00
block_fetcher_test.cc	Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)	2020-04-24 15:32:56 -07:00
cleanable_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
format.cc	Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)	2020-04-24 15:32:56 -07:00
format.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
get_context.cc	return timestamp from get (#6409)	2020-03-02 16:01:00 -08:00
get_context.h	return timestamp from get (#6409)	2020-03-02 16:01:00 -08:00
internal_iterator.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
iter_heap.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
iterator_wrapper.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
merger_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
merging_iterator.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
merging_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
meta_blocks.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
meta_blocks.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
mock_table.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
mock_table.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
multiget_context.h	multiget support for timestamps (#6483)	2020-03-24 11:24:09 -07:00
persistent_cache_helper.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
persistent_cache_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
persistent_cache_options.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_reader.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_reader_test.cc	Allow table/sst_file_reader_test.cc to use custom Env (#6536)	2020-03-17 11:02:13 -07:00
sst_file_writer.cc	Make options.bottommost_compression, compression_opts and bottommost_compression_opts dynamically changeable. (#6615)	2020-03-31 12:11:42 -07:00
sst_file_writer_collectors.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_builder.h	In block based table builder, make variables for estimating file size atomic (#6636)	2020-04-02 16:16:24 -07:00
table_properties.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_properties_internal.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_reader.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
table_reader_bench.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_reader_caller.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_test.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
two_level_iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
two_level_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00