rocksdb/memtable
Siying Dong beb44ec3eb WriteBufferManager's dummy entry size to block cache 1MB -> 256KB (#5175)
Summary:
Dummy cache size of 1MB is too large for small block sizes. Our GetDefaultCacheShardBits() use min_shard_size = 512L * 1024L to determine number of shards, so 1MB will excceeds the size of the whole shard and make the cache excceeds the budget.
Change it to 256KB accordingly.
There shouldn't be obvious performance impact, since inserting a cache entry every 256KB of memtable inserts is still infrequently enough.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5175

Differential Revision: D14954289

Pulled By: siying

fbshipit-source-id: 2c275255c1ac3992174e06529e44c55538325c94
2019-04-16 12:03:07 -07:00
..
alloc_tracker.cc WriteBufferManger doens't cost to cache if no limit is set (#4695) 2018-11-18 16:55:43 -08:00
hash_linklist_rep.cc Consolidate hash function used for non-persistent data in a new function (#5155) 2019-04-08 13:32:06 -07:00
hash_linklist_rep.h Change RocksDB License 2017-07-15 16:11:23 -07:00
hash_skiplist_rep.cc Apply modernize-use-override (2nd iteration) 2019-02-14 14:41:36 -08:00
hash_skiplist_rep.h Change RocksDB License 2017-07-15 16:11:23 -07:00
inlineskiplist.h Reorder field based on esan data 2018-05-17 17:57:48 -07:00
inlineskiplist_test.cc Remove tests from ROCKSDB_VALGRIND_RUN 2018-05-30 16:15:16 -07:00
memtablerep_bench.cc Remove cuckoo hash memtable (#4953) 2019-02-07 16:15:27 -08:00
skiplist.h Enable MSVC W4 with a few exceptions. Fix warnings and bugs 2017-10-19 10:57:12 -07:00
skiplist_test.cc Introduce bottom-pri thread pool for large universal compactions 2017-08-03 15:43:29 -07:00
skiplistrep.cc Apply modernize-use-override (2nd iteration) 2019-02-14 14:41:36 -08:00
stl_wrappers.h Consolidate hash function used for non-persistent data in a new function (#5155) 2019-04-08 13:32:06 -07:00
vectorrep.cc Apply modernize-use-override (2nd iteration) 2019-02-14 14:41:36 -08:00
write_buffer_manager.cc WriteBufferManager's dummy entry size to block cache 1MB -> 256KB (#5175) 2019-04-16 12:03:07 -07:00
write_buffer_manager_test.cc WriteBufferManager's dummy entry size to block cache 1MB -> 256KB (#5175) 2019-04-16 12:03:07 -07:00