mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
05e8854085
Summary: This diff introduces a new Merge operation into rocksdb. The purpose of this review is mostly getting feedback from the team (everyone please) on the design. Please focus on the four files under include/leveldb/, as they spell the client visible interface change. include/leveldb/db.h include/leveldb/merge_operator.h include/leveldb/options.h include/leveldb/write_batch.h Please go over local/my_test.cc carefully, as it is a concerete use case. Please also review the impelmentation files to see if the straw man implementation makes sense. Note that, the diff does pass all make check and truly supports forward iterator over db and a version of Get that's based on iterator. Future work: - Integration with compaction - A raw Get implementation I am working on a wiki that explains the design and implementation choices, but coding comes just naturally and I think it might be a good idea to share the code earlier. The code is heavily commented. Test Plan: run all local tests Reviewers: dhruba, heyongqiang Reviewed By: dhruba CC: leveldb, zshao, sheki, emayanke, MarkCallaghan Differential Revision: https://reviews.facebook.net/D9651
79 lines
2 KiB
C++
79 lines
2 KiB
C++
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include <stdio.h>
|
|
#include "port/port.h"
|
|
#include "leveldb/status.h"
|
|
|
|
namespace leveldb {
|
|
|
|
const char* Status::CopyState(const char* state) {
|
|
uint32_t size;
|
|
memcpy(&size, state, sizeof(size));
|
|
char* result = new char[size + 5];
|
|
memcpy(result, state, size + 5);
|
|
return result;
|
|
}
|
|
|
|
Status::Status(Code code, const Slice& msg, const Slice& msg2) {
|
|
assert(code != kOk);
|
|
const uint32_t len1 = msg.size();
|
|
const uint32_t len2 = msg2.size();
|
|
const uint32_t size = len1 + (len2 ? (2 + len2) : 0);
|
|
char* result = new char[size + 5];
|
|
memcpy(result, &size, sizeof(size));
|
|
result[4] = static_cast<char>(code);
|
|
memcpy(result + 5, msg.data(), len1);
|
|
if (len2) {
|
|
result[5 + len1] = ':';
|
|
result[6 + len1] = ' ';
|
|
memcpy(result + 7 + len1, msg2.data(), len2);
|
|
}
|
|
state_ = result;
|
|
}
|
|
|
|
std::string Status::ToString() const {
|
|
if (state_ == nullptr) {
|
|
return "OK";
|
|
} else {
|
|
char tmp[30];
|
|
const char* type;
|
|
switch (code()) {
|
|
case kOk:
|
|
type = "OK";
|
|
break;
|
|
case kNotFound:
|
|
type = "NotFound: ";
|
|
break;
|
|
case kCorruption:
|
|
type = "Corruption: ";
|
|
break;
|
|
case kNotSupported:
|
|
type = "Not implemented: ";
|
|
break;
|
|
case kInvalidArgument:
|
|
type = "Invalid argument: ";
|
|
break;
|
|
case kIOError:
|
|
type = "IO error: ";
|
|
break;
|
|
case kMergeInProgress:
|
|
type = "Merge In Progress: ";
|
|
break;
|
|
default:
|
|
snprintf(tmp, sizeof(tmp), "Unknown code(%d): ",
|
|
static_cast<int>(code()));
|
|
type = tmp;
|
|
break;
|
|
}
|
|
std::string result(type);
|
|
uint32_t length;
|
|
memcpy(&length, state_, sizeof(length));
|
|
result.append(state_ + 5, length);
|
|
return result;
|
|
}
|
|
}
|
|
|
|
} // namespace leveldb
|