mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
0f0a24e298
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
106 lines
3 KiB
C++
106 lines
3 KiB
C++
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "util/arena_impl.h"
|
|
#include "util/random.h"
|
|
#include "util/testharness.h"
|
|
|
|
namespace leveldb {
|
|
|
|
class ArenaImplTest { };
|
|
|
|
TEST(ArenaImplTest, Empty) {
|
|
ArenaImpl arena0;
|
|
}
|
|
|
|
TEST(ArenaImplTest, MemoryAllocatedBytes) {
|
|
const int N = 17;
|
|
size_t req_sz; //requested size
|
|
size_t bsz = 8192; // block size
|
|
size_t expected_memory_allocated;
|
|
|
|
ArenaImpl arena_impl(bsz);
|
|
|
|
// requested size > quarter of a block:
|
|
// allocate requested size separately
|
|
req_sz = 3001;
|
|
for (int i = 0; i < N; i++) {
|
|
arena_impl.Allocate(req_sz);
|
|
}
|
|
expected_memory_allocated = req_sz * N;
|
|
ASSERT_EQ(arena_impl.MemoryAllocatedBytes(), expected_memory_allocated);
|
|
|
|
// requested size < quarter of a block:
|
|
// allocate a block with the default size, then try to use unused part
|
|
// of the block. So one new block will be allocated for the first
|
|
// Allocate(99) call. All the remaining calls won't lead to new allocation.
|
|
req_sz = 99;
|
|
for (int i = 0; i < N; i++) {
|
|
arena_impl.Allocate(req_sz);
|
|
}
|
|
expected_memory_allocated += bsz;
|
|
ASSERT_EQ(arena_impl.MemoryAllocatedBytes(), expected_memory_allocated);
|
|
|
|
// requested size > quarter of a block:
|
|
// allocate requested size separately
|
|
req_sz = 99999999;
|
|
for (int i = 0; i < N; i++) {
|
|
arena_impl.Allocate(req_sz);
|
|
}
|
|
expected_memory_allocated += req_sz * N;
|
|
ASSERT_EQ(arena_impl.MemoryAllocatedBytes(), expected_memory_allocated);
|
|
}
|
|
|
|
TEST(ArenaImplTest, Simple) {
|
|
std::vector<std::pair<size_t, char*> > allocated;
|
|
ArenaImpl arena_impl;
|
|
const int N = 100000;
|
|
size_t bytes = 0;
|
|
Random rnd(301);
|
|
for (int i = 0; i < N; i++) {
|
|
size_t s;
|
|
if (i % (N / 10) == 0) {
|
|
s = i;
|
|
} else {
|
|
s = rnd.OneIn(4000) ? rnd.Uniform(6000) :
|
|
(rnd.OneIn(10) ? rnd.Uniform(100) : rnd.Uniform(20));
|
|
}
|
|
if (s == 0) {
|
|
// Our arena disallows size 0 allocations.
|
|
s = 1;
|
|
}
|
|
char* r;
|
|
if (rnd.OneIn(10)) {
|
|
r = arena_impl.AllocateAligned(s);
|
|
} else {
|
|
r = arena_impl.Allocate(s);
|
|
}
|
|
|
|
for (unsigned int b = 0; b < s; b++) {
|
|
// Fill the "i"th allocation with a known bit pattern
|
|
r[b] = i % 256;
|
|
}
|
|
bytes += s;
|
|
allocated.push_back(std::make_pair(s, r));
|
|
ASSERT_GE(arena_impl.ApproximateMemoryUsage(), bytes);
|
|
if (i > N/10) {
|
|
ASSERT_LE(arena_impl.ApproximateMemoryUsage(), bytes * 1.10);
|
|
}
|
|
}
|
|
for (unsigned int i = 0; i < allocated.size(); i++) {
|
|
size_t num_bytes = allocated[i].first;
|
|
const char* p = allocated[i].second;
|
|
for (unsigned int b = 0; b < num_bytes; b++) {
|
|
// Check the "i"th allocation for the known bit pattern
|
|
ASSERT_EQ(int(p[b]) & 0xff, (int)(i % 256));
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace leveldb
|
|
|
|
int main(int argc, char** argv) {
|
|
return leveldb::test::RunAllTests();
|
|
}
|