mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 02:44:18 +00:00
03b08ba9a9
Summary: WriteBatchWithIndex::GetFromBatchAndDB only works correctly for overwrite_key=false. Transactions use overwrite_key=true (since WriteBatchWithIndex::GetIteratorWithBase only works when overwrite_key=true). So currently, Transactions could return incorrectly merged results when calling Get/GetForUpdate(). Until a permanent fix can be put in place, Transaction::Get[ForUpdate] and WriteBatchWithIndex::GetFromBatch[AndDB] will now return MergeInProgress if the most recent write to a key in the batch is a Merge. Test Plan: more tests Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47817 |
||
|---|---|---|
| .. | ||
| optimistic_transaction_db_impl.cc | ||
| optimistic_transaction_db_impl.h | ||
| optimistic_transaction_impl.cc | ||
| optimistic_transaction_impl.h | ||
| optimistic_transaction_test.cc | ||
| transaction_base.cc | ||
| transaction_base.h | ||
| transaction_db_impl.cc | ||
| transaction_db_impl.h | ||
| transaction_db_mutex_impl.cc | ||
| transaction_db_mutex_impl.h | ||
| transaction_impl.cc | ||
| transaction_impl.h | ||
| transaction_lock_mgr.cc | ||
| transaction_lock_mgr.h | ||
| transaction_test.cc | ||
| transaction_util.cc | ||
| transaction_util.h | ||