Yanqin Jin 0304352882 Fix a bug in key comparison when index type is kBinarySearchWithFirstKey (#8062) ... Summary: When timestamp is enabled, key comparison should take this into account. In `BlockBasedTableReader::Get()`, `BlockBasedTableReader::MultiGet()`, assume the target key is `key`, and the timestamp upper bound is `ts`. The highest key in current block is (key, ts1), while the lowest key in next block is (key, ts2). If ``` ts1 > ts > ts2 ``` then ``` (key, ts1) < (key, ts) < (key, ts2) ``` It can be shown that if `Compare()` is used, then we will mistakenly skip the next block. Instead, we should use `CompareWithoutTimestamp()`. The majority of this PR makes some existing tests in `db_with_timestamp_basic_test.cc` parameterized so that different index types can be tested. A new unit test is also added for more coverage. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8062 Test Plan: make check Reviewed By: ltamasi Differential Revision: D27057557 Pulled By: riversand963 fbshipit-source-id: c1062fa7c159ed600a1ad7e461531d52265021f1		2021-03-15 17:44:52 -07:00
..
binary_search_index_reader.cc	Separate internal and user key comparators in BlockIter (#6944)	2020-07-07 17:26:16 -07:00
binary_search_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
block.cc	Remove unused includes (#7604)	2020-10-28 23:22:27 -07:00
block.h	Add EnvTestWithParam::OptionsTest to the ASSERT_STATUS_CHECKED passes (#7283)	2020-08-20 19:18:35 -07:00
block_based_filter_block.cc	Exclude timestamp from prefix extractor (#7668)	2020-12-01 14:07:15 -08:00
block_based_filter_block.h	Exclude timestamp from prefix extractor (#7668)	2020-12-01 14:07:15 -08:00
block_based_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_builder.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
block_based_table_builder.h	Limit buffering for collecting samples for compression dictionary (#7970)	2021-02-19 14:09:54 -08:00
block_based_table_factory.cc	Make BlockBasedTable::kMaxAutoReadAheadSize configurable (#7951)	2021-02-23 16:54:08 -08:00
block_based_table_factory.h	Create a Customizable class to load classes and configurations (#6590)	2020-11-11 15:10:41 -08:00
block_based_table_iterator.cc	Clean up InternalIterator upper bound logic a little bit (#7200)	2020-08-05 10:44:57 -07:00
block_based_table_iterator.h	Exclude timestamp from prefix extractor (#7668)	2020-12-01 14:07:15 -08:00
block_based_table_reader.cc	Fix a bug in key comparison when index type is kBinarySearchWithFirstKey (#8062)	2021-03-15 17:44:52 -07:00
block_based_table_reader.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
block_based_table_reader_impl.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
block_based_table_reader_test.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
block_builder.cc	Add pipelined & parallel compression optimization (#6262)	2020-04-01 16:40:18 -07:00
block_builder.h	Add pipelined & parallel compression optimization (#6262)	2020-04-01 16:40:18 -07:00
block_prefetcher.cc	Make BlockBasedTable::kMaxAutoReadAheadSize configurable (#7951)	2021-02-23 16:54:08 -08:00
block_prefetcher.h	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_test.cc	More Makefile Cleanup (#7097)	2020-07-09 14:35:17 -07:00
block_type.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
cachable_entry.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index_test.cc	Make StringEnv, StringSink, StringSource use FS classes (#7786)	2021-01-04 16:01:01 -08:00
filter_block.h	Exclude timestamp from prefix extractor (#7668)	2020-12-01 14:07:15 -08:00
filter_block_reader_common.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_policy.cc	Refine Ribbon configuration, improve testing, add Homogeneous (#7879)	2021-02-26 08:50:42 -08:00
filter_policy_internal.h	Support optimize_filters_for_memory for Ribbon filter (#7774)	2020-12-18 14:31:03 -08:00
flush_block_policy.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
flush_block_policy.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
full_filter_block.cc	Exclude timestamp from prefix extractor (#7668)	2020-12-01 14:07:15 -08:00
full_filter_block.h	Exclude timestamp from prefix extractor (#7668)	2020-12-01 14:07:15 -08:00
full_filter_block_test.cc	Use size_t for filter APIs, protect against overflow (#7726)	2020-12-11 22:18:12 -08:00
hash_index_reader.cc	Separate internal and user key comparators in BlockIter (#6944)	2020-07-07 17:26:16 -07:00
hash_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
index_builder.cc	Move break into block (#7468)	2020-09-30 20:24:23 -07:00
index_builder.h	Make db_basic_test pass assert status checked (#7452)	2020-09-29 09:49:04 -07:00
index_reader_common.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
index_reader_common.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
mock_block_based_table.h	For ApproximateSizes, pro-rate table metadata size over data blocks (#6784)	2020-06-02 12:30:23 -07:00
parsed_full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
parsed_full_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
partitioned_filter_block.cc	Add a SystemClock class to capture the time functions of an Env (#7858)	2021-01-25 22:09:11 -08:00
partitioned_filter_block.h	Return error if Get/Multi() fails in Prefetching Filter blocks (#7543)	2020-10-14 10:45:36 -07:00
partitioned_filter_block_test.cc	Remove unused includes (#7604)	2020-10-28 23:22:27 -07:00
partitioned_index_iterator.cc	Fix misspelling of PartitionedIndexIterator (#7450)	2020-09-29 16:28:13 -07:00
partitioned_index_iterator.h	Fix misspelling of PartitionedIndexIterator (#7450)	2020-09-29 16:28:13 -07:00
partitioned_index_reader.cc	Add a SystemClock class to capture the time functions of an Env (#7858)	2021-01-25 22:09:11 -08:00
partitioned_index_reader.h	Get() to fail with underlying failures in PartitionIndexReader::CacheDependencies() (#7297)	2020-08-25 19:01:05 -07:00
reader_common.cc	Fix block checksum for >=4GB, refactor (#6978)	2020-06-19 16:18:24 -07:00
reader_common.h	Bring the Configurable options together (#5753)	2020-09-14 17:01:01 -07:00
uncompression_dict_reader.cc	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
uncompression_dict_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00