mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 14:31:35 +00:00
0ae3d9f98d
Summary: A `BlockBasedTable` with `TieredSecondaryCache` containing a NVM cache inserts blocks into the compressed cache and the corresponding compressed block into the NVM cache. The `BlockFetcher` is used to get the uncompressed and compressed blocks by calling `ReadBlockContents()` and `GetUncompressedBlock()` respectively. If the file system supports FSBuffer (i.e returning a FS allocated buffer rather than caller provided), that buffer gets freed between the two calls. This PR fixes it by making the FSBuffer unique pointer a member rather than local variable. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12712 Test Plan: 1. Add a unit test 2. Release validation stress test Reviewed By: jaykorean Differential Revision: D57974026 Pulled By: anand1976 fbshipit-source-id: cfa895914e74b4f628413b40e6e39d8d8e5286bd |
||
|---|---|---|
| .. | ||
| cache.cc | ||
| cache_bench.cc | ||
| cache_bench_tool.cc | ||
| cache_entry_roles.cc | ||
| cache_entry_roles.h | ||
| cache_entry_stats.h | ||
| cache_helpers.cc | ||
| cache_helpers.h | ||
| cache_key.cc | ||
| cache_key.h | ||
| cache_reservation_manager.cc | ||
| cache_reservation_manager.h | ||
| cache_reservation_manager_test.cc | ||
| cache_test.cc | ||
| charged_cache.cc | ||
| charged_cache.h | ||
| clock_cache.cc | ||
| clock_cache.h | ||
| compressed_secondary_cache.cc | ||
| compressed_secondary_cache.h | ||
| compressed_secondary_cache_test.cc | ||
| lru_cache.cc | ||
| lru_cache.h | ||
| lru_cache_test.cc | ||
| secondary_cache.cc | ||
| secondary_cache_adapter.cc | ||
| secondary_cache_adapter.h | ||
| sharded_cache.cc | ||
| sharded_cache.h | ||
| tiered_secondary_cache.cc | ||
| tiered_secondary_cache.h | ||
| tiered_secondary_cache_test.cc | ||
| typed_cache.h | ||