mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 11:43:49 +00:00
df9069d23f
Summary: In this patch, try to allocate the whole iterator tree starting from DBIter from an arena 1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it. 2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator. 3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it. Limitations: (1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc (2) Two level iterator itself is allocated in arena, but not iterators inside it. Test Plan: make all check Reviewers: ljin, haobo Reviewed By: haobo Subscribers: leveldb, dhruba, yhchiang, igor Differential Revision: https://reviews.facebook.net/D18513
82 lines
2.6 KiB
C++
82 lines
2.6 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/iterator.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
// A internal wrapper class with an interface similar to Iterator that
|
|
// caches the valid() and key() results for an underlying iterator.
|
|
// This can help avoid virtual function calls and also gives better
|
|
// cache locality.
|
|
class IteratorWrapper {
|
|
public:
|
|
IteratorWrapper(): iter_(nullptr), valid_(false) { }
|
|
explicit IteratorWrapper(Iterator* iter): iter_(nullptr) {
|
|
Set(iter);
|
|
}
|
|
~IteratorWrapper() {}
|
|
Iterator* iter() const { return iter_; }
|
|
|
|
// Takes ownership of "iter" and will delete it when destroyed, or
|
|
// when Set() is invoked again.
|
|
void Set(Iterator* iter) {
|
|
delete iter_;
|
|
iter_ = iter;
|
|
if (iter_ == nullptr) {
|
|
valid_ = false;
|
|
} else {
|
|
Update();
|
|
}
|
|
}
|
|
|
|
void DeleteIter(bool is_arena_mode) {
|
|
if (!is_arena_mode) {
|
|
delete iter_;
|
|
} else {
|
|
iter_->~Iterator();
|
|
}
|
|
}
|
|
|
|
// Iterator interface methods
|
|
bool Valid() const { return valid_; }
|
|
Slice key() const { assert(Valid()); return key_; }
|
|
Slice value() const { assert(Valid()); return iter_->value(); }
|
|
// Methods below require iter() != nullptr
|
|
Status status() const { assert(iter_); return iter_->status(); }
|
|
void Next() { assert(iter_); iter_->Next(); Update(); }
|
|
void Prev() { assert(iter_); iter_->Prev(); Update(); }
|
|
void Seek(const Slice& k) { assert(iter_); iter_->Seek(k); Update(); }
|
|
void SeekToFirst() { assert(iter_); iter_->SeekToFirst(); Update(); }
|
|
void SeekToLast() { assert(iter_); iter_->SeekToLast(); Update(); }
|
|
|
|
private:
|
|
void Update() {
|
|
valid_ = iter_->Valid();
|
|
if (valid_) {
|
|
key_ = iter_->key();
|
|
}
|
|
}
|
|
|
|
Iterator* iter_;
|
|
bool valid_;
|
|
Slice key_;
|
|
};
|
|
|
|
class Arena;
|
|
// Return an empty iterator (yields nothing) allocated from arena.
|
|
extern Iterator* NewEmptyIterator(Arena* arena);
|
|
|
|
// Return an empty iterator with the specified status, allocated arena.
|
|
extern Iterator* NewErrorIterator(const Status& status, Arena* arena);
|
|
|
|
} // namespace rocksdb
|