mirror of https://github.com/facebook/rocksdb.git
e9b15738d9
Summary: `OptionTypeInfo::ParseStruct()` was not honoring `config_options.ignore_unknown_options` when unknown properties are found in the serialized string. This caused a compatibility issue in Remote Compaction. When the worker was updated with RocksDB 9.9, the remote worker started including a new table property, `newest_key_time` (added in PR https://github.com/facebook/rocksdb/issues/13083), in the compaction output files. However, parsing that table property in the serialized compaction result from the primary (running with `9.8`) was returning a non-ok status, even though `config_options.ignore_unknown_options` was `true`. In this fix, we will ignore unused properties if `config_options.ignore_unknown_options` is set to true. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13152 Test Plan: Unit Test Added Reviewed By: archang19 Differential Revision: D66374541 Pulled By: jaykorean fbshipit-source-id: 78fd8309909279390438c247c4d390bbee4fa914 |
||
---|---|---|
.. | ||
.gitkeep | ||
parse_struct_ignore_unknown_options.md |