mirror of
https://github.com/facebook/rocksdb.git
synced 2024-12-04 20:02:50 +00:00
c6c683a0ca
Summary: Disabling file deletion can be critical for operations like making a backup, recovery from manifest IO error (for now). Ideally as long as there is one caller requesting file deletion disabled, it should be kept disabled until all callers agree to re-enable it. So this PR removes the default forcing behavior for the `EnableFileDeletion` API, and users need to explicitly pass the argument if they insisted on doing so knowing the consequence of what can be potentially disrupted. This PR removes the API's default argument value so it will cause breakage for all users that are relying on the default value, regardless of whether the forcing behavior is critical for them. When fixing this breakage, it's good to check if the forcing behavior is indeed needed and potential disruption is OK. This PR also makes unit test that do not need force behavior to do a regular enable file deletion. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12001 Reviewed By: ajkr Differential Revision: D51214683 Pulled By: jowlyzhang fbshipit-source-id: ca7b1ebf15c09eed00f954da2f75c00d2c6a97e4
333 lines
11 KiB
C++
333 lines
11 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
// Introduction of SyncPoint effectively disabled building and running this test
|
|
// in Release build.
|
|
// which is a pity, it is a good test
|
|
|
|
#include "db/db_test_util.h"
|
|
#include "env/mock_env.h"
|
|
#include "port/stack_trace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class DBTestXactLogIterator : public DBTestBase {
|
|
public:
|
|
DBTestXactLogIterator()
|
|
: DBTestBase("db_log_iter_test", /*env_do_fsync=*/true) {}
|
|
|
|
std::unique_ptr<TransactionLogIterator> OpenTransactionLogIter(
|
|
const SequenceNumber seq) {
|
|
std::unique_ptr<TransactionLogIterator> iter;
|
|
Status status = dbfull()->GetUpdatesSince(seq, &iter);
|
|
EXPECT_OK(status);
|
|
EXPECT_TRUE(iter->Valid());
|
|
return iter;
|
|
}
|
|
};
|
|
|
|
namespace {
|
|
SequenceNumber ReadRecords(std::unique_ptr<TransactionLogIterator>& iter,
|
|
int& count, bool expect_ok = true) {
|
|
count = 0;
|
|
SequenceNumber lastSequence = 0;
|
|
BatchResult res;
|
|
while (iter->Valid()) {
|
|
res = iter->GetBatch();
|
|
EXPECT_TRUE(res.sequence > lastSequence);
|
|
++count;
|
|
lastSequence = res.sequence;
|
|
EXPECT_OK(iter->status());
|
|
iter->Next();
|
|
}
|
|
if (expect_ok) {
|
|
EXPECT_OK(iter->status());
|
|
} else {
|
|
EXPECT_NOK(iter->status());
|
|
}
|
|
return res.sequence;
|
|
}
|
|
|
|
void ExpectRecords(const int expected_no_records,
|
|
std::unique_ptr<TransactionLogIterator>& iter) {
|
|
int num_records;
|
|
ReadRecords(iter, num_records);
|
|
ASSERT_EQ(num_records, expected_no_records);
|
|
}
|
|
} // anonymous namespace
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIterator) {
|
|
do {
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
ASSERT_OK(Put(0, "key1", DummyString(1024)));
|
|
ASSERT_OK(Put(1, "key2", DummyString(1024)));
|
|
ASSERT_OK(Put(1, "key2", DummyString(1024)));
|
|
ASSERT_EQ(dbfull()->GetLatestSequenceNumber(), 3U);
|
|
{
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ExpectRecords(3, iter);
|
|
}
|
|
ReopenWithColumnFamilies({"default", "pikachu"}, options);
|
|
env_->SleepForMicroseconds(2 * 1000 * 1000);
|
|
{
|
|
ASSERT_OK(Put(0, "key4", DummyString(1024)));
|
|
ASSERT_OK(Put(1, "key5", DummyString(1024)));
|
|
ASSERT_OK(Put(0, "key6", DummyString(1024)));
|
|
}
|
|
{
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ExpectRecords(6, iter);
|
|
}
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
#ifndef NDEBUG // sync point is not included with DNDEBUG build
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorRace) {
|
|
static const int LOG_ITERATOR_RACE_TEST_COUNT = 2;
|
|
static const char* sync_points[LOG_ITERATOR_RACE_TEST_COUNT][4] = {
|
|
{"WalManager::GetSortedWalFiles:1", "WalManager::PurgeObsoleteFiles:1",
|
|
"WalManager::PurgeObsoleteFiles:2", "WalManager::GetSortedWalFiles:2"},
|
|
{"WalManager::GetSortedWalsOfType:1", "WalManager::PurgeObsoleteFiles:1",
|
|
"WalManager::PurgeObsoleteFiles:2",
|
|
"WalManager::GetSortedWalsOfType:2"}};
|
|
for (int test = 0; test < LOG_ITERATOR_RACE_TEST_COUNT; ++test) {
|
|
// Setup sync point dependency to reproduce the race condition of
|
|
// a log file moved to archived dir, in the middle of GetSortedWalFiles
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
|
|
{sync_points[test][0], sync_points[test][1]},
|
|
{sync_points[test][2], sync_points[test][3]},
|
|
});
|
|
|
|
do {
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace();
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
ASSERT_OK(Put("key1", DummyString(1024)));
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
ASSERT_OK(Put("key2", DummyString(1024)));
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
ASSERT_OK(Put("key3", DummyString(1024)));
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
ASSERT_OK(Put("key4", DummyString(1024)));
|
|
ASSERT_EQ(dbfull()->GetLatestSequenceNumber(), 4U);
|
|
ASSERT_OK(dbfull()->FlushWAL(false));
|
|
|
|
{
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ExpectRecords(4, iter);
|
|
}
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
|
|
// trigger async flush, and log move. Well, log move will
|
|
// wait until the GetSortedWalFiles:1 to reproduce the race
|
|
// condition
|
|
FlushOptions flush_options;
|
|
flush_options.wait = false;
|
|
ASSERT_OK(dbfull()->Flush(flush_options));
|
|
|
|
// "key5" would be written in a new memtable and log
|
|
ASSERT_OK(Put("key5", DummyString(1024)));
|
|
ASSERT_OK(dbfull()->FlushWAL(false));
|
|
{
|
|
// this iter would miss "key4" if not fixed
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ExpectRecords(5, iter);
|
|
}
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
}
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorCheckWhenArchive) {
|
|
do {
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace();
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
ColumnFamilyHandle* cf;
|
|
auto s = dbfull()->CreateColumnFamily(ColumnFamilyOptions(), "CF", &cf);
|
|
ASSERT_TRUE(s.ok());
|
|
|
|
ASSERT_OK(dbfull()->Put(WriteOptions(), cf, "key1", DummyString(1024)));
|
|
|
|
ASSERT_OK(dbfull()->Put(WriteOptions(), "key2", DummyString(1024)));
|
|
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
|
|
ASSERT_OK(dbfull()->Put(WriteOptions(), "key3", DummyString(1024)));
|
|
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
|
|
ASSERT_OK(dbfull()->Put(WriteOptions(), "key4", DummyString(1024)));
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
|
"WalManager::PurgeObsoleteFiles:1", [&](void*) {
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ExpectRecords(4, iter);
|
|
});
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions(), cf));
|
|
|
|
delete cf;
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
#endif
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorStallAtLastRecord) {
|
|
do {
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
ASSERT_OK(Put("key1", DummyString(1024)));
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(iter->Valid());
|
|
iter->Next();
|
|
ASSERT_TRUE(!iter->Valid());
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_OK(Put("key2", DummyString(1024)));
|
|
iter->Next();
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(iter->Valid());
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorCheckAfterRestart) {
|
|
do {
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
ASSERT_OK(Put("key1", DummyString(1024)));
|
|
ASSERT_OK(Put("key2", DummyString(1023)));
|
|
ASSERT_OK(dbfull()->Flush(FlushOptions()));
|
|
Reopen(options);
|
|
auto iter = OpenTransactionLogIter(0);
|
|
ExpectRecords(2, iter);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorCorruptedLog) {
|
|
do {
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
|
|
for (int i = 0; i < 1024; i++) {
|
|
ASSERT_OK(Put("key" + std::to_string(i), DummyString(10)));
|
|
}
|
|
|
|
ASSERT_OK(Flush());
|
|
ASSERT_OK(db_->FlushWAL(false));
|
|
|
|
// Corrupt this log to create a gap
|
|
ASSERT_OK(db_->DisableFileDeletions());
|
|
|
|
VectorLogPtr wal_files;
|
|
ASSERT_OK(db_->GetSortedWalFiles(wal_files));
|
|
ASSERT_FALSE(wal_files.empty());
|
|
|
|
const auto logfile_path = dbname_ + "/" + wal_files.front()->PathName();
|
|
ASSERT_OK(test::TruncateFile(env_, logfile_path,
|
|
wal_files.front()->SizeFileBytes() / 2));
|
|
|
|
ASSERT_OK(db_->EnableFileDeletions(/*force=*/false));
|
|
|
|
// Insert a new entry to a new log file
|
|
ASSERT_OK(Put("key1025", DummyString(10)));
|
|
ASSERT_OK(db_->FlushWAL(false));
|
|
|
|
// Try to read from the beginning. Should stop before the gap and read less
|
|
// than 1025 entries
|
|
auto iter = OpenTransactionLogIter(0);
|
|
int count = 0;
|
|
SequenceNumber last_sequence_read = ReadRecords(iter, count, false);
|
|
ASSERT_LT(last_sequence_read, 1025U);
|
|
|
|
// Try to read past the gap, should be able to seek to key1025
|
|
auto iter2 = OpenTransactionLogIter(last_sequence_read + 1);
|
|
ExpectRecords(1, iter2);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorBatchOperations) {
|
|
do {
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
WriteBatch batch;
|
|
ASSERT_OK(batch.Put(handles_[1], "key1", DummyString(1024)));
|
|
ASSERT_OK(batch.Put(handles_[0], "key2", DummyString(1024)));
|
|
ASSERT_OK(batch.Put(handles_[1], "key3", DummyString(1024)));
|
|
ASSERT_OK(batch.Delete(handles_[0], "key2"));
|
|
ASSERT_OK(dbfull()->Write(WriteOptions(), &batch));
|
|
ASSERT_OK(Flush(1));
|
|
ASSERT_OK(Flush(0));
|
|
ReopenWithColumnFamilies({"default", "pikachu"}, options);
|
|
ASSERT_OK(Put(1, "key4", DummyString(1024)));
|
|
auto iter = OpenTransactionLogIter(3);
|
|
ExpectRecords(2, iter);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestXactLogIterator, TransactionLogIteratorBlobs) {
|
|
Options options = OptionsForLogIterTest();
|
|
DestroyAndReopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
{
|
|
WriteBatch batch;
|
|
ASSERT_OK(batch.Put(handles_[1], "key1", DummyString(1024)));
|
|
ASSERT_OK(batch.Put(handles_[0], "key2", DummyString(1024)));
|
|
ASSERT_OK(batch.PutLogData(Slice("blob1")));
|
|
ASSERT_OK(batch.Put(handles_[1], "key3", DummyString(1024)));
|
|
ASSERT_OK(batch.PutLogData(Slice("blob2")));
|
|
ASSERT_OK(batch.Delete(handles_[0], "key2"));
|
|
ASSERT_OK(dbfull()->Write(WriteOptions(), &batch));
|
|
ReopenWithColumnFamilies({"default", "pikachu"}, options);
|
|
}
|
|
|
|
auto res = OpenTransactionLogIter(0)->GetBatch();
|
|
struct Handler : public WriteBatch::Handler {
|
|
std::string seen;
|
|
Status PutCF(uint32_t cf, const Slice& key, const Slice& value) override {
|
|
seen += "Put(" + std::to_string(cf) + ", " + key.ToString() + ", " +
|
|
std::to_string(value.size()) + ")";
|
|
return Status::OK();
|
|
}
|
|
Status MergeCF(uint32_t cf, const Slice& key, const Slice& value) override {
|
|
seen += "Merge(" + std::to_string(cf) + ", " + key.ToString() + ", " +
|
|
std::to_string(value.size()) + ")";
|
|
return Status::OK();
|
|
}
|
|
void LogData(const Slice& blob) override {
|
|
seen += "LogData(" + blob.ToString() + ")";
|
|
}
|
|
Status DeleteCF(uint32_t cf, const Slice& key) override {
|
|
seen += "Delete(" + std::to_string(cf) + ", " + key.ToString() + ")";
|
|
return Status::OK();
|
|
}
|
|
} handler;
|
|
ASSERT_OK(res.writeBatchPtr->Iterate(&handler));
|
|
ASSERT_EQ(
|
|
"Put(1, key1, 1024)"
|
|
"Put(0, key2, 1024)"
|
|
"LogData(blob1)"
|
|
"Put(1, key3, 1024)"
|
|
"LogData(blob2)"
|
|
"Delete(0, key2)",
|
|
handler.seen);
|
|
}
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
|
|
int main(int argc, char** argv) {
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|