3 commits

Author	SHA1	Message	Date
Andrew Kryczka	f548da33e8	Follow symlinks in chroot directory ... Summary: On Mac OS X, the chroot directory we typically use ("/tmp") is actually a symlink for "/private/tmp". Since we dereference symlinks in user-defined paths, we must also dereference symlinks in chroot_dir_ such that we can perform string comparisons on those paths. Test Plan: ran env_test on Mac OS X and devserver Reviewers: sdong, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: andrewkr, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D57957	2016-05-10 09:53:52 -07:00
Andrew Kryczka	a9b3c47c8e	Fix includes for clang on OS X ... Summary: Fix below error: use of undeclared identifier 'errno' Test Plan: doitlive Reviewers: IslamAbdelRahman, sdong Subscribers: andrewkr, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D57849	2016-05-06 18:32:54 -07:00
Andrew Kryczka	3f16a836a4	Introduce chroot Env ... Summary: For testing backups, we needed an Env that is fully isolated from other Envs on the same machine. Our in-memory Envs (MockEnv and InMemoryEnv) were insufficient because they don't implement most directory operations. This diff introduces a new Env, "ChrootEnv", that translates paths such that the chroot directory appears to be the root directory. This way, multiple Envs can be isolated in the filesystem by using different chroot directories. Since we use the filesystem, all directory operations are trivially supported. Test Plan: I parameterized the existing EnvPosixTest so it runs tests on ChrootEnv except the ioctl-related cases. Reviewers: sdong, lightmark, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: andrewkr, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D57543	2016-05-06 17:42:50 -07:00