Commit graph

5 commits

Author SHA1 Message Date
fyrz d6169954bd Removed code which prevents arc lint from working properly. 2014-10-07 17:40:19 +02:00
Igor Canadi 99fb613e54 remove 2 space linter 2014-09-29 15:52:12 -07:00
Igor Canadi b2d64a4861 Fix linters, second try 2014-09-29 15:48:43 -07:00
Igor Canadi 56ebd40877 Fix arc lint (should fix #238)
Summary: See https://secure.phabricator.com/D9114

Test Plan: arc lint

Reviewers: yhchiang

Reviewed By: yhchiang

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D24195
2014-09-29 15:10:37 -07:00
kailiu d0458469c8 Add google-style checker to "arc lint"
Summary:
After we reached a consensus on code format, which follows exactly
Google's coding style, a natural follow-up is to have a style checker
that can handle stuffs beyond format.

Google already has a powerful style checker "cpplint.py" and,
luckily, phabricator already provides the built-in linter for it!
Next time with "arc lint" most style inconsistency will be detected
(but will not be fixed).

Also I copied cpplint.py to linters directory, which is mostly
because we may need the flexibility to make some modifications on
it for our own need.

Test Plan:
ran arc lint table/block_based_table_builder.cc to see the amazing
results.

Reviewers: haobo, sdong, igor, dhruba

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D15369
2014-01-23 15:04:12 -08:00