From f0edf9d57554c7726c58cc2c08aa8193f88f3240 Mon Sep 17 00:00:00 2001 From: datonli Date: Thu, 4 Apr 2019 11:31:04 -0700 Subject: [PATCH] #5145 , rename port/dirent.h to port/port_dirent.h to avoid compile err when use port dir as header dir output (#5152) Summary: mv port/dirent.h to port/port_dirent.h to avoid compile err when use port dir as header dir output Pull Request resolved: https://github.com/facebook/rocksdb/pull/5152 Differential Revision: D14779409 Pulled By: siying fbshipit-source-id: d4162c47c979c6e8cc6a9e601802864ab3768ecb --- WINDOWS_PORT.md | 2 +- port/{dirent.h => port_dirent.h} | 0 port/win/env_win.cc | 2 +- port/win/port_win.cc | 2 +- tools/ldb_cmd.cc | 2 +- 5 files changed, 4 insertions(+), 4 deletions(-) rename port/{dirent.h => port_dirent.h} (100%) diff --git a/WINDOWS_PORT.md b/WINDOWS_PORT.md index 7eee295672..57293c97c9 100644 --- a/WINDOWS_PORT.md +++ b/WINDOWS_PORT.md @@ -43,7 +43,7 @@ We plan to use this port for our business purposes here at Bing and this provide * Certain headers that are not present and not necessary on Windows were simply `#ifndef OS_WIN` in a few places (`unistd.h`) * All posix specific headers were replaced to port/port.h which worked well -* Replaced `dirent.h` for `port/dirent.h` (very few places) with the implementation of the relevant interfaces within `rocksdb::port` namespace +* Replaced `dirent.h` for `port/port_dirent.h` (very few places) with the implementation of the relevant interfaces within `rocksdb::port` namespace * Replaced `sys/time.h` to `port/sys_time.h` (few places) implemented equivalents within `rocksdb::port` * `printf %z` specification is not supported on Windows. To imitate existing standards we came up with a string macro `ROCKSDB_PRIszt` which expands to `zu` on posix systems and to `Iu` on windows. * in class member initialization were moved to a __ctors in some cases diff --git a/port/dirent.h b/port/port_dirent.h similarity index 100% rename from port/dirent.h rename to port/port_dirent.h diff --git a/port/win/env_win.cc b/port/win/env_win.cc index e77cd474d9..9abb14d67e 100644 --- a/port/win/env_win.cc +++ b/port/win/env_win.cc @@ -24,7 +24,7 @@ #include "rocksdb/slice.h" #include "port/port.h" -#include "port/dirent.h" +#include "port/port_dirent.h" #include "port/win/win_logger.h" #include "port/win/io_win.h" diff --git a/port/win/port_win.cc b/port/win/port_win.cc index 9b9a5f1bb6..03ba6ef428 100644 --- a/port/win/port_win.cc +++ b/port/win/port_win.cc @@ -14,7 +14,7 @@ #include "port/win/port_win.h" #include -#include "port/dirent.h" +#include "port/port_dirent.h" #include "port/sys_time.h" #include diff --git a/tools/ldb_cmd.cc b/tools/ldb_cmd.cc index 9bf5f4629e..e106bfbb2f 100644 --- a/tools/ldb_cmd.cc +++ b/tools/ldb_cmd.cc @@ -16,7 +16,7 @@ #include "db/dbformat.h" #include "db/log_reader.h" #include "db/write_batch_internal.h" -#include "port/dirent.h" +#include "port/port_dirent.h" #include "rocksdb/cache.h" #include "rocksdb/table_properties.h" #include "rocksdb/utilities/backupable_db.h"