mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 07:30:54 +00:00
Remove Stats related to compressed block cache (#11135)
Summary: Since compressed block cache is removed, those stats are not needed. They are removed in different PR in case there is a problem with it. The stats are removed in the same way in https://github.com/facebook/rocksdb/pull/11131/ . HISTORY.md was already updated by mistake, and it would be correct after merging this PR. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11135 Test Plan: Watch CI Reviewed By: ltamasi Differential Revision: D42757616 fbshipit-source-id: bd7cb782585c8535ce5784295225c376f3011f35
This commit is contained in:
parent
6da2e20df3
commit
e808858ae0
|
@ -305,7 +305,7 @@ extern void InitializeOptionsFromFlags(
|
||||||
// There are two cases.
|
// There are two cases.
|
||||||
// Case 1: OPTIONS file is not specified. Command line arguments have been used
|
// Case 1: OPTIONS file is not specified. Command line arguments have been used
|
||||||
// to initialize `options`. InitializeOptionsGeneral() will use
|
// to initialize `options`. InitializeOptionsGeneral() will use
|
||||||
// `cache`, `block_cache_compressed` and `filter_policy` to initialize
|
// `cache` and `filter_policy` to initialize
|
||||||
// corresponding fields of `options`. InitializeOptionsGeneral() will
|
// corresponding fields of `options`. InitializeOptionsGeneral() will
|
||||||
// also set up other fields of `options` so that stress test can run.
|
// also set up other fields of `options` so that stress test can run.
|
||||||
// Examples include `create_if_missing` and
|
// Examples include `create_if_missing` and
|
||||||
|
@ -316,7 +316,7 @@ extern void InitializeOptionsFromFlags(
|
||||||
// case, if command line arguments indicate that the user wants to set
|
// case, if command line arguments indicate that the user wants to set
|
||||||
// up such shared objects, e.g. block cache, compressed block cache,
|
// up such shared objects, e.g. block cache, compressed block cache,
|
||||||
// row cache, filter policy, then InitializeOptionsGeneral() will honor
|
// row cache, filter policy, then InitializeOptionsGeneral() will honor
|
||||||
// the user's choice, thus passing `cache`, `block_cache_compressed`,
|
// the user's choice, thus passing `cache`,
|
||||||
// `filter_policy` as input arguments.
|
// `filter_policy` as input arguments.
|
||||||
//
|
//
|
||||||
// InitializeOptionsGeneral() must not overwrite fields of `options` loaded
|
// InitializeOptionsGeneral() must not overwrite fields of `options` loaded
|
||||||
|
|
|
@ -170,12 +170,6 @@ enum Tickers : uint32_t {
|
||||||
// Record the number of calls to GetUpdatesSince. Useful to keep track of
|
// Record the number of calls to GetUpdatesSince. Useful to keep track of
|
||||||
// transaction log iterator refreshes
|
// transaction log iterator refreshes
|
||||||
GET_UPDATES_SINCE_CALLS,
|
GET_UPDATES_SINCE_CALLS,
|
||||||
BLOCK_CACHE_COMPRESSED_MISS, // miss in the compressed block cache
|
|
||||||
BLOCK_CACHE_COMPRESSED_HIT, // hit in the compressed block cache
|
|
||||||
// Number of blocks added to compressed block cache
|
|
||||||
BLOCK_CACHE_COMPRESSED_ADD,
|
|
||||||
// Number of failures when adding blocks to compressed block cache
|
|
||||||
BLOCK_CACHE_COMPRESSED_ADD_FAILURES,
|
|
||||||
WAL_FILE_SYNCED, // Number of times WAL sync is done
|
WAL_FILE_SYNCED, // Number of times WAL sync is done
|
||||||
WAL_FILE_BYTES, // Number of bytes written to WAL
|
WAL_FILE_BYTES, // Number of bytes written to WAL
|
||||||
|
|
||||||
|
|
|
@ -4904,14 +4904,6 @@ class TickerTypeJni {
|
||||||
return 0x40;
|
return 0x40;
|
||||||
case ROCKSDB_NAMESPACE::Tickers::GET_UPDATES_SINCE_CALLS:
|
case ROCKSDB_NAMESPACE::Tickers::GET_UPDATES_SINCE_CALLS:
|
||||||
return 0x41;
|
return 0x41;
|
||||||
case ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_MISS:
|
|
||||||
return 0x42;
|
|
||||||
case ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_HIT:
|
|
||||||
return 0x43;
|
|
||||||
case ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_ADD:
|
|
||||||
return 0x44;
|
|
||||||
case ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_ADD_FAILURES:
|
|
||||||
return 0x45;
|
|
||||||
case ROCKSDB_NAMESPACE::Tickers::WAL_FILE_SYNCED:
|
case ROCKSDB_NAMESPACE::Tickers::WAL_FILE_SYNCED:
|
||||||
return 0x46;
|
return 0x46;
|
||||||
case ROCKSDB_NAMESPACE::Tickers::WAL_FILE_BYTES:
|
case ROCKSDB_NAMESPACE::Tickers::WAL_FILE_BYTES:
|
||||||
|
@ -5261,14 +5253,6 @@ class TickerTypeJni {
|
||||||
return ROCKSDB_NAMESPACE::Tickers::NUMBER_OF_RESEEKS_IN_ITERATION;
|
return ROCKSDB_NAMESPACE::Tickers::NUMBER_OF_RESEEKS_IN_ITERATION;
|
||||||
case 0x41:
|
case 0x41:
|
||||||
return ROCKSDB_NAMESPACE::Tickers::GET_UPDATES_SINCE_CALLS;
|
return ROCKSDB_NAMESPACE::Tickers::GET_UPDATES_SINCE_CALLS;
|
||||||
case 0x42:
|
|
||||||
return ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_MISS;
|
|
||||||
case 0x43:
|
|
||||||
return ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_HIT;
|
|
||||||
case 0x44:
|
|
||||||
return ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_ADD;
|
|
||||||
case 0x45:
|
|
||||||
return ROCKSDB_NAMESPACE::Tickers::BLOCK_CACHE_COMPRESSED_ADD_FAILURES;
|
|
||||||
case 0x46:
|
case 0x46:
|
||||||
return ROCKSDB_NAMESPACE::Tickers::WAL_FILE_SYNCED;
|
return ROCKSDB_NAMESPACE::Tickers::WAL_FILE_SYNCED;
|
||||||
case 0x47:
|
case 0x47:
|
||||||
|
|
|
@ -312,26 +312,6 @@ public enum TickerType {
|
||||||
*/
|
*/
|
||||||
GET_UPDATES_SINCE_CALLS((byte) 0x41),
|
GET_UPDATES_SINCE_CALLS((byte) 0x41),
|
||||||
|
|
||||||
/**
|
|
||||||
* Miss in the compressed block cache.
|
|
||||||
*/
|
|
||||||
BLOCK_CACHE_COMPRESSED_MISS((byte) 0x42),
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Hit in the compressed block cache.
|
|
||||||
*/
|
|
||||||
BLOCK_CACHE_COMPRESSED_HIT((byte) 0x43),
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Number of blocks added to compressed block cache.
|
|
||||||
*/
|
|
||||||
BLOCK_CACHE_COMPRESSED_ADD((byte) 0x44),
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Number of failures when adding blocks to compressed block cache.
|
|
||||||
*/
|
|
||||||
BLOCK_CACHE_COMPRESSED_ADD_FAILURES((byte) 0x45),
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Number of times WAL sync is done.
|
* Number of times WAL sync is done.
|
||||||
*/
|
*/
|
||||||
|
|
|
@ -85,11 +85,6 @@ const std::vector<std::pair<Tickers, std::string>> TickersNameMap = {
|
||||||
{BLOOM_FILTER_PREFIX_USEFUL, "rocksdb.bloom.filter.prefix.useful"},
|
{BLOOM_FILTER_PREFIX_USEFUL, "rocksdb.bloom.filter.prefix.useful"},
|
||||||
{NUMBER_OF_RESEEKS_IN_ITERATION, "rocksdb.number.reseeks.iteration"},
|
{NUMBER_OF_RESEEKS_IN_ITERATION, "rocksdb.number.reseeks.iteration"},
|
||||||
{GET_UPDATES_SINCE_CALLS, "rocksdb.getupdatessince.calls"},
|
{GET_UPDATES_SINCE_CALLS, "rocksdb.getupdatessince.calls"},
|
||||||
{BLOCK_CACHE_COMPRESSED_MISS, "rocksdb.block.cachecompressed.miss"},
|
|
||||||
{BLOCK_CACHE_COMPRESSED_HIT, "rocksdb.block.cachecompressed.hit"},
|
|
||||||
{BLOCK_CACHE_COMPRESSED_ADD, "rocksdb.block.cachecompressed.add"},
|
|
||||||
{BLOCK_CACHE_COMPRESSED_ADD_FAILURES,
|
|
||||||
"rocksdb.block.cachecompressed.add.failures"},
|
|
||||||
{WAL_FILE_SYNCED, "rocksdb.wal.synced"},
|
{WAL_FILE_SYNCED, "rocksdb.wal.synced"},
|
||||||
{WAL_FILE_BYTES, "rocksdb.wal.bytes"},
|
{WAL_FILE_BYTES, "rocksdb.wal.bytes"},
|
||||||
{WRITE_DONE_BY_SELF, "rocksdb.write.self"},
|
{WRITE_DONE_BY_SELF, "rocksdb.write.self"},
|
||||||
|
|
Loading…
Reference in a new issue