dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-29 00:34:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-analyzer false-positive on ldb_cmd.cc

Browse source 
Summary:
clang-analyzer complaint about db_ being nullptr, but it couldn't be because it checks exec_stats before proceed. Add an assert to get around the false-positive.

Test Plan
`make analyze`
Closes https://github.com/facebook/rocksdb/pull/3236

Differential Revision: D6505417

Pulled By: yiwu-arbug

fbshipit-source-id: e5b65764ea994dd9e4bab3e697b97dc70dc22cab
This commit is contained in:
Yi Wu 2017-12-06 22:54:11 -08:00 committed by Facebook Github Bot
parent bbef8c3884
commit e1c569c324
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tools/ldb_cmd.cc
View file

@ -1689,6 +1689,7 @@ void ReduceDBLevelsCommand::DoCommand() {
if (exec_state_.IsFailed()) { if (exec_state_.IsFailed()) {
return; return;
} }
assert(db_ != nullptr);
// Compact the whole DB to put all files to the highest level. // Compact the whole DB to put all files to the highest level.
fprintf(stdout, "Compacting the db...\n"); fprintf(stdout, "Compacting the db...\n");
db_->CompactRange(CompactRangeOptions(), GetCfHandle(), nullptr, nullptr); db_->CompactRange(CompactRangeOptions(), GetCfHandle(), nullptr, nullptr);