From d963661d6f6da7c31792111eb3f2fd49cec62c50 Mon Sep 17 00:00:00 2001 From: Yang Zhang Date: Mon, 7 Oct 2024 14:43:20 -0700 Subject: [PATCH] Correct CMake minimum required version (#13056) Summary: https://github.com/facebook/rocksdb/blob/263fa15b445935e8229063a080e22a405276df2f/CMakeLists.txt#L44 `HOMEPAGE_URL` is introduced into CMake since 3.12. Compiling RocksDB with CMake ver < 3.12 triggers `CMake Error: Could not find cmake module file: CMakeDetermineHOMEPAGE_URLCompiler.cmake` error. 2 options to fix it: * Remove `HOMEPAGE_URL`, since it appears to have no practical effect. * Update RocksDB's minimum required CMake version to 3.12. This PR chose the second option. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13056 Reviewed By: jaykorean Differential Revision: D63993577 Pulled By: cbi42 fbshipit-source-id: a6278af6916fcdace19a6c9baaf7986037bff720 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 93b884dd9c..17dced38ca 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -32,7 +32,7 @@ # 3. cmake .. # 4. make -j -cmake_minimum_required(VERSION 3.10) +cmake_minimum_required(VERSION 3.12) list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake/modules/") include(ReadVersion)