dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable fault injection with BatchedOpsStressTest and MultiOpsTxnsStressTest (#12794) 

Summary:
**Context/Summary:**

https://github.com/facebook/rocksdb/pull/12713 accidentally turned on fault injection in BatchedOpsStressTest and MultiOpsTxnsStressTest. Though this was meant to be an increased testing coverage, it also made our CI noisy. For now we decided to disable it before we manage to stabilize the CI and fix bugs surfaced in NonBatchedOpsStressTest which impacts more users.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12794

Test Plan: CI

Reviewed By: cbi42

Differential Revision: D58897598

Pulled By: hx235

fbshipit-source-id: 8094072ef1bff27d7825efed0876f365a31fef9c
This commit is contained in:
Hui Xiao 2024-06-21 19:50:59 -07:00 committed by Facebook GitHub Bot
parent 3ee4d5a11a
commit d6cf9de9d9
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/db_crashtest.py
View File

@ -695,6 +695,11 @@ def finalize_and_sanitize(src_params):
if dest_params["test_batches_snapshots"] == 1: if dest_params["test_batches_snapshots"] == 1:
dest_params["enable_compaction_filter"] = 0 dest_params["enable_compaction_filter"] = 0
dest_params["inplace_update_support"] = 0 dest_params["inplace_update_support"] = 0
# TODO(hx235): enable test_batches_snapshots with fault injection after stabilizing the CI
dest_params["write_fault_one_in"] = 0
dest_params["metadata_write_fault_one_in"] = 0
dest_params["read_fault_one_in"] = 0
dest_params["metadata_read_fault_one_in"] = 0
if dest_params["prefix_size"] < 0: if dest_params["prefix_size"] < 0:
dest_params["prefix_size"] = 1 dest_params["prefix_size"] = 1
@ -815,6 +820,12 @@ def finalize_and_sanitize(src_params):
# Wide-column pessimistic transaction APIs are initially supported for # Wide-column pessimistic transaction APIs are initially supported for
# WriteCommitted only # WriteCommitted only
dest_params["use_put_entity_one_in"] = 0 dest_params["use_put_entity_one_in"] = 0
# TODO(hx235): enable test_multi_ops_txns with fault injection after stabilizing the CI
if dest_params.get("test_multi_ops_txns") == 1:
dest_params["write_fault_one_in"] = 0
dest_params["metadata_write_fault_one_in"] = 0
dest_params["read_fault_one_in"] = 0
dest_params["metadata_read_fault_one_in"] = 0
# Wide column stress tests require FullMergeV3 # Wide column stress tests require FullMergeV3
if dest_params["use_put_entity_one_in"] != 0: if dest_params["use_put_entity_one_in"] != 0:
dest_params["use_full_merge_v1"] = 0 dest_params["use_full_merge_v1"] = 0